Average Daily Range (ADR) - code check | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

ADR Average daily Range Indicator 206 replies

New Average Daily Range (ADR) Indicator 80 replies

Daily Trading Strategy [ADR + RSI = High Probability] 904 replies

Average Daily Range Table (ADR) 63 replies

Sound Alert for ADR (Average Daily Range) 1 reply

Attachments: Average Daily Range (ADR) - code check
Exit Attachments

Average Daily Range (ADR) - code check

  • #1
  • First Post: Mar 17, 2009 12:33pm Mar 17, 2009 12:33pm
hey,

can someone check the following code for calculating the ADR? it is coded that way that it skips sunday bars...

Quote
int getADR(string s, int days)
{
int adr=0,i=0;
int tmp_days = days;

for(i=1;i<=tmp_days;i++) {

if (TimeDayOfWeek(iTime(s,PERIOD_D1,i)) < 1 || TimeDayOfWeek(iTime(s,PERIOD_D1,i)) > 5) {
tmp_days++;

} else {
adr = adr + (iHigh(s,PERIOD_D1,i)-iLow(s,PERIOD_D1,i)) / MarketInfo(s,MODE_POINT);
}

}

adr = adr/days;

return (adr);
}
thank you, cheers!
  • #2
  • Jul 23, 2009 9:56pm Jul 23, 2009 9:56pm
Quoting tranquilizer
hey,

can someone check the following code for calculating the ADR? it is coded that way that it skips sunday bars...

thank you, cheers!
MarketInfo(s,MODE_POINT) will result in 0 and give you a divide-by-zero error for all non-JPY currency pairs.
  • #3
  • Jul 23, 2009 10:11pm Jul 23, 2009 10:11pm
Quoting tranquilizer
hey,

can someone check the following code for calculating the ADR? it is coded that way that it skips sunday bars...

thank you, cheers!
My version of implementation is this. I had to use a custom function FindAndReplace() to detect if the symbol has a Yen component. Let me know if you need the source code. If you need to skip Sunday bars you might as well switch to another MT4 broker that do not include Sunday bars. This is because your price charts will always show Sunday bars if your broker provides Sunday bars. I know some UK-based brokers do Sunday bars, unlike US-based brokers.

http://www.apparelink.com/shared/ar_code.PNG

ADR Indicator screenshot:

http://www.apparelink.com/shared/gbp_d1_ar.gif

My test results are consistent with what you see on this site http://www.aboutcurrency.com/univers...cy_pairs.shtml
  • #4
  • Sep 25, 2009 6:27am Sep 25, 2009 6:27am
I finally found the "ADR" indi which excludes the Sunday bar in calculation. I'm trying to add a label when ADR is NOT reached.. to show, in red... "Not Reached" and when it is reached then show in green "ADR Reached" (just for simplicity here).

I have made some severe hacks to script and right now it shows "Not Reached" in red... and when it is reached it does show in green "Reached"... However, I need the red label "Not reached" to disappear and be replaced with the green label and vice versa. Right now they appear one on top of the other and stay there. Do I use the "ObjectDelete" on each? In "deinit" or under each label?

NOTE to others: This indi also had ATR (which I simply commented out as I believe ATR is not relevant in Forex) and it calculates ADR correctly. I've verified it using Excel. So... it works... it's just not very pretty.

Thank you for the help
Attached File(s)
File Type: mq4 ADR_no_sunday_bar.mq4   5 KB | 1,346 downloads
  • #5
  • Sep 25, 2009 4:35pm Sep 25, 2009 4:35pm
pipimo88, try this see if it works for you. if the problem happens again then change time frame to update data. if it works I will post a cleaned up version later. it worked for me on fxdd, did not have time try on different brokers.

Tom
Attached File(s)
File Type: mq4 ADR_no_sunday_bar.v1.mq4   6 KB | 1,797 downloads
  • #6
  • Sep 28, 2009 7:08am Sep 28, 2009 7:08am
Attached is the image what the indi does. Once ADR is reached... The original "Not reached" in red is still there and green "reached" appears on top of it. Same issue I had as before.

The improvement is the switching timeframes will "refresh" the indi and it WILL display correctly... until the next time the "opposite" label appears.

I've definitelly seen indis where "objects" can be flipped on and off automatically... just can't get this one to do it. Thanks for trying. Any other ideas?
Attached Image
  • #7
  • Nov 15, 2009 6:15am Nov 15, 2009 6:15am
Hi!

I understand that the Average Daily Range is calculated over several days where each day's range (hi - lo) is averaged.

Can someone explain to me what people mean when they say Weekly ADR or Monthly ADR or 180day ADR? How is it calculated?

e.g. Does Weekly ADR = last week's ADR of the week's 5 trading days?

I have seen many people use these terms including people talk about yearly ADR but have so far never seen a rule that defines how it should be calculated.

Any help is explaining would be well appreciated.

Cheers!
  • #8
  • Apr 29, 2020 12:35pm Apr 29, 2020 12:35pm
Above text overlap corrected - https://www.forexfactory.com/showthr...8#post12909478
TSLA: 30-Dec-22 123.18 // 16-Jun-23 260.54 **111.51%**
  • #9
  • Jan 10, 2021 5:16pm Jan 10, 2021 5:16pm
Quoting pipimo88
I finally found the "ADR" indi which excludes the Sunday bar in calculation. I'm trying to add a label when ADR is NOT reached.. to show, in red... "Not Reached" and when it is reached then show in green "ADR Reached" (just for simplicity here). I have made some severe hacks to script and right now it shows "Not Reached" in red... and when it is reached it does show in green "Reached"... However, I need the red label "Not reached" to disappear and be replaced with the green label and vice versa. Right now they appear one on top of the other and...

Can you make this for meta trader 5?
  • #10
  • May 12, 2024 3:22pm May 12, 2024 3:22pm
Quoting Phylo
Above text overlap corrected - https://www.forexfactory.com/showthr...8#post12909478
thank you
  • #11
  • May 14, 2024 1:28am May 14, 2024 1:28am
Quoting BlakJak
Hi! I understand that the Average Daily Range is calculated over several days where each day's range (hi - lo) is averaged. Can someone explain to me what people mean when they say Weekly ADR or Monthly ADR or 180day ADR? How is it calculated? e.g. Does Weekly ADR = last week's ADR of the week's 5 trading days? I have seen many people use these terms including people talk about yearly ADR but have so far never seen a rule that defines how it should be calculated. Any help is explaining would be well appreciated. Cheers!
The truth is out there

And if you truly want to know, seek and ye shall find.

Attached Image (click to enlarge)
Click to Enlarge Name: 2024-05-14_18-24-37.jpg Size: 594 KB
It takes a lot for me to IGNORE you, but you can try.
  • #12
  • Last Post: May 16, 2026 1:14am May 16, 2026 1:14am
Free ADR Day Range Indicator with Built-in Alerts and Push Notifications.

https://www.mql5.com/en/market/product/171201#
Attached Image (click to enlarge)
Click to Enlarge Name: IMG_20260426_224752.png.webp Size: 16 KB
0 traders viewing now