Simple programming help needed | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Looking for help on programming SIMPLE EA 9 replies

Simple Programming help with my EA? 2 replies

EA programming for Metatrader4 Help needed 2 replies

MACD programming help needed 2 replies

Programming help needed 0 replies

Simple programming help needed

  • #1
  • First Post: Oct 30, 2009 12:51am Oct 30, 2009 12:51am


I am not a coder, obviously i make a few changes here and there when I can figure it out but I ain't too smart!

As with many indicators with levels, the code is not color coded for the different levels.

SetLevelValue(0,50);
SetLevelValue(1,80);
SetLevelValue(2,20);
SetLevelStyle(STYLE_DOT,1,Gray);

Standard RSI indy. I want to color code the levels.
 This below didn't work:

SetLevelValue(0,50);
SetLevelValue(1,80);
SetLevelValue(2,20);
SetLevelStyle(0,STYLE_DOT,1,Yellow);
SetLevelStyle(1,STYLE_DOT,1,Green);
SetLevelStyle(2,STYLE_DOT,1,Red);

Can you post the proper correction? Thanks

Cheers
  • #2
  • Edited 2:07am Oct 30, 2009 1:55am | Edited 2:07am
the problem is that you can only set a style for ALL levels, not individual levels. You will even see in your first block of code that you did it correct...

Inserted Code
[i]SetLevelValue(0,50);
   SetLevelValue(1,80);
   SetLevelValue(2,20);
   SetLevelStyle(STYLE_DOT,1,Gray);[/i]
SetLevelStyle(style, line width, colour). You did this correct. Now all levels will be Style_Dot, width 1, and Gray. In the next section you try to be specific about which level you are talking about, and the SetLevelStyle function simply isn't designed this way...

Inserted Code
[i]SetLevelValue(0,50);
   SetLevelValue(1,80);
   SetLevelValue(2,20);
   SetLevelStyle(0,STYLE_DOT,1,Yellow)  ;
   SetLevelStyle(1,STYLE_DOT,1,Green);
   SetLevelStyle(2,STYLE_DOT,1,Red);[/i]
in this case you have added a number at the beginning of the parameters intending to specify which level you are modifying. You simply can't do this. Rip out the SetLevelStyle's from this section and just have the one from the first block and set the style width and colour for ALL levels there.

What you are trying to do is probably going to be accomplished easier by creating a HLine object.

If I correctly understand what you are trying to achieve then you want to be able to load up the RSI indicator which appears in a sub-window, then be able to visualize the 50 / 80 / 20 levels on THAT sub-window. If this is correct then create a new custom indicator (or replace the one you have tried to write) with the following and see if this is what you are after... note that if you load-up a few different indicators you need to find out which window number the RSI indicator is and enter that in the WindowNumber property panel when you run the below custom indicator. you find out which number the RSI indicator window is simply by right-clicking on your chart, selecting Indicators, then looking at what section the RSI indicator is in (e.g. "Indicator Window 1", "Indicator Window 2", and so on). That is the number you enter into my custom indicator to tell it which sub-window to affect. If you only have the RSI indicator sub-window then you don't need to do anything as my custom indicator automatically goes to the first sub-window anyway... it's only going to need to be changed in properties if you load up one or more sub-window indicators before loading the RSI indicator, as the RSI won't be sub-window 1 in this case. Hope this makes sense.

I think this is bug-free, but I only just wrote it so fingers-crossed.

Inserted Code
#property indicator_chart_window

extern int WindowNumber = 1;

extern int Line1 = 50;
extern color Line1Colour = Yellow;
extern int Line2 = 80;
extern color Line2Colour = Green;
extern int Line3 = 20;
extern color Line3Colour = Red;

int prevwindownumber = -1;

int init()
  {

   return(0);
  }

int deinit()
  {
  
  ObjectDelete("goldsurfer1");
  ObjectDelete("goldsurfer2");
  ObjectDelete("goldsurfer3");

   return(0);
  }

int start()
  {

  //check that user hasn't changed WindowNumber in properties  
  if (prevwindownumber != WindowNumber) {
    prevwindownumber = WindowNumber;
    ObjectDelete("goldsurfer1");
    ObjectDelete("goldsurfer2");
    ObjectDelete("goldsurfer3");    
  }

  //does the WindowNumber even correspond to a real window, if not delete then any objects that might still exist if previously created
  if (WindowsTotal() >= WindowNumber) {
    //WindowNumber is valid, so have the objects already been previously created yet or do I need to create them now
    if (ObjectFind("goldsurfer1") < 0) {
      //not previously created, so creating now.
      //this section will break though if the user decides to manually delete the first hline and leave the rest...
      //although the only error will be that mt4 is trying to create objects that already exist, so no big deal
      ObjectCreate("goldsurfer1", OBJ_HLINE, WindowNumber, 0, Line1);
      ObjectCreate("goldsurfer2", OBJ_HLINE, WindowNumber, 0, Line2);
      ObjectCreate("goldsurfer3", OBJ_HLINE, WindowNumber, 0, Line3);
    }

    //reset properties each tick in case user decides to mess with the objects on the chart
    ObjectSet("goldsurfer1", OBJPROP_PRICE1, Line1);
    ObjectSet("goldsurfer2", OBJPROP_PRICE1, Line2);
    ObjectSet("goldsurfer3", OBJPROP_PRICE1, Line3);
  
    ObjectSet("goldsurfer1", OBJPROP_COLOR, Line1Colour);
    ObjectSet("goldsurfer2", OBJPROP_COLOR, Line2Colour);
    ObjectSet("goldsurfer3", OBJPROP_COLOR, Line3Colour);
  
    ObjectSet("goldsurfer1", OBJPROP_WIDTH, 1);
    ObjectSet("goldsurfer2", OBJPROP_WIDTH, 1);
    ObjectSet("goldsurfer3", OBJPROP_WIDTH, 1);
  
    ObjectSet("goldsurfer1", OBJPROP_STYLE, STYLE_DOT);
    ObjectSet("goldsurfer2", OBJPROP_STYLE, STYLE_DOT);
    ObjectSet("goldsurfer3", OBJPROP_STYLE, STYLE_DOT);
  } else {
    ObjectDelete("goldsurfer1");
    ObjectDelete("goldsurfer2");
    ObjectDelete("goldsurfer3");  
  }

   return(0);
  }
Congratulations ScalaFX for coming out of the closet!
  • #3
  • Oct 30, 2009 11:28am Oct 30, 2009 11:28am
Thanks, much appreciated. I didn't write the indy, just trying to change it to my liking, so your answer may be a lil beyond my wee brain.....

But that explains to me why indys levels are not color coded

Cheers
  • #4
  • Last Post: Oct 30, 2009 12:44pm Oct 30, 2009 12:44pm
in that case you can still compile the above code into a new custom indicator, and then run that alongside the indicator you are using to have it affect it as i had coded it to do.

or you can have a go at ripping the code out of mine and making it work inside the code you already have. it will only require a few small alterations... delete some chunks of code and a few individual lines, and add a WindowFind in there.
Congratulations ScalaFX for coming out of the closet!
0 traders viewing now