ATR Indicator Mod | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Indicator (HP, Cycle) mod request 9 replies

Correct number of weeks for ATR and hour ATR 1 reply

Need indicator mod 7 replies

Dolly Graphics_v12 help mod this indicator 0 replies

Pivot Indicator Mod 4 replies

Attachments: ATR Indicator Mod
Exit Attachments

ATR Indicator Mod

  • #1
  • First Post: Oct 9, 2009 9:11am Oct 9, 2009 9:11am
Hi I wonder if anyone can help modify the attached indicator that someone kindly posted on here? It shows the ATR of a bar on the chart but I would like to be able to do two more calculations to this:
1. Add a spread to the ATR number (this can be fixed at 6pips)

2. multiply the result by a contract/unit number to provide a position size ( this is variable and need to be input at the time)

Any help or suggestions would be greatly appreciated!?

Have a great weekend everyone!

Best,
J
Attached File(s)
File Type: mq4 ATROnChart build220.mq4   2 KB | 530 downloads
  • #2
  • Oct 12, 2009 10:18pm Oct 12, 2009 10:18pm
James, here is the modification as requested. Rather than hardcoding the spread value, I used the value supplied by the system. My code changes are annotated. Let me know if you have any other mods.
Attached File(s)
File Type: mq4 ATROnChartMod.mq4   2 KB | 506 downloads
  • #3
  • Oct 14, 2009 8:10am Oct 14, 2009 8:10am
Quoting CodeMeister
James, here is the modification as requested. Rather than hardcoding the spread value, I used the value supplied by the system. My code changes are annotated. Let me know if you have any other mods.

Great that's fantastic thank you!......One more Mod if possible? Could we have a box on the chart below this indicator that allows us to input a value (eg.250 or 500) that is divided by the result of the first mod to give us a contract value?
Example:

ATR1 MO = 48 (first MOD)

Position Size = 500 ( second MOD.....this number to be variable)

No Contracts = 12 (actual 500/48= 10.41 rounded up to nearest even number)

One more thing.....is it possible to display this information for both the current and previous bar? Or up to 5 bars back if its easy?

I hope this is possible and not too much work and thank you hugely! If you want to PM/email me personally and ask any questions about the system I would be more than happy to answer your questions as a way of saying thanks!.....this is part of a system being traded by a very large and successful hedge fund.................
Thanks again!
Best,
J
  • #4
  • Edited 4:26pm Oct 16, 2009 4:22pm | Edited 4:26pm
James, here is the requested modified version. I was able to include 3 bars of data in the text string without taking up too much chart space. The risk amount needs to be input with the other settings, but it can be changed at any time and the indicator will recalculate the answer for the number of contracts. I had to modify the code extensively so it needs to be tested thoroughly. Let me know if anything needs fixing.

This was a very challenging and interesting project, contact me if you have another request like this.
Attached File(s)
File Type: mq4 ATROnChartMod2.mq4   4 KB | 492 downloads
  • #5
  • Oct 18, 2009 3:29am Oct 18, 2009 3:29am
That is excellent .......thank you very much indeed!
One slight mod; at least I hope its slight Ted!?........can we make the ATR (all 3) have a fixed 6 pip addition rather than be linked to spread....and can the contracts be rounded up or down to the nearest even number? I assume the 'Contracts' will then be the 'Positions Size' divide by the last ATR (inc. 6 pip spread) rounded up or down to the nearest even number?

The linking of the ATR to platform spread is amazing and may prove beneficial for another project but we don't need it for this one any longer.

Thanks,
J





Quoting CodeMeister
James, here is the requested modified version. I was able to include 3 bars of data in the text string without taking up too much chart space. The risk amount needs to be input with the other settings, but it can be changed at any time and the indicator will recalculate the answer for the number of contracts. I had to modify the code extensively so it needs to be tested thoroughly. Let me know if anything needs fixing.

This was a very challenging and interesting project, contact me if you have another request like this.
  • #6
  • Oct 18, 2009 8:39pm Oct 18, 2009 8:39pm
Here is the fixed code as requested. The spread is hardcoded at 6 pips for every pair and the calculation now rounds up and down to the nearest even number.
Attached File(s)
File Type: mq4 ATROnChartFix2.mq4   3 KB | 495 downloads
  • #7
  • Oct 21, 2009 11:22pm Oct 21, 2009 11:22pm
Thank you Codemeister for your great and incredibly fast work!
Best,
J



Quoting CodeMeister
Here is the fixed code as requested. The spread is hardcoded at 6 pips for every pair and the calculation now rounds up and down to the nearest even number.
  • #8
  • Edited 12:06am Oct 22, 2009 12:04am | Edited 12:06am
As requested here are the latest modifications you requested including limiting the number of decimals to 4, adding the high and low prices and adding the second contract calculation for the previous bar.

Please note that I had to shorten the annotation of the last 2 lines because there is a length restriction of 60 characters in MQ4. The third line is within 2 of that limit.
Attached File(s)
File Type: mq4 ATROnChartMod3.mq4   5 KB | 479 downloads
  • #9
  • Oct 22, 2009 1:34am Oct 22, 2009 1:34am
Thank you Codemeister....one thing I cant quite work out is the current bar ATR MO value which is the second value on the top if I am correct? It doesn't seem to compute on my charts....it should be the current bar ATR plus 6 pips right?
Best,
J



Quoting CodeMeister
As requested here are the latest modifications you requested including limiting the number of decimals to 4, adding the high and low prices and adding the second contract calculation for the previous bar.

Please note that I had to shorten the annotation of the last 2 lines because there is a length restriction of 60 characters in MQ4. The third line is within 2 of that limit.
  • #10
  • Oct 22, 2009 2:01am Oct 22, 2009 2:01am
Quoting JamesBranson
Thank you Codemeister....one thing I cant quite work out is the current bar ATR MO value which is the second value on the top if I am correct? It doesn't seem to compute on my charts....it should be the current bar ATR plus 6 pips right?
Best,
J
When I reorganized the code for the latest calculation things were done in the wrong order giving the wrong answer. Here is the corrected version.
Attached File(s)
File Type: mq4 ATROnChartMod3.mq4   5 KB | 487 downloads
  • #11
  • Oct 23, 2009 1:32am Oct 23, 2009 1:32am
Great Thank you it works perfectly now!
Best,
J
  • #12
  • Nov 2, 2009 2:37pm Nov 2, 2009 2:37pm
As requested here is the latest version with the following modifications:
1. Remove Prev Pos size and current pos size including data as we dont need to see this during the day only be able to change it.
2. Change Contract to simply C
3. Add a 3 pip spread to each of the H and PH and subtract 3 pip spread from the lows L and PL
4. And after the high/ low data add another calculation as follows: 'T1' (Current High + ATR MO (true ATR + 6) + 3 pip spread) and -T1 (Currnet low - ATR MO (true ATR +6) - 3 pip spread) and the same calculation for the previous bar.
Attached File(s)
File Type: mq4 ATROnChartMod4.mq4   5 KB | 652 downloads
  • #13
  • Last Post: Nov 3, 2009 7:03am Nov 3, 2009 7:03am
Great Work! Thank you Codemeister.
Best,
J
0 traders viewing now