Setting closing price for pending orders | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA orders pending orders 8 replies

Request EA for setting S/L, T/P, and closing trade 4 replies

Close all pending orders and open orders once they reach profit target 3 replies

EA for closing all pending orders 4 replies

Orders & Pending Orders Script 0 replies

Setting closing price for pending orders

  • #1
  • First Post: Oct 13, 2009 5:21am Oct 13, 2009 5:21am
I am trying to find a way to set a closing price (haven't reach yet) for opened orders (previously pending orders) in my ea. Problem is the OrderClose and OrderCloseBy functions only works for market orders. Even when I am using market orders I always get the requote problem. Plus I can only use bid/ask in the price parameter? Anyway, whenever I try to use the OrderModify, I always get an invalid ticket error. Anyone has a solution?

PS. I find that MQL is quite primitive in this regard. Is the C# language used by ninjatrader better in the area of trading functions?
I also find that a position (buy) which doesn't offset its opposite position (sell) is rather bizarre in MT4.
  • #2
  • Oct 13, 2009 7:04am Oct 13, 2009 7:04am
hey jl..... Anyone has a solution?

it's difficult to invison why ordermodfy will not do the task..... unless you are selecting the orders incorrectly, it should work..... or at least it always does for me....

Plus I can only use bid/ask in the price parameter?

you should be able to use any valid price..... might be best to verify the ordersend line.... likely the problem is there.....

always get the requote problem.....

always?...... would need more info here......h
to trade and code, keep both simple... no call to impress....h
  • #3
  • Oct 13, 2009 7:25am Oct 13, 2009 7:25am
Below is what I got:

ticket = OrderSend(...); --> This is executed successfully

OrderModify(ticket,price,0,0,0,Blue); --> Error 4108 (invalid ticket)

I don't see anything wrong here. Perhaps you can enlighten me?
  • #4
  • Oct 13, 2009 8:36am Oct 13, 2009 8:36am
I think something is happening to ticket between OrderSend and OrderModify

Another possibility is:

OrderModify(OrderSend(),0,0,Blue);
  • #5
  • Edited 9:02am Oct 13, 2009 8:46am | Edited 9:02am
This is what I actually got:

Inserted Code
        if (BuyTicket!=0){
          OrderSelect(BuyTicket,SELECT_BY_TICKET);
          if (OrderOpenTime()!=0){  //if buy pending order became open order
               OrderModify(BuyTicket,OrderOpenPrice(),NewPrice,0,0,Red);
          }else{
               OrderDelete(BuyTicket);
               BuyTicket=0;
          }
        }else if (SellTicket == 0 && Ask-Bid <= SpreadPoints){
            SellTicket = OrderSend(SymbolName,OP_SELLSTOP,Price,50,0,0,"Sell limit",0,0,Red);
        }else if (SellTicket!=0){ //if there is already a sell pending order
            OrderModify(SellTicket,NewPrice2,0,0,0,Red);
        }
  • #6
  • Oct 13, 2009 8:47am Oct 13, 2009 8:47am
One thing I notice is the OrderModify part never got called, and the ea keeps making new stop orders.
  • #7
  • Oct 13, 2009 9:02am Oct 13, 2009 9:02am
OrderSelect(BuyTicket, SELECT_BY_TICKET, MODE_TRADES);

Also, a suggestion to detect order type...

if(OrderType() == OP_BUY)
{
do whatever it is you do when the pending order converts to a market order
}

if(OrderType() == OP_SELL)
{
do whatever it is you do when the pending order converts to a market order
}
  • #8
  • Last Post: Oct 13, 2009 9:24am Oct 13, 2009 9:24am
Thanks Ron, but MT4 is still not doing what it should be doing. I have changed the part as follow:

Inserted Code
...
      }else if (OrderSelect(BuyTicket,SELECT_BY_TICKET,MODE_TRADES) == FALSE && Ask-Bid <= SpreadPoints){
            BuyTicket = OrderSend(SymbolName,OP_BUYSTOP,LotSize,Price,50,0,0,"Buy limit",0,0,Blue);
            Print(BuyTicket);
        }else if (OrderSelect(BuyTicket,SELECT_BY_TICKET,MODE_TRADES) && OrderType() == OP_BUYSTOP){
            OrderModify(BuyTicket,NewPrice2,0,0,0,Blue);
        }

The ea still churns out buystops in a row, instead of modifying the first buystop when a new price target is reached.
0 traders viewing now