Close all Orders Modification script..kindly | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

EA/Script to close all orders when profit hit? 11 replies

Script Modification Request - Set SL and TP on all orders 0 replies

Need help to mod "Close All Pending Orders" script 12 replies

script to "close open orders" and "open opposite orders" 3 replies

script for EA to close all orders by spec. time 3 replies

Attachments: Close all Orders Modification script..kindly
Exit Attachments

Close all Orders Modification script..kindly

  • #1
  • First Post: Edited Sep 18, 2009 5:39pm Sep 17, 2009 11:40pm | Edited Sep 18, 2009 5:39pm
Hello ..
Attached is an EA which
Closes all orders when Set profit target(as in settings) is Achieved in all open orders collectively !

While working/testing with a scalper(and hedging) ea,
i saw, the profit target never gets achieved as many orders are always open and drawdown is always there as negative P/L value, though account balance and equity keeps on increasing !
SO this script never comes into action.

Can somebody modify this EA to act on relative profit calculated from Initial equity and present equity
Say when it is dropped onto charts, it records the balance/equity...
as soon as Set Amountprofit target is realised , it closes all trades and
resets itself again to new account balance for next cycle!

(thinking about this i think it has to be in ea form rather than script, which has to be attached to a chart till the original trading ea is trading)

or IF there is any such ea already available..kindly do let me know
Would highly appreciate it

Regards
Attached File(s)
File Type: mq4 CloseTrades_After_Account_Profit_Reached.mq4   3 KB | 1,315 downloads
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #2
  • Edited 5:39pm Sep 18, 2009 8:53am | Edited 5:39pm
phew...confusin !
In fact looking at what exactly i require i found... i think it will be like below

That ea just has to monitor account equity and things should be like this imo
1) Dropped onto Chart
2) Records Current Account Equity (will be same as Account balance that time, as no trades open)
3) Original trading ea starts making trades
4) As soon as New Equity - Original Starting Equity = set ProfitAmountTarget in its settings, Closes all positions/trades.
5)Resets itself to New Equity (will be same as Account balance that time, as no trades open) for next cycle!

Simple i think?
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #3
  • Sep 18, 2009 2:23pm Sep 18, 2009 2:23pm
wrather than do it for you, since u seem to wanna learn, il show you how to do it in all your ea's

heres a line of code to find the %
insert this after start()

Inserted Code
if (( (AccountEquity()-AccountBalance()) / AccountBalance())*100>=target){close=true;}

target is a double, double target=2; means 2%
insert that at the top, put extern before it so that it shows up in the ea properties

youl notice im using a true/false switch to close the trades
that way your sure to get all trades closed
youl need this line now, place it right after the other line, after start()

Inserted Code
if (close)close_all_trades();

now you need to set it back false after all trades are closed
put this after the previouse line
Inserted Code
if (OrdersTotal()==0&&close)close=false;

close_all_trades(); is a function, this function is out side the start() so put this at the very bottom outside the start()
Inserted Code
void close_all_trades()
{
  int totalorders = OrdersTotal();
  for(int i=totalorders-1;i>=0;i--)
 {
    OrderSelect(i, SELECT_BY_POS);
      if (OrderType() == OP_SELL) OrderClose( OrderTicket(), OrderLots(),MarketInfo(NULL,MODE_ASK), 0, CLR_NONE );
      if (OrderType() == OP_BUY) OrderClose( OrderTicket(), OrderLots(), MarketInfo(NULL,MODE_BID), 0, CLR_NONE );
  }
  return;
}


heres a recap

put at top
Inserted Code
extern double target=2;

put after start()
Inserted Code
if (( (AccountEquity()-AccountBalance()) / AccountBalance())*100>=target){close=true;}
if (close)close_all_trades();
if (OrdersTotal()==0&&close)close=false;

put below everything at the bottom
Inserted Code
void close_all_trades()
{
  int totalorders = OrdersTotal();
  for(int i=totalorders-1;i>=0;i--)
 {
    OrderSelect(i, SELECT_BY_POS);
      if (OrderType() == OP_SELL) OrderClose( OrderTicket(), OrderLots(),MarketInfo(NULL,MODE_ASK), 0, CLR_NONE );
      if (OrderType() == OP_BUY) OrderClose( OrderTicket(), OrderLots(), MarketInfo(NULL,MODE_BID), 0, CLR_NONE );
  }
  return;
}

now, this can be added to your ea, or a new ea
if you ad this to your ea, your not done yet

find the entry rule in the ea, and ad this !close
so if your rule looks like if (iny1>indy)
make it look like this if (!close&&iny1>indy)

do it for buys and sells, this prevents the ea from opening new trades while there being closed

good luck
  • #4
  • Sep 18, 2009 2:26pm Sep 18, 2009 2:26pm
also, to let you know, this cannot be done in a script, a script runs 1 time then its finished, a ea loops

you cannot drag a script to the chart, and it wait for the profit, it will only read the profit once, it is what it is
  • #5
  • Sep 18, 2009 4:03pm Sep 18, 2009 4:03pm
Thanks a lot Trendchaser !
Highly appreciate the detailed reply!

Though half od d stuff went above head (Uber programmin-Kid this side)
For the time being...i feel its lot better making a standalone EA..and not editing the original one!
Will try... and let you know

Thanks once again !
Regards
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #6
  • Sep 18, 2009 5:15pm Sep 18, 2009 5:15pm
what you posted is an ea , not a script.... and should go in the experts folder....... it should do what your after....

if for some reason the trades are not being closed it might be due to the profit target is 300 bucks......

lower the target to 3 and give it a whirl..... all should close when profit target is hit....

if your trying to close 3 or 4 hundred trades across multiple pairs in a real life account, expect a couple to hang up for various reasons.....

a good rule of thumb is 1 per hundred.... you need to code to catch those....h
to trade and code, keep both simple... no call to impress....h
  • #7
  • Sep 18, 2009 5:37pm Sep 18, 2009 5:37pm
Quoting hayseed
what you posted is an ea , not a script.... and should go in the experts folder....... it should do what your after....

if for some reason the trades are not being closed it might be due to the profit target is 300 bucks......

lower the target to 3 and give it a whirl..... all should close when profit target is hit....

if your trying to close 3 or 4 hundred trades across multiple pairs in a real life account, expect a couple to hang up for various reasons.....

a good rule of thumb is 1 per hundred.... you need to code to catch...
Thanks Hayseed for replying..but i think u missed the requirement!
yes.. i wrote wrongly.. thats not a script.. but an ea!

Actually, Why that will not work in this case is..bcoz it takes into care floating P/L... whereas the trading Ea i am testing... never usually has Floating P/L as positive...it just scalps and keeps opening orders!.. Account balance keeps on rising and Floating P/L keeps fluctuating with equity.
So, aim is to lock in profits by closing all trades when Some appropriate $$ have been booked and drawdown is not big!

So use of this script in my case is like a Ubuntu free cd lying with bill gates
Regards
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #8
  • Sep 18, 2009 10:45pm Sep 18, 2009 10:45pm
the code i posted is in the most simplest form possible

if you read through my tutorial, probably take 15 minutes, youl suddenly understand a lot more than u thought possible

just read it, you don't have to do it

just spend 15 minutes reading, i bet you can create this ea ur self

it wouldn't hurt to take a few notes of things you think you cannot remember

heres my tutorial, only 7 pages
http://trendchaser.org/forum/phpBB3/...php?f=64&t=350



Quoting forexsaint
Thanks Hayseed for replying..but i think u missed the requirement!
yes.. i wrote wrongly.. thats not a...
  • #9
  • Sep 18, 2009 11:11pm Sep 18, 2009 11:11pm
hey saint..... not clear on the relationship between a Ubuntu free cd and bill gates .....

but perfectly clear on your request now..... in this case rather than use accountbalance(), you'll want to use accountequity()....

this will enable you to bunny hop the account equity by some preset amount....

wrote a quick trade placing ea and included your code to illustrate below.....

the first picture shows the starting values..... used 20$ for the equity target.... 10000 + 20 = 10020.....

the second and third picture shows trades opening and closing.... account balance and account equity rising and falling..... starting equity waits....

and shortly , fourth picture, our 20 bucks is made and the ea closes everything.... the amount will never be 20, due to obvious reasons.... in this case and extra 2.12 was made before the dust settled....

now with all trades closed the starting equity instantly resets to the current account balance, 10022.12.... and the cycle restarts.... this time we need 10042.12.....

and the last 2 pictures are just more showing the account equity target closing more each time 20 bucks is made....

like you mentioned, the account balance will rise and fall as will account profit..... trades will open and close , some winners some loosers..... once the equity hits your preset amount, all open trades close..... cycle restarts......h
Attached Image(s) (click to enlarge)
Click to Enlarge Name: saint1.gif Size: 12 KB
Click to Enlarge Name: saint2.gif Size: 13 KB
Click to Enlarge Name: saint3.gif Size: 15 KB
Click to Enlarge Name: saint4.gif Size: 20 KB
Click to Enlarge Name: saint5.gif Size: 27 KB
Click to Enlarge Name: saint6.gif Size: 27 KB
to trade and code, keep both simple... no call to impress....h
  • #10
  • Edited 1:33pm Sep 19, 2009 2:57am | Edited 1:33pm
@Trendchaser
I highly appreciate your help
I will read that soon and get this done...myself ! (bit busy with sm problem at my end). Have to do before next aussie session!
lets c what i make in d end....A Solid ICE ea or a Saucy one

@hayseed
Sorry..You are just 1 pico-mm away from d aim ! hehe
EXACTLY ! thats what!
So nice of you ..that you recorded all the pics and stuff !
Ubuntu is something which Bill Gates has/will never liked/like !


Best regards
ForexSaint
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #11
  • Edited Sep 20, 2009 1:49am Sep 19, 2009 3:13pm | Edited Sep 20, 2009 1:49am
Alright! Trenchaser ,,really ...that tutorial is so nicely explained...i still reached 2nd page though (was enough to absorb for me for the time being) thanks again for that.

Here is the code attached.. kindly proof read it.. and point the mistakes and advise the proper way.

i have done following extra changes as per requirement
1) Since i wanted a amount based target, i changed the %age code
2) I tried adding close based trade closure, but it said variable close not defined..so i initiated close at top
3) Renamed the Target variable to more suit better and added a explanation string as extern
4) Initiated extern magic number & added explanation String as extern for Statement
if (OrderMagicNumber()==magicnumber)
for closing trades of that ea only! Can be helpful if multi ea's with different magic numbers are on work
5) Added Extern and Initiated Slippage value on top to be used in order closure statement
6) Modified CLR_NONE to Colours for both buy and sell close .
7) Added Comments to print on chart- ProfitTargetPerCycle, Account balance, Account Equity

( An error on compilation still remains- 'close' - comparison expression expected)

Though i am still not sure...this thing is what i want actually..!
Bcoz No where in this, we have discussed/recorded Starting equity/Account balance and then reset it after close of trades and again recorded it
Infact, its almost identical to basic script i posted in function. Account Equity will never be more than account balance in the case of ea for which i am writing this(bcoz as explained before, Ea keeps opening orders and keeps scalping some pips in winners and accumlating losers)
So Floating P/L will always be Negative and Account Equity will always be < Account balance !


The Actual IDEA is exactly as hayseed has provided screenshots..! and not this one !
Attached File(s)
File Type: mq4 Close All Equity based MOD.mq4   2 KB | 925 downloads
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #12
  • Sep 19, 2009 7:04pm Sep 19, 2009 7:04pm
there ya go, good job
i only see 1 mistake
change close to a bool at the top
you have it as a integer

where u have this line
if ((AccountEquity()-AccountBalance())>=ProfitTargetPerCycle){close=true;}

that will result in trades closing when whole account is up 20 dollars instead of %

you can test different tricks, try adding the orders counting code, you can close groups in profit instead of all trades?

you can count how many trade are in profit, how many losing

you could count the biggest losing trade, with all trades in profit, if the grand total is in profit
close that group

so many possibilities
by the way, the closing logic is the account globally, no symbol is used

Quoting forexsaint
Alright! Trenchaser ,,really ...that tutorial is so nicely explained...i still reached 2nd page though (was enough to absorb for me for the time being) thanks again for that.

Here is the code attached.. kindly proof read it.. and point the mistakes and advise the proper way.

i have done following extra changes as per requirement
1) Since i wanted a amount based target, i...
  • #13
  • Sep 19, 2009 9:05pm Sep 19, 2009 9:05pm
hey saint..... no, that's not going to work.....

the math is incorrect, your not recording the starting equity and have no provision to reset the starting equity.....

the close_all_trades() function will never be called as it's coded......

but your getting close.... holler if ya need help...... otherwise your doing a good job......h
to trade and code, keep both simple... no call to impress....h
  • #14
  • Sep 19, 2009 11:26pm Sep 19, 2009 11:26pm
I've done something similar with this here, except it's set up to close all trades of a specific symbol. If you delete the reference to the symbol, then it should close all trades. Also, if you open any orders under a different symbol, then you are looking at more than the profit for the symbol you are trying to close, so it won't work that way. I have to find a way to determine the profit for that specific symbol only. Am still working on that.

And here, you have the option to set the Closing_Price or Set_Profit value (or both), both of which are external variables. If neither is set, it ignores this function altogether. The Equity_1 value is the initial AccountEquity() and is determined prior to "Start."

PHP Code
if(Closing_Price>0&&AccountEquity()>=Closing_Price){ Close_All="y"; } 
if(Set_Profit>0&&AccountEquity()>=Equity_1+Set_Profit){ Close_All="y"; }
if(Close_All=="y")
  {
   int total=OrdersTotal();
   for(int i=total-1; i>=0; i--)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
        {
         if(OrderSymbol()==Symbol1)
           {
            if(OrderType()==OP_BUY||OrderType()==OP_SELL)
              {
               OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,Red);
              }
            if(OrderType()==OP_BUYLIMIT||OrderType()==OP_SELLLIMIT)
              {
               OrderDelete(OrderTicket());
              }
            if(OrderType()==OP_BUYSTOP||OrderType()==OP_SELLSTOP)
              {
               OrderDelete(OrderTicket());
              }
           }
        }
     }
  }
Currently I have it set up so it's a one shot deal, and won't reset after the orders have closed. But, that's easy enough to change if you want to.
  • #15
  • Edited 7:09am Sep 20, 2009 1:30am | Edited 7:09am
@ Trendchaser
Are you still missing to understand my requirement idea? This is not what actually what i need!

- ok, i changed the Close to boolean now no compilation error!
- Yes i want it to be Straight in $ and not in %age, thats why did that, as explained before.
-Yes, i want to close all trades and not just loosing or winning ones
- Yes, that was done to close all trades globally and without any symbol.
But imo it will eventually only close that symbol only as MAGIC NUMBER filter is there. As long as, on whatever symbol, trading Ea will act, this will act! aint it?
So dont think we require symbol based filter here!

@haysaad
yes i would like you to kindly explain me the process of Recording Initial Equity and then comparing it with Current equity and then Closing all trades and resetting it!
IF you can post just like trendchaser, explaining the codes..it will be gr8..
Else directly the code would be a quick relief! iwill try to understand it.

@Ectrade
thanks for more insights, i will try doing something with it.
Yes, i need to reset it too , else it will only work once...its not a real automated ea then.

Regards All
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #16
  • Edited 6:25am Sep 20, 2009 1:38am | Edited 6:25am
Ok guys,,here is the new code.
Will it work as required?
Corrections and advise needed!

i have done following changes
1) Added int initialEquity at top & put initialequity= AccountEquity(); in experrt initialistion function before start ??(no idea what is exp int function area for...just put it before start as ectrade said)
2) Added
Inserted Code
if (OrdersTotal()==0&&close)initialequity= AccountEquity();
before return in the exp start function area
3) Added comment to print Initial Account Equity too.

EDIT : i just found in the code i had placed
Inserted Code
if (OrdersTotal()==0&&close)close=false;
before
Inserted Code
if (OrdersTotal()==0&&close)initialequity= AccountEquity();
So its not right as for 2nd statement Close will not be true.
So now I have placed
Inserted Code
if (OrdersTotal()==0&&close)initialequity= AccountEquity();
before
Inserted Code
if (OrdersTotal()==0&&close)close=false;
EA attached again
Attached File(s)
File Type: mq4 Close All Equity based MOD1.mq4   3 KB | 717 downloads
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #17
  • Sep 20, 2009 8:22am Sep 20, 2009 8:22am
Quoting forexsaint
@Ectrade
thanks for more insights, i will try doing something with it.
Yes, i need to reset it too , else it will only work once...its not a real automated ea then.

Regards All
Here, this should work:

PHP Code
if(Equity_New==0){ Equity_New=AccountEquity(); } Equity_Base=AccountEquity();
if(Equity_Base>=Equity_New+Set_Profit){ Equity_New=Equity_Base; Close_All="y"; }
if(Close_All=="y")
  {
   int total=OrdersTotal();
   for(int i=total-1; i>=0; i--)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
        {
         if(OrderSymbol()==Symbol1)
           {
            if(OrderType()==OP_BUY||OrderType()==OP_SELL)
              {
               OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,Red);
              }
            if(OrderType()==OP_BUYLIMIT||OrderType()==OP_SELLLIMIT)
              {
               OrderDelete(OrderTicket());
              }
            if(OrderType()==OP_BUYSTOP||OrderType()==OP_SELLSTOP)
              {
               OrderDelete(OrderTicket());
              }
           }
        }
     }
   Close_All="n";
  }
And here, the Equity_New variable grabs the initial AccountEquity(), the Equity_Base variable is the current AccountEquity() which, once it reaches the target, "Equity_New+Set_Profit," it sets the Equity_New variable to the current AccountEquity() and prepares to close all orders by setting Close_All variable to "y." Once the orders are closed, it resets by setting the Close_All variable to "n" (i.e., set to "n" or anything other than "y" by default), and waits until the new target (Equity_New+Set_Profit) is reached.

Also, if you don't want it to be "symbol specific," you should delete reference to that too:

PHP Code
if(Equity_New==0){ Equity_New=AccountEquity(); } Equity_Base=AccountEquity();
if(Equity_Base>=Equity_New+Set_Profit){ Equity_New=Equity_Base; Close_All="y"; }
if(Close_All=="y")
  {
   int total=OrdersTotal();
   for(int i=total-1; i>=0; i--)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
        {
         if(OrderType()==OP_BUY||OrderType()==OP_SELL)
           {
            OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,Red);
           }
         if(OrderType()==OP_BUYLIMIT||OrderType()==OP_SELLLIMIT)
           {
            OrderDelete(OrderTicket());
           }
         if(OrderType()==OP_BUYSTOP||OrderType()==OP_SELLSTOP)
           {
            OrderDelete(OrderTicket());
           }
        }
     }
   Close_All="n";
  }
  • #18
  • Sep 20, 2009 9:12am Sep 20, 2009 9:12am
hey saint..... no, that won't quite work but your dang close.....

here are the needed additions to the first ea you posted.... search the code for the word "saint" and note the code to the left......

included some buy/sell rules so you can visually backtest......

and btw, you did an excellent job in your attempt......h
Attached Image(s) (click to enlarge)
Click to Enlarge Name: saint.jpg Size: 188 KB
Click to Enlarge Name: saint2.jpg Size: 199 KB
Click to Enlarge Name: saint3.jpg Size: 217 KB
Click to Enlarge Name: saint4.jpg Size: 170 KB
Attached File(s)
File Type: mq4 saint.mq4   3 KB | 771 downloads
to trade and code, keep both simple... no call to impress....h
  • #19
  • Sep 20, 2009 11:37am Sep 20, 2009 11:37am
@ectrade
Thanks for your reply . but to be frank , due to no prog. background..i m not able to understand the code you posted! esp in absence of explanation

@hayseed
Thanks for the code bro. I read all the code and esp you marked for me.
But i have some questions as regarding why the code in Post 16 will not work? For learning purpose of course (if saint.mq4 can do what i want)
I tried matching your code and thats what i found , comparing both:

1) Your code has double StartingEquity;
mine has int initialequity ;
ok so lets change this to double initialequity ;

2)Your code has this in initialization function
StartingEquity = AccountBalance();
mine has
initialequity= AccountEquity();
Now From what i understand is, Both Account balance and Account Equity will be same when all trades are closed (starting of ea and After every "close all order" function execution)
So does it matter?

3)Your code says , close all trades if
Inserted Code
if ((AccountBalance() + AccountProfit() >= StartingEquity + EquityTarget))
Which means to close all trades,if
Account Balance + (Floating P/L) >= Starting Equity + Profit Target

Mine says, close all trades if
Inserted Code
if (ProfitTargetPerCycle>0&&AccountEquity()>=initialequity+ProfitTargetPerCycle)
Which means to close all trades, if
Profit Target Should be >0 (just in case by error we enter -ve profit target so it will not cause problems in math)
AND
Account Equity(Current Equity) >= Starting Equity + Profit Target

So in essence, i see
AccountBalance() + AccountProfit() code of yours is equal to AccountEquity() at any given point of time !
So this edit also seems to be same ! aint it?


4) Now Inside the IF statement, after all orders have been closed, before Return, you have following code to reset the Starting equity variable to new account balance for next cycle
StartingEquity = AccountBalance();

Mine code had this
if (OrdersTotal()==0&&close)initialequity= AccountEquity();
First check no order is still open & Close =true (which is equivalent to being inside If statement) and then Reset the InitialEquity variable to new Equity

Now here everything appaers to be same, Account balance will be equal to Account equity at that time, so any function can be used, isnt it?

5) Some more edits are there in you code like Trade rules and closing pending orders also. Thats fine!


Looking forward to the explanation about the differences for better grasp abt the issue!
And yes ...feeling nice doing this myself... takes time understanding the flow of stuff though!

Regards All
ForexSaint
100 Fold Challenge->Interested? ->https://www.forexfactory.com/thread/32152
  • #20
  • Sep 20, 2009 11:39am Sep 20, 2009 11:39am
i think what you want is a goal
heres what i use

you must use global variables, this is because the ea will get reset, this enables you to also close a trade without it messing up the score

create a custom balance

at the top
double balance;

after start()
if (!GlobalVariableCheck("balance"+Symbol()+""+IsTesting()+""))GlobalVariableSet("balance"+Symbol()+""+IsTesting()+"",AccountBalance());


what that line does, is check to see if the variable exists
if it doesnt, we create it

now to check if the variable needs reset
if (AccountBalance()>balance)GlobalVariableSet("balance"+Symbol()+""+IsTesting()+"",AccountBalance());

now to set our balance
balance=GlobalVariableGet("balance"+Symbol()+""+IsTesting()+"");

now to edit the exit code
this is %, you can use dollars, just use the custom balance in the place of Accountbalance()

if (( (AccountEquity()-balance) / balance)*100>=goal)

now put this in the deinit()
GlobalVariableDel("balance"+Symbol()+""+1+"");

that way itl reset for us after testing, you have 2 variables, 1 for testing, 1 for live

at anytime, deleting the variable resets the goal, you may manually edit the goal also

heres a recap of the codes

Inserted Code
double balance;


GlobalVariableDel("balance"+Symbol()+""+1+"");


if (!GlobalVariableCheck("balance"+Symbol()+""+IsTesting()+""))GlobalVariableSet("balance"+Symbol()+""+IsTesting()+"",AccountBalance());
if (AccountBalance()>balance)GlobalVariableSet("balance"+Symbol()+""+IsTesting()+"",AccountBalance());
balance=GlobalVariableGet("balance"+Symbol()+""+IsTesting()+"");

if (( (AccountEquity()-balance3) / balance3)*100>=goal)
0 traders viewing now