Problem with closing positions | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Closing multiple positions with just 1 click? 5 replies

Script for closing all the active positions 8 replies

how to install MT4 and instant closing of all positions 7 replies

Christmas and Closing Positions 3 replies

Closing multiple positions at the same time 5 replies

Problem with closing positions

  • #1
  • First Post: Sep 15, 2009 10:31pm Sep 15, 2009 10:31pm
a need to close the position when the lines are crossing, they are opennig at the first crossing and must close(with profit or lose) at the next crossing.


my positions are opening but they don't whant close;/


Inserted Code
  
    total  = OrdersTotal(); 
 

    if(total < 1) 
      {
               if(isCrossed ==1 || m1==1)                 
   {
                        ticket = OrderSend(Symbol(),0, Lots,Ask,3,Ask-100*Point,Ask+100*Point,
                                                          "", 12345, 0, Green);
                                                          
                                                          
          }
             if(isCrossed == 2 || s2==2)//                   
{
                       ticket = OrderSend(Symbol(),1, Lots, Bid,3,Bid+100*Point,Ask-100*Point, 
                                                          "", 12345, 0, Red);
                   }
      }   
      //--------------------------------------------------------------

          
 return(0);
 
 
 
 
 if(total>1)
  {
  if(OrderSelect(0,SELECT_BY_POS))
      {
      if(isCrossed == 1 &&  isCrossed == 2 )           
{
             OrderClose(OrderTicket(),Lots,Ask,Ask,Red); 
           }
    
     }
}
  • #2
  • Sep 15, 2009 11:48pm Sep 15, 2009 11:48pm
Quoting pietra
my positions are opening but they don't whant close
It looks like position exit code is never reached as it's located after return(0) statement.
Besides
Inserted Code
  
             OrderClose(OrderTicket(),Lots,Ask,Ask,Red);
doesn't make much sense. Position close price depends on the position type: Bid for long, Ask for short. And why slippage is set to Ask?

Learning basics before encountering "but they don't" problem might be a good idea.
  • #3
  • Edited 11:22am Sep 20, 2009 9:54am | Edited 11:22am
Inserted Code
    total  = OrdersTotal(); 
    if(total < 1) 
      {
               if(isCrossed ==1 || m1==1)//jezeli jeden to daje sygnal buy i zajmuje dluga pozycje
                    {
                        ticket = OrderSend(Symbol(),0, Lots,NormalizeDouble(Ask,Digits),3,Ask-500*Point,Ask+500*Point,
                                                          "", 12345, 0, Green);
                  }
             if(isCrossed == 2 || s2==2)//jezeli dwa to daje sygnal sell i zajmuje krotka  pozycje
                   {
                       ticket = OrderSend(Symbol(),1, Lots, NormalizeDouble(Bid,Digits),3,Bid+500*Point,Ask-500*Point, 
                                                          "", 12345, 0, Red);
                   }
 
return(0);
      } 
 
 
  if(OrderSelect(0,SELECT_BY_POS,MODE_TRADES))
      {//1
      if(isCrossed == 1 &&  isCrossed == 2 )//zamykanie pozycji
              {//2
                  if(OrderType() == OP_BUY) 
                   { //3 zamkniej BUY 
                      OrderClose(OrderTicket(),Lots,Bid,3,Blue); 
                   } //3
                  if (OrderType()==OP_SELL) 
                   { //4 zamkniej BUY 
                       OrderClose(OrderTicket(),Lots,Ask,3,Red); 
                   } //4
              }//2
              return(0);
      }//1


I have something like that and problem is the same;/
I don't know that to do
  • #4
  • Sep 20, 2009 1:50pm Sep 20, 2009 1:50pm
you do not have any orders selected
this should help

int totalorders = OrdersTotal();
for(int i=totalorders-1;i>=0;i--)
{
OrderSelect(i, SELECT_BY_POS);

//place code here, orders are selected
}


heres my tutorial for newb's
http://trendchaser.org/forum/phpBB3/...php?f=64&t=350
Quoting pietra
[code]...
  • #5
  • Sep 25, 2009 8:38pm Sep 25, 2009 8:38pm
Inserted Code
.
.
.
.
int isCrossed  = 0;
    isCrossed = Crossed (k,d);  //przeciecie sie dwoch srednich stochastycznych
    
int isCrossed2  = 0;
    isCrossed2 = Crossed (SEma,LEma);      //przeciecie sie dwoch srednich kroczacych
 
if(SEma>LEma)
{
m1=1;
}
if(SEma<LEma)
{
m2=2;
}

if(k>d)
{
s1=1;
}
if(k<d)
{
s2=2;
}

Comment(s1,s2,m1,m2);
   //-----------------------------
   
   
   
   
   
   
   
   
 //------------------------zamykanie pozycji---------------------------------  
 
 //----------------------------------    
    total  = OrdersTotal(); 

    if(total < 1) 
      {
               if(isCrossed == 1 && m1==1)//jezeli jeden to daje sygnal buy i zajmuje dluga pozycje
                    {
                        ticket = OrderSend(Symbol(),0, Lots,NormalizeDouble(Ask,Digits),3,Ask-5000*Point,Ask+5000*Point,
                                                          "", 12345, 0, Green);
                  }
                  
               if(isCrossed == 2 && m2==2)//jezeli dwa to daje sygnal sell i zajmuje krotka  pozycje
                   {
                       ticket = OrderSend(Symbol(),1, Lots, NormalizeDouble(Bid,Digits),3,Bid+5000*Point,Ask-5000*Point, 
                                                          "", 12345, 0, Red);
                   }
                   
                   
               if(isCrossed2 == 1 && s1==1)//jezeli jeden to daje sygnal buy i zajmuje dluga pozycje
                    {
                        ticket = OrderSend(Symbol(),0, Lots,NormalizeDouble(Ask,Digits),3,Ask-5000*Point,Ask+5000*Point,
                                                          "", 12345, 0, Green);
                  }
                  
               if(isCrossed2 == 2 && s2==2)//jezeli dwa to daje sygnal sell i zajmuje krotka  pozycje
                   {
                       ticket = OrderSend(Symbol(),1, Lots, NormalizeDouble(Bid,Digits),3,Bid+5000*Point,Ask-5000*Point, 
                                                          "", 12345, 0, Red);
                   }  
                   
                   
                   
return(0);
      } 
int totalorders = OrdersTotal();
for(int i=totalorders-1;i>=0;i--)
{
OrderSelect(i, SELECT_BY_POS);      
     
            
                  if(OrderType() == OP_BUY) 
                   { //2 zamknij BUY 
                         if(isCrossed == 2 )//zamykanie pozycji
                      {//3
                      OrderClose(OrderTicket(),Lots,NormalizeDouble(Bid,Digits),3,Blue); 
                      } //3
                   
                   }//2
                  if (OrderType()==OP_SELL) 
                     {
                      if(isCrossed == 1 )//zamykanie pozycji
               
                   { //4 zamknij sell
                       OrderClose(OrderTicket(),Lots,NormalizeDouble(Ask,Digits),3,Red); 
                   } //4
             }
             
         return(0);
      }//1 
    
        
      //---------------------------------------------------------         
 return(0);
 
 
  }//calosc

mayby anybody see any mistake?because opening positions is fine but clossing is the real problem, not everytime positions are closing wthen they should....they loose some signals to close


please help
  • #6
  • Sep 26, 2009 8:53am Sep 26, 2009 8:53am
see this line

OrderClose(OrderTicket(),Lots,NormalizeDouble(Bid,Digits),3,Blue);

thats incorrect

just use OrderClose(OrderTicket(),Lots,Bid,3,Blue);

or you can use
marketinfo(ordersymbol(),mode_bid)

see digits is for lots, if its ibfx mini, it returns 2
imagine rounding off the bid on eur-usd

if price is say 1.1234

your trying to close at 1.12

on a pair like gbp jpy you wont have a problem, as its a 2 digit currency
  • #7
  • Last Post: Sep 26, 2009 9:25am Sep 26, 2009 9:25am
the normalizedouble part looks ok, but you might consider changing Lots to OrderLots().....h


Inserted Code
OrderClose(OrderTicket(),OrderLots(),NormalizeDouble(Bid,Digits),3,Blue);}}
to trade and code, keep both simple... no call to impress....h
0 traders viewing now