Need input on a piece of code..should be EZ for programmers | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need a programmers help 3 replies

Need help with a small piece of code 0 replies

How to change this piece of code? 12 replies

Need Expert Input...should be a quick question on my code 3 replies

whats wrong with this piece of code? 14 replies

Need input on a piece of code..should be EZ for programmers

  • #1
  • First Post: Sep 10, 2009 12:45pm Sep 10, 2009 12:45pm
This is closing partial lots BUT...not exactly doing what I expected. Maybe you can see the issue here.
should close 1 lot when there is a BUY and the price goes .00071(just a random number i'm testing on a 1 minute chart)
or close 1 lot when there is a SELL and price goes .00071 down
using a 5 digit broker by the way. There is only 1 trade ever open and only by this EA, so no scrolling through orders

THANKS for HELP!


if (IsConnected() && IsTradeAllowed()) while (IsTradeContextBusy()) Sleep(75);
if (OrdersTotal()>0) {OrderSelect(0, SELECT_BY_POS,MODE_TRADES);
RefreshRates();
if (Ask >= (OrderOpenPrice()+ (.00071)) && OrderLots() == 2 && (OrderType() == OP_BUY)) {
OrderClose(OrderTicket(),1,Ask,10,Red); }
if (Bid <= (OrderOpenPrice()- (.00071)) && OrderLots() == 2 && (OrderType() == OP_SELL)) {
OrderClose(OrderTicket(),1,Bid,10,Blue); }}
taking series 3 and 34
  • #2
  • Sep 10, 2009 12:58pm Sep 10, 2009 12:58pm
I'm not sure about this, but I would swap the Bid Ask. Close a Long with the Bid.
  • #3
  • Edited 10:51pm Sep 10, 2009 4:30pm | Edited 10:51pm
This achieves partial trade closure, or shows why if the attempt fails. Close_lots is the amount of the trade you want to close.

Inserted Code
double price;
if (OrderType()==OP_BUY) price = Bid;
if (OrderType()==OP_SELL) price = Ask;

if (condition or series of conditions)
{   
     bool result=OrderClose(OrderTicket(), Close_Lots, price, 5, CLR_NONE);
     if (!result)
     {
        err=GetLastError();
        Alert(Symbol(), " OrderModify failed with error(",err,"):    ",ErrorDescription(err), ": Ticket no ", OrderTicket());
        Print(Symbol(), " OrderModify failed with error(",err,"):   ",ErrorDescription(err), ": Ticket no ", OrderTicket());
     }//if (!result)
}//if (condition or series of conditions)
  • #4
  • Sep 10, 2009 5:13pm Sep 10, 2009 5:13pm
great info here..
going to test and see what i come up with
taking series 3 and 34
  • #5
  • Last Post: Sep 10, 2009 10:54pm Sep 10, 2009 10:54pm
Have fun. The error alert text was a bit nonsensical so I have edited that, but you probably already guessed.

I have no idea how far into mql4 coding you are. If you are fairly new to it, there is some brilliant stuff to be had at http://www.metatrader.info/node/34

0 traders viewing now