avoid multiple orders at the same time

bool DecideToOpenTrade(int TradeType)
{
   int total = OrdersTotal();
   if (total > 0)
   {
      for(int cnt=total-1;cnt>=0;cnt--)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            if(OrderSymbol()==Symbol() && OrderMagicNumber() == EA_MAGIC_NUM && OrderType() == TradeType)
            {
               return (false);
            }
         }
      }
   }
   // in case trades has already opened and closed within the candle
   int histotal = OrdersHistoryTotal();
   if (histotal > 0)
   {
      for(cnt=histotal-1;cnt>=0;cnt--)
      {
         if(OrderSelect(cnt,SELECT_BY_POS,MODE_HISTORY))
         {
            if(OrderSymbol()==Symbol() && OrderMagicNumber() == EA_MAGIC_NUM && OrderType() == TradeType)
            {
               if (Time[0] <= OrderOpenTime()) // don't open a new position if we're still on the same candle
               {
                  return (false);
               }
            }
         }
      }
   }
   return (true);
}

extern int EA_MAGIC_NUM = 937592
extern double Stoploss=0.01;
extern double Limit=0.03;

int init(){return(0);}
int deinit(){return(0);}

int start()
{
   if(Hour() == 4 && Minute() == 0 && DecideToOpenTrade(OP_BUY))
   {
      OrderSend(Symbol(), OP_BUY, 0.01, Ask, 3, Ask - Stoploss, Ask + Limit, "", EA_MAGIC_NUM);
   }
   if(Hour() == 4 && Minute() == 0 && DecideToOpenTrade(OP_SELL))
   {
      OrderSend(Symbol(), OP_SELL, 0.01, Bid, 3, Bid + Stoploss, Bid - Limit, "", EA_MAGIC_NUM); 
   }
   return(0);
}

Quoting dogberry

Disliked

Using the following code to backtest a system, it produces multiple orders sometimes. Could anybody tell me how to avoid this problem. Many thanks!

extern double Stoploss=0.01;
extern double Limit=0.03;

int init(){return(0);}
int deinit(){return(0);}

int start()
{
if(Hour() == 4 && Minute() == 0)
OrderSend(Symbol(), OP_BUY, 0.01, Ask, 3, Ask - Stoploss, Ask + Limit);
if(Hour() == 4 && Minute() == 0)
OrderSend(Symbol(), OP_SELL, 0.01, Bid, 3, Bid + Stoploss, Bid - Limit);
return(0);
}

Ignored

Quoting NowAndLater

Disliked

If you only want it to open one sell and one buy order each day at 04.00 then this is an easier way:

extern double Stoploss=0.01;
extern double Limit=0.03;
int dayOfTrade = -1;

int init(){return(0);}
int deinit(){return(0);}

int start()
{
if(Hour() == 4 && Minute() == 0 && Day() |= dayOfTrade){
OrderSend(Symbol(), OP_BUY, 0.01, Ask, 3, Ask - Stoploss, Ask + Limit);
OrderSend(Symbol(), OP_SELL, 0.01, Bid, 3, Bid + Stoploss, Bid - Limit);
dayOfTrade = Day();
}
return(0);
}

Ignored

Quoting Zen_Leow

Disliked

you are assuming the OrderSend command will always be successful. if you want it to be done your way, you should encapsulate the OrderSend function as a IF condition and only set dayOfTrade=Day() if the OrderSend returns a "true".

btw, you have a typo. "|=" should be "!="

Ignored