Learning out of desperation----a bit of a blog

   if (myOrderType==3)
   
   {TotalOrders = OrdersTotal();
      for (i=0; i<TotalOrders; i++)
        {

    if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
        {
         if ((OrderSymbol() == Symbol()) && (OrderType() == OP_BUY))
            {
            if ((Bid-OrderOpenPrice()) >= Pips)
               {
                OrderSend(Symbol(),OP_BUY,(LotSize * Multiplier) ,Ask,slippage,Ask-StopLoss,Ask+TakeProfit-Pips,"Stacker Buy",MagicNumber,0,Blue);
               }
            }
        }
   }
   
   
        }
   }

extern double    Pips               = 0.02000;

Quoting BenScoobert

Disliked

correct, maybe u should reduce it for testing purposes

Ignored

//+------------------------------------------------------------------+
//|                                                      Stacker.mq4 |
//|                                                    Ben Coulthard |
//|                            bencoulthard at hotmail dot co dot uk |
//+------------------------------------------------------------------+
#property copyright "Ben Coulthard"
#property link      "bencoulthard at hotmail dot co dot uk"

//---- input parameters
int              myOrderType        = 0;
extern double    TakeProfit         = 0.10000;
extern double    StopLoss           = 0.01000;
extern double    Multiplier         = 2;
extern double    LotSize            = 0.01;
extern int       MagicNumber        = 801369;
extern double    Pips               = 0.00200;
extern int       Fast_EMA           = 12;
extern int       Slow_EMA           = 26;
extern int       Signal_SMA         = 9;
extern int       Shift              = 1;
extern int       TradingRange       = 0;
extern bool      ReverseSignal      = false;
extern double    slippage           = 0;
int              TotalOrders;
int              i;
datetime         TimeStamp          = 0;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
{
//------------------------------------------------------------------------------------------------------------
//--if there are no open trades, check for entry signal and return 1 for buy 2 for sell
if (OrdersTotal()==0) {myOrderType=0;}

if (myOrderType==0)
  {
   double MACDMainCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift);
   double MACDSigCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift);
   double MACDMainPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift+1);
   double MACDSigPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift+1);

   double SellRange=TradingRange*Point;
   double BuyRange=(TradingRange-(TradingRange*2))*Point;

   if(MACDMainCurr>MACDSigCurr && MACDMainPre<MACDSigPre && MACDSigPre<BuyRange && MACDMainCurr<0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=2; TimeStamp=iTime(NULL,0,0);}
   if(MACDMainCurr<MACDSigCurr && MACDMainPre>MACDSigPre && MACDSigPre>SellRange && MACDMainCurr>0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=1; TimeStamp=iTime(NULL,0,0);}

   if (myOrderType == 1) Print("type 1");
   if (myOrderType == 2) Print("type 2");
   if (ReverseSignal) {
                       if (myOrderType==1) { myOrderType=2; }
                         else { if (myOrderType==2) { myOrderType=1; } }
                       }
//------------------------------------------------------------------------------------------------------------

//--if order type is 1 then open a trade


   if (myOrderType==1)
   {
    OrderSend(Symbol(),OP_BUY,LotSize,Ask,slippage,Ask-StopLoss,Ask+TakeProfit,"Stacker Buy",MagicNumber,0,Blue);
    myOrderType=3;
   }

   if (myOrderType==2)
   {
    OrderSend(Symbol(),OP_SELL,LotSize,Bid,slippage,Bid+StopLoss,Bid-TakeProfit,"Stacker Sell",MagicNumber,0,Red);
    myOrderType=4;
   }

   if (myOrderType==3)
   
   {TotalOrders = OrdersTotal();
      for (i=0; i<TotalOrders; i++)
        {

    if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
        {
         if ((OrderSymbol() == Symbol()) && (OrderType() == OP_BUY))
            {
            if ((Bid-OrderOpenPrice()) >= Pips)
               {
                OrderSend(Symbol(),OP_BUY,(LotSize * Multiplier) ,Ask,slippage,Ask-StopLoss,Ask+TakeProfit-Pips,"Stacker Buy",MagicNumber,0,Blue);
               }
            }
        }
   }
   
   
        }
   }
                   
                   
                   
   if (myOrderType==4)
   {
   }

                   



return(myOrderType);

  }

//+------------------------------------------------------------------+

Quoting LittleLuca

Disliked

It will never re-enter the first if (myOrderType==0)

So it will check straight after the first order is openned but it will then start again at start() and will check if (myOrderType==0) which is false because now it = 3 thus never gets inside code!

You need to close it just before

}//put the close bracket here and take one from after the for loop
//--if order type is 1 then open a trade

hth

Ignored

Quoting LittleLuca

Disliked

Ben,

You need to use a flag to note that you have opened a second order...

Order do you want it to open a order every 200pips it is in the pos ?

if thats the case you just need to create a value which you increment by 200pips each time a order is taken

Ignored

   for(int i=1; i<=OrdersTotal(); i++)          // Cycle searching in orders
     {
      if (OrderSelect(i-1,SELECT_BY_POS)==true) // If the next is available
        {                                       // Analysis of orders:
         int Tip=OrderType();                   // Order type
         if(OrderSymbol()!=Symb||Tip>1)continue;// The order is not "ours"
         double SL=OrderStopLoss();             // SL of the selected order
OrderModify(Ticket,Price,SL,TP,0);