Learning out of desperation----a bit of a blog | Page 3 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Learning at the speed of snail [Newbie Learning Journal] 9 replies

Questions to Analyze a Trading Plan (boring bit that actually makes you profitable) 0 replies

It's been a bit crazy... 1 reply

Learning out of desperation----a bit of a blog

  • #41
  • Aug 23, 2009 12:57pm Aug 23, 2009 12:57pm
if i put it before
Inserted Code
if (myOrderType==0)

i get

';' - unbalanced parentheses Erogram Files (x86)MetaTrader - Alpari test1expertsStacker.mq4 (55, 38)

ending bracket '}' expected


i dont understand
  • #42
  • Aug 23, 2009 1:00pm Aug 23, 2009 1:00pm
tut tut tut!! missing a } somewhere!!
Looking for it now!!!

Or NOT!

The semi needs to be in the para

if (OrdersTotal()==0) {myOrderType=0};

Should be

if (OrdersTotal()==0) {myOrderType=0;}
The winner of the rat race is still a rat.
  • #43
  • Aug 23, 2009 1:01pm Aug 23, 2009 1:01pm
lol, but there isnt, if you remove the line, it works, add it, then it stops, the line has none missing
  • #44
  • Aug 23, 2009 1:03pm Aug 23, 2009 1:03pm
updated post above
The winner of the rat race is still a rat.
  • #45
  • Aug 23, 2009 1:13pm Aug 23, 2009 1:13pm
stupid language......thanks luca
  • #46
  • Aug 23, 2009 2:51pm Aug 23, 2009 2:51pm
now it performs as i require, it opens an order and after it closes it opens another, yay

now for something a little more complex, i dont even know where to start with this

myOrderType 3 and 4, they will be identical execpt 3 is buy and 4 is sell trades

when a type 1(buy) trade is in profit by "pips" amount i wan to open another buy trade

as far as i understand it, have to query the open order and do a calculation based on the profit in pips, then if the outcome of the calculation is the required level i need another op_buy

where do i start with this? im getting out of my depth now
  • #47
  • Aug 23, 2009 2:55pm Aug 23, 2009 2:55pm
so far i got this LMAO

if (myOrderType==3){
}
  • #48
  • Aug 23, 2009 2:56pm Aug 23, 2009 2:56pm
http://docs.mql4.com/trading/OrderProfit

You will need to cycle through open orders... look on that codebase there will certainly be something that you can use with a little hacking.....
The winner of the rat race is still a rat.
  • #49
  • Aug 23, 2009 3:11pm Aug 23, 2009 3:11pm
Quoting luxinterior
Take a look at the OrderProfit() function in the help file. It should be all you need really. If you want to know the pips rather than the $ amount you can use OrderOpenPrice() and either add/subtract it to the current Ask/Bid depending on whether the order is a buy/sell.

Good luck

Lux
was just looking back to this post
  • #50
  • Aug 23, 2009 4:19pm Aug 23, 2009 4:19pm
http://docs.mql4.com/trading/OrdersTotal

Look at this for the for code... ignore all the rest of the functional ideas of that code...

but in the "for" loop use orderselect() to look at the profit/loss of each open order and then look at the op type of the order and decide accordingly what to do!!

Keep posting code and I will help as I can!

HTH

LL
The winner of the rat race is still a rat.
  • #51
  • Aug 24, 2009 9:29am Aug 24, 2009 9:29am
I have the system opening a 2nd order, but i think ive got it wrong

i added this for orders of type 3

Inserted Code
   if (myOrderType==3){
                       if ((Bid-OrderOpenPrice()) >= Pips)
                          {
                           OrderSend(Symbol(),OP_BUY,(LotSize * Multiplier) ,Ask,slippage,Ask-StopLoss,Ask+TakeProfit-Pips,"Stacker Buy",MagicNumber,0,Blue);
                          }
                      }

on backtest it opens an order at the exact same time as the 1st order, not when it is the desired amount in profit
  • #52
  • Aug 24, 2009 9:35am Aug 24, 2009 9:35am
Im really unsure how to use commands which look at the already open orders and specific criteria of them
  • #53
  • Aug 24, 2009 10:05am Aug 24, 2009 10:05am
OrderSelect() selects the orders...
Then you can use:

OrderModify()
OrderClose()

To do whatever you need to the orders.
  • #54
  • Aug 24, 2009 10:14am Aug 24, 2009 10:14am
Quoting Ronald Raygun
OrderSelect() selects the orders...
Then you can use:

OrderModify()
OrderClose()

To do whatever you need to the orders.
selects which order? if you have 2 orders open, how do you specify one?
  • #55
  • Aug 24, 2009 10:34am Aug 24, 2009 10:34am
Quoting BenScoobert
selects which order? if you have 2 orders open, how do you specify one?
Set up a loop where you use the OrderSelect function to scan through all of the orders until you find the one that meets your criteria.

bool OrderSelect( int index, int select, int pool=MODE_TRADES)
The function selects an order for further processing. It returns TRUE if the function succeeds. It returns FALSE if the function fails. To get the error information, one has to call the GetLastError() function.
The pool parameter is ignored if the order is selected by the ticket number. The ticket number is a unique order identifier. To find out from what list the order has been selected, its close time must be analyzed. If the order close time equals to 0, the order is open or pending and taken from the terminal open positions list. One can distinguish an open position from a pending order by the order type. If the order close time does not equal to 0, the order is a closed order or a deleted pending order and was selected from the terminal history. They also differ from each other by their order types.
Parameters:
index - Order index or order ticket depending on the second parameter.
select - Selecting flags. It can be any of the following values:
SELECT_BY_POS - index in the order pool,
SELECT_BY_TICKET - index is order ticket.
pool - Optional order pool index. Used when the selected parameter is SELECT_BY_POS. It can be any of the following values:
MODE_TRADES (default)- order selected from trading pool(opened and pending orders),
MODE_HISTORY - order selected from history pool (closed and canceled order).


Once an order is selected you can use any of the functions below to figure out if this is the order you need.



OrderClose
OrderCloseBy
OrderClosePrice
OrderCloseTime
OrderComment
OrderCommission
OrderDelete
OrderExpiration
OrderLots
OrderMagicNumber
OrderModify
OrderOpenPrice
OrderOpenTime
OrderPrint
OrderProfit
OrderSelect
OrderSend
OrdersHistoryTotal
OrderStopLoss
OrdersTotal
OrderSwap
OrderSymbol
OrderTakeProfit
OrderTicket
OrderType
  • #56
  • Aug 24, 2009 10:44am Aug 24, 2009 10:44am
like this from the makegrid EA?

Inserted Code
if (CloseAll == 1)
     {
      TotalOrders = OrdersTotal();
      for (i=0; i<TotalOrders; i++)
        {
         if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
           {
            if (((OrderSymbol() == Symbol()) && (OrderType() == OP_BUY) && (CloseBuyFirst == 1)) ||
                ((CloseBuyFirst == 0) && (CloseSellFirst == 0)))
               {
               if ((Bid-OrderOpenPrice()) < 0)
                 {
                  OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, LawnGreen);
                  return(0);
                 }
      
               if ((Bid-OrderOpenPrice()) > 0)
                 {
                  OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, Gold);
                  return(0);        
                  }
              }
    
            if (((OrderSymbol() == Symbol()) && (OrderType() == OP_SELL) && (CloseSellFirst == 1)) ||
                ((CloseBuyFirst == 0) && (CloseSellFirst == 0)))
              {
               if ((OrderOpenPrice()-Ask) < 0)
                 {
                  OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, HotPink);
                  return(0);
                 }

               if ((OrderOpenPrice()-Ask) > 0)
                 {
                  OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, Gold);
                  return(0);
                 }
              }
           } // if OrderSelect()
        }    // for i=0 to OrdersTotal()
     }       // if CloseAll == 1
  • #57
  • Aug 24, 2009 10:53am Aug 24, 2009 10:53am
yup
  • #58
  • Aug 24, 2009 11:00am Aug 24, 2009 11:00am
SELECT_BY_POS
MODE_TRADES

what do these 2 commands do?
  • #59
  • Aug 24, 2009 11:09am Aug 24, 2009 11:09am
SELECT_BY_POS - index in the order pool, i.e. step through sequentially
SELECT_BY_TICKET - index is order ticket.
pool - Optional order pool index. Used when the selected parameter is SELECT_BY_POS. It can be any of the following values:
MODE_TRADES (default)- order selected from trading pool(opened and pending orders),
MODE_HISTORY - order selected from history pool (closed and canceled order).
  • #60
  • Aug 24, 2009 11:10am Aug 24, 2009 11:10am
1) The position of the order. Use the OrdersTotal() function to determine how many orders there are. So, let's say there are 10 orders, you then cycle through each order (position 1 through 10) and check each order that way.

2) Ticket of the order. If you already know the ticket of the Order, you can use OrderSelect to select that specific order already instead of cycling through several orders
0 traders viewing now