Learning out of desperation----a bit of a blog

#21
Aug 20, 2009 2:19pm Aug 20, 2009 2:19pm

Ronald Raygun
Joined Jul 2007 | Status: 33 y/o Investor/Trader/Programmer | 5,016 Posts

Can you put up the whole code?

#22
Aug 20, 2009 2:20pm Aug 20, 2009 2:20pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

Inserted Code

//+------------------------------------------------------------------+
//|                                                      Stacker.mq4 |
//|                                                    Ben Coulthard |
//|                            bencoulthard at hotmail dot co dot uk |
//+------------------------------------------------------------------+
#property copyright "Ben Coulthard"
#property link      "bencoulthard at hotmail dot co dot uk"

//---- input parameters
extern int       myOrderType        = 0;
extern double    TakeProfit         = 200.0;
extern double    StopLoss           = 200.0;
extern double    Multiplier         = 2.0;
extern double    LotSize            = 0.01;
extern int       MagicNumber        = 801369;
extern double    Pips               = 200.0;
extern int       Fast_EMA           = 12;
extern int       Slow_EMA           = 26;
extern int       Signal_SMA         = 9;
extern int       Shift              = 1;
extern int       TradingRange       = 0;
datetime         TimeStamp          = 0;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {

   myOrderType=3;

   double MACDMainCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift);
   double MACDSigCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift);
   double MACDMainPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift+1);
   double MACDSigPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift+1);

   double SellRange=TradingRange*Point;
   double BuyRange=(TradingRange-(TradingRange*2))*Point;

   if(MACDMainCurr>MACDSigCurr && MACDMainPre<MACDSigPre && MACDSigPre<BuyRange && MACDMainCurr<0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=2; TimeStamp=iTime(NULL,0,0);}
   if(MACDMainCurr<MACDSigCurr && MACDMainPre>MACDSigPre && MACDSigPre>SellRange && MACDMainCurr>0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=1; TimeStamp=iTime(NULL,0,0);}

return(myOrderType);

if (myOrderType == 1) Print("type 1");
if (myOrderType == 2) Print("type 2");
  }
//+------------------------------------------------------------------+

#23
Aug 20, 2009 2:24pm Aug 20, 2009 2:24pm

Ronald Raygun
Joined Jul 2007 | Status: 33 y/o Investor/Trader/Programmer | 5,016 Posts

The code you put in is too far down.

Inserted Code

//+------------------------------------------------------------------+
//|                                                      Stacker.mq4 |
//|                                                    Ben Coulthard |
//|                            bencoulthard at hotmail dot co dot uk |
//+------------------------------------------------------------------+
#property copyright "Ben Coulthard"
#property link      "bencoulthard at hotmail dot co dot uk"

//---- input parameters
extern int       myOrderType        = 0;
extern double    TakeProfit         = 200.0;
extern double    StopLoss           = 200.0;
extern double    Multiplier         = 2.0;
extern double    LotSize            = 0.01;
extern int       MagicNumber        = 801369;
extern double    Pips               = 200.0;
extern int       Fast_EMA           = 12;
extern int       Slow_EMA           = 26;
extern int       Signal_SMA         = 9;
extern int       Shift              = 1;
extern int       TradingRange       = 0;
datetime         TimeStamp          = 0;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {

   myOrderType=3;

   double MACDMainCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift);
   double MACDSigCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift);
   double MACDMainPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift+1);
   double MACDSigPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift+1);

   double SellRange=TradingRange*Point;
   double BuyRange=(TradingRange-(TradingRange*2))*Point;

   if(MACDMainCurr>MACDSigCurr && MACDMainPre<MACDSigPre && MACDSigPre<BuyRange && MACDMainCurr<0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=2; TimeStamp=iTime(NULL,0,0);}
   if(MACDMainCurr<MACDSigCurr && MACDMainPre>MACDSigPre && MACDSigPre>SellRange && MACDMainCurr>0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=1; TimeStamp=iTime(NULL,0,0);}

if (myOrderType == 1) Print("type 1");
if (myOrderType == 2) Print("type 2");

return(myOrderType);


  }
//+------------------------------------------------------------------+

#24
Aug 20, 2009 2:28pm Aug 20, 2009 2:28pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

ah i see, i thought the return was what that bit would act on

#25
Aug 20, 2009 3:03pm Aug 20, 2009 3:03pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

2009.08.20 21:03:01 Stacker GBPJPY,M1: type 1

yay for ron

#26
Aug 21, 2009 1:45pm Aug 21, 2009 1:45pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

the "return" command

when this is placed, does that mean the ea stops and waits for the next pip?

but i can have more than 1 "return" command in 1 ea i think, carefully placed

#27
Aug 21, 2009 1:47pm Aug 21, 2009 1:47pm

Ronald Raygun
Joined Jul 2007 | Status: 33 y/o Investor/Trader/Programmer | 5,016 Posts

return command is the end of a function.

Yes, you can have multiple return commands in a fuction

#28
Aug 21, 2009 1:48pm Aug 21, 2009 1:48pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

Quoting Ronald Raygun

Disliked

return command is the end of a function.

Yes, you can have multiple return commands in a fuction

Ignored

so it doesnt cause it to stop and wait for the next pip?

#29
Aug 21, 2009 1:54pm Aug 21, 2009 1:54pm

Ronald Raygun
Joined Jul 2007 | Status: 33 y/o Investor/Trader/Programmer | 5,016 Posts

Not necessarily.

That applies to the start() function.

If you wrote a custom function, that obviously wouldn't apply.

#30
Aug 21, 2009 1:55pm Aug 21, 2009 1:55pm

magnumfreak
Joined Nov 2007 | Status: Trying manual mode again | 2,210 Posts

Quoting BenScoobert

Disliked

so it doesnt cause it to stop and wait for the next pip?

Ignored

it will within the start() function. Everywhere else it will just return it back to the point that called the function.

#31
Aug 21, 2009 2:55pm Aug 21, 2009 2:55pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

heres a bit of code from the tutorial, it has 2 return commands, can you explain it on this example?

Inserted Code

//--------------------------------------------------------------------
// dialogue.mq4
// The code should be used for educational purpose only.
//--------------------------------------------------------------- 1 --
#include <WinUser32.mqh>               // Needed to MessageBox
extern double Time_News=15.30;         // Time of important news
bool Question=false;                   // Flag (question is not put yet)
//--------------------------------------------------------------- 2 --
int start()                            // Special function start
  {
   PlaySound("tick.wav");              // At each tick
   double Time_cur=Hour()+ Minute()/100.0;// Current time (double)
   if (OrdersTotal()>0 && Question==false && Time_cur<=Time_News-0.05)
     {                                 // Providing some conditions
      PlaySound("news.wav");           // At each tick
      Question=true;                   // Flag (question is already put)
      int ret=MessageBox("Time of important news release. Close all orders?",
      "Question", MB_YESNO|MB_ICONQUESTION|MB_TOPMOST); // Message box
      //--------------------------------------------------------- 3 --
      if(ret==IDYES)                   // If the answer is Yes
         Close_Orders();               // Close all orders
     }
   return;                             // Exit 
  }
//--------------------------------------------------------------- 4 --
void Close_Orders()                    // Cust. funct. for closing orders
  {
   Alert("Function of closing all orders is being executed.");// For illustration
   return;                             // Exit 
  }
//--------------------------------------------------------------- 5 --

#32
Aug 21, 2009 3:24pm Aug 21, 2009 3:24pm

magnumfreak
Joined Nov 2007 | Status: Trying manual mode again | 2,210 Posts

Quoting BenScoobert

Disliked

heres a bit of code from the tutorial, it has 2 return commands, can you explain it on this example?

Ignored

Inserted Code

//--------------------------------------------------------------------
// dialogue.mq4
// The code should be used for educational purpose only.
//--------------------------------------------------------------- 1 --
#include <WinUser32.mqh>               // Needed to MessageBox
extern double Time_News=15.30;         // Time of important news
bool Question=false;                   // Flag (question is not put yet)
//--------------------------------------------------------------- 2 --
int start()                            // Special function start
  {
   PlaySound("tick.wav");              // At each tick
   double Time_cur=Hour()+ Minute()/100.0;// Current time (double)
   if (OrdersTotal()>0 && Question==false && Time_cur<=Time_News-0.05)
     {                                 // Providing some conditions
      PlaySound("news.wav");           // At each tick
      Question=true;                   // Flag (question is already put)
      int ret=MessageBox("Time of important news release. Close all orders?",
      "Question", MB_YESNO|MB_ICONQUESTION|MB_TOPMOST); // Message box
      //--------------------------------------------------------- 3 --
      if(ret==IDYES)                   // If the answer is Yes
         Close_Orders();               // Close all orders [color="Magenta"] This Step will call the custom function "Close_Orders()"[/color]
     }
   return;                             // Exit [color="Magenta"]This return will exit the start function and cause it to wait for the next tick.[/color]
  }
//--------------------------------------------------------------- 4 --
void Close_Orders()                    // Cust. funct. for closing orders
  {
   Alert("Function of closing all orders is being executed.");// For illustration
   return;                             // Exit [color="Magenta"]This return will cause the program to jump back to the line just after where the function "Close_Orders()" was called.[/color]
  }
//--------------------------------------------------------------- 5 --

#33
Aug 22, 2009 9:42am Aug 22, 2009 9:42am

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

Quoting magnumfreak

Disliked

[code]//--------------------------------------------------------------------
// dialogue.mq4
// The code should be used for educational purpose only.
//--------------------------------------------------------------- 1 --
#include <WinUser32.mqh>...

Ignored

i dont understand how the 2nd function would be run then

so if the 1st return does as you say, when will the custom function ever be run? in my eyes if it returns at the 1st return it never gets to anything beyond it

thanks for being patient with me

#34
Aug 22, 2009 10:00am Aug 22, 2009 10:00am

magnumfreak
Joined Nov 2007 | Status: Trying manual mode again | 2,210 Posts

when it calls the Close_Orders function it will leave the start function drop down and perform the Close_Orders function then return back to the start function when the return is called.

Since close_orders is called before the return in start, it would execute.

#35
Aug 22, 2009 10:35am Aug 22, 2009 10:35am

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

got it, thanks, its called from start i see

#36
Aug 22, 2009 12:19pm Aug 22, 2009 12:19pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

im missing something here.....for a change :-)

I got my order to open in relation to the previous bit of code, and it works

but, it only open 1 order, closes it then no others, i think this is due to the "myOrderType" variable still being what it was when it was set earlier, im trying to use the OrdersTotal function and if OrdersTotal ==0 then reset myOrderType to 0

myOrderType 3 and 4 will be orders based on already open orders of type 1 and 2 and ill come to that later when i got this to reset when there are no open orders

what am i missing in this code? as it is now im getting the unbalanced parentheses at the end of my myOrderType=0 bit

Inserted Code

if (myOrderType==1){
                    OrderSend(Symbol(),OP_BUY,LotSize,Ask,slippage,Ask-StopLoss,Ask+TakeProfit,"Stacker Buy",MagicNumber,0,Blue);
                    myOrderType=3;
                   }

if (myOrderType==2){
                    OrderSend(Symbol(),OP_SELL,LotSize,Bid,slippage,Ask+StopLoss,Ask-TakeProfit,"Stacker Sell",MagicNumber,0,Red);
                    myOrderType=4;
                   }
OrdersTotal();

if (OrdersTotal()==0) {myOrderType=0};             
                   
if (myOrderType==3){
                   }
if (myOrderType==4){
                   }
                  

return(myOrderType);

#37
Aug 22, 2009 12:35pm Aug 22, 2009 12:35pm

LittleLuca
| Joined Feb 2009 | Status: BoB | 97 Posts

Could you post the full code?

Its a little difficult to debug without seeing full picture...

The winner of the rat race is still a rat.

#38
Aug 22, 2009 12:54pm Aug 22, 2009 12:54pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

Inserted Code

//+------------------------------------------------------------------+
//|                                                      Stacker.mq4 |
//|                                                    Ben Coulthard |
//|                            bencoulthard at hotmail dot co dot uk |
//+------------------------------------------------------------------+
#property copyright "Ben Coulthard"
#property link      "bencoulthard at hotmail dot co dot uk"

//---- input parameters
int              myOrderType        = 0;
extern double    TakeProfit         = 0.00200;
extern double    StopLoss           = 0.00200;
extern double    Multiplier         = 2;
extern double    LotSize            = 0.01;
extern int       MagicNumber        = 801369;
extern double    Pips               = 200.0;
extern int       Fast_EMA           = 12;
extern int       Slow_EMA           = 26;
extern int       Signal_SMA         = 9;
extern int       Shift              = 1;
extern int       TradingRange       = 0;
extern bool      ReverseSignal      = false;
extern double    slippage           = 0;

datetime         TimeStamp          = 0;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
{
//------------------------------------------------------------------------------------------------------------
//--if there are no open trades, check for entry signal and return 1 for buy 2 for sell
if (myOrderType==0)
  {
   double MACDMainCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift);
   double MACDSigCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift);
   double MACDMainPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift+1);
   double MACDSigPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift+1);

   double SellRange=TradingRange*Point;
   double BuyRange=(TradingRange-(TradingRange*2))*Point;

   if(MACDMainCurr>MACDSigCurr && MACDMainPre<MACDSigPre && MACDSigPre<BuyRange && MACDMainCurr<0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=2; TimeStamp=iTime(NULL,0,0);}
   if(MACDMainCurr<MACDSigCurr && MACDMainPre>MACDSigPre && MACDSigPre>SellRange && MACDMainCurr>0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=1; TimeStamp=iTime(NULL,0,0);}

   if (myOrderType == 1) Print("type 1");
   if (myOrderType == 2) Print("type 2");
   if (ReverseSignal) {
                       if (myOrderType==1) { myOrderType=2; }
                         else { if (myOrderType==2) { myOrderType=1; } }
                       }
//------------------------------------------------------------------------------------------------------------
//--if order type is 1 then open a trade


if (myOrderType==1){
                    OrderSend(Symbol(),OP_BUY,LotSize,Ask,slippage,Ask-StopLoss,Ask+TakeProfit,"Stacker Buy",MagicNumber,0,Blue);
                    myOrderType=3;
                   }

if (myOrderType==2){
                    OrderSend(Symbol(),OP_SELL,LotSize,Bid,slippage,Ask+StopLoss,Ask-TakeProfit,"Stacker Sell",MagicNumber,0,Red);
                    myOrderType=4;
                   }
OrdersTotal();

if (OrdersTotal()==0) {myOrderType=0};             
                   
if (myOrderType==3){
                   }
if (myOrderType==4){
                   }
                  

return(myOrderType);


  }
}
//+------------------------------------------------------------------+

#39
Aug 22, 2009 2:02pm Aug 22, 2009 2:02pm

BenScoobert
| Joined Jan 2008 | Status: Pipping along | 907 Posts

i think this line is wrong, but i cant work out how it should be

Inserted Code

if (OrdersTotal()==0) {myOrderType=0};

#40
Aug 23, 2009 7:03am Aug 23, 2009 7:03am

LittleLuca
| Joined Feb 2009 | Status: BoB | 97 Posts

Quoting BenScoobert

Disliked

[code]//+------------------------------------------------------------------+
//|...

Ignored

As i see it everything is enclosed in

if (myOrderType==0)
{

}

which encloses right to the end....

Try taking

OrdersTotal(); // there is no reason for this as all it will do is return something which you don't use....

if (OrdersTotal()==0) {myOrderType=0}; //Here you use OrdersTotal() and check the value it returns against another value(0)

and putting it at the beginning of start

what is happening as I see it is that first tick that a order is opened will keep the start from exiting any of the code below it as myOrderType will always be more than 0,,,

HTH

LL

The winner of the rat race is still a rat.

Platform Tech
/
Learning out of desperation----a bit of a blog
Reply to Thread
- 1 Page 2 3 5
- 1 Page 2 3 5

0 traders viewing now

Options

Similar Threads

Learning out of desperation----a bit of a blog