Need a coding advice......

Ok....I want to make my order execution bulletproof.
I want to be sure that my EA executed all 4 trades.
I want this to keep firing orders untill all 4 is out there!

I coded something like this;

this is at top of code.....
bool TRADE1B=true;
bool TRADE2S=true;
bool TRADE3S=true;
bool TRADE4B=true;

Than after int start() i call function TradeBSSB();

if (( blahblahblahhh=blahblahblahhh )) {TRADE_BSSB();} //this will happen only when there are no trades at all.....
so.....if TRADE_BSSB() puts only one trade due to some broker issue, this function will not be called until num of trades are zero!!!


Than after int start() next function is;

//+------------------------------------------------------------------+
int TRADE_BSSB()
{

if(TRADE1B==TRUE)
{
OrderSend(Symbol_1,OP_BUYSTOP, S1_Lots, LongEntryLevel1, 2, NULL, NULL, "TRADE_1B", magic, NULL, LimeGreen); TRADE1B=false;
}
if(TRADE2S==TRUE)
{
OrderSend(Symbol_2,OP_SELLSTOP, S2_Lots, ShortEntryLevel2, 2, NULL, NULL, "TRADE_2S", magic, NULL, FireBrick); TRADE2S=false;
}
if(TRADE3S==TRUE)
{
OrderSend(Symbol_3,OP_SELLSTOP, S3_Lots, ShortEntryLevel3, 2, NULL, NULL, "TRADE_3S", magic, NULL, FireBrick); TRADE3S=false;
}
if(TRADE4B==TRUE)
{
OrderSend(Symbol_4,OP_BUYSTOP, S4_Lots, LongEntryLevel4, 2, NULL, NULL, "TRADE_4B", magic, NULL, LimeGreen); TRADE4B=false;
}
if (OrdersTotal()<4) {TRADE_BSSB();} //Will this part of code loop through TRADE_BSSB() untill all orders are traded??????
return(0);
}


Will this work!??? Bassicaly I want the TRADE_BSSB() function
to loop until all trades are traded!

Thanks

Fairly simple...

int DontQuit (OrderSend Properties)
{
bool TradePlaced = False;
int AttemptCount = 0;

while (!TradePlaced)
{
if(OrderSend(...) > 0)
{
TradePlaced = True;
}
else
{
AttemptCount++;
}
}

return(AttemptCount);
}


the way this code works, is it waits until the OrderSend function returns a value greater than 0. (the ticket number) and when it's finally successful, returns the number of attempts.

This is not really a loop, it is a recursive function call, the function is calling itself. This may work if the number of iterations is small enough but it will increase the stack with every iteration. when it's finally done and the last function call succeded it will have to go back through all the return() calls until its back out of the outermost function call. So the machine must remember for *every* call to the function where to return to after it is done, this is called the stack, its a FILO buffer (first-in-last-out) and it is limited in size.

What you want to do is a while loop as RR pointed out, there you dont have such limitations with the stack, you can iterate as often as you want.

(there are languages such as LISP for example where basically every loop is done as such a recursion but there are special mechanisms in place that make sure the stack doesnt grow when there are no further instructions between the recursive call and the final return(), mql4 is not such a clever language)

Do it the way RR pointed out. Write one function that will place one trade and only returns if successful and then call this function 4 times.

You could also modify your own example by using a loop instead of recursive calling, but i would rather solve this order send problem once and for all in a foolproof function that you could then reuse in other projects.

There are certain errors that can happen that should cause your system to halt. Error checking is worth the trouble.

Thank you guys......I will give it a try, or think of some other solution.
Regards