Code for Trade hour

Hi Peoples,

I am trying to get my EA to trade only between certain hours.
Can anyone shed some light on why this code will not work for me?



extern bool UseHourTrade = True;
extern int GMTOffSet = 1;
extern int FromHourTrade = 6;
extern int ToHourTrade = 18;



if(MayOpenDeferOrder) // MayOpenDeferOrder is a buy stop or buy limit order
{
if ((UseHourTrade==true)&& ((Hour()+GMTOffSet)<= FromHourTrade && (Hour()+GMTOffSet) >= ToHourTrade)) MayOpenDeferOrder = false;
}

Thanks in advance,

A

You have it backwards.

I'm assuming you want the EA to trade between 6:00 and 18:00, correct?

if(Hour() >= StartTime && Hour() < EndTime) OrderSend...

I am a beginner (just started coding today) and what the line is supposed to say is;

Check before submit and if the time is outside trade hour, don't submit the order.

So it is not working that way.. I must be wrong somewhere. Am I still back to front?

Ok,

if(MayOpenDeferOrder) // MayOpenDeferOrder is a buy stop or buy limit order
{
if ((UseHourTrade==true)&&
//If the time is earlier than the starting time
((Hour()+GMTOffSet)<= FromHourTrade &&
//If the time is later than the ending time
(Hour()+GMTOffSet) >= ToHourTrade)) MayOpenDeferOrder = false;
}

The time cannot be both earlier than the starting time, AND later than the starting time. You need to use the OR "||" command.

So...

if(MayOpenDeferOrder) // MayOpenDeferOrder is a buy stop or buy limit order
{
if ((UseHourTrade==true)&& ( ((Hour()+GMTOffSet)<= FromHourTrade || (Hour()+GMTOffSet) >= ToHourTrade)) )MayOpenDeferOrder = false;
}

You may want to use TimeHour(TimeCurrent()); for your hour. I seem to remember something goofy about Hour();

Thanks mate, still not working but I am sure I would never have it working if I had used the & instead of the or.

Getting closer

Ok, I will look that up and put that in instead..

1.30am here.. maybe I will continue this tomorrow

cheers

A

Ok, Thanks Guys,

just what I wanted and it works now,


{
if((UseHourTrade==true)&& ((TimeHour(TimeCurrent())<= FromHourTrade || TimeHour(TimeCurrent()) >= ToHourTrade))) MayOpenDeferOrder = false;
}