I'm in trouble with EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Having Trouble with MetaTrader 4 replies

Having Trouble with my Charting Program... 2 replies

Trouble converting 1min data 2 replies

Little trouble with Metatrader 2 replies

trouble launching advanced get charts 2 replies

Attachments: I'm in trouble with EA
Exit Attachments

I'm in trouble with EA

  • #1
  • First Post: Aug 19, 2009 5:42pm Aug 19, 2009 5:42pm
Ok, I am really desparate.

I have a pretty good EA, but it does not handle big and sudden market shifts.

Currently I have paid three times (first one 3 weeks ago and the last 1 week ago) to have this done and no one has turned up with the goods. They have all said it is only a few lines.

I am sure they all will do it and they seem honest but I am really in trouble here. I have stopped trading (big loss last night on the GBP) this morning until someone will do this for me.


I need a rule written into the code ASAP.. the pictures show the problem and my answer to it.

Will someone please help.. or just tell me how to do it?
Attached Image(s) (click to enlarge)
Click to Enlarge Name: The Problem.png Size: 17 KB
Click to Enlarge Name: solution.png Size: 16 KB
  • #2
  • Aug 19, 2009 9:25pm Aug 19, 2009 9:25pm
can you post the EA??
  • #3
  • Edited 9:44pm Aug 19, 2009 9:41pm | Edited 9:44pm
Quoting magnumfreak
can you post the EA??
Sure

this is the link
Attached File(s)
File Type: mq4 EA.mq4   52 KB | 291 downloads
  • #4
  • Aug 19, 2009 10:21pm Aug 19, 2009 10:21pm
OK, well would someone paste a line of code that will give me the close of the last hour bar and the high of the hour bar before it?
  • #5
  • Aug 19, 2009 10:23pm Aug 19, 2009 10:23pm
Quoting asgard2
OK, well would someone paste a line of code that will give me the close of the last hour bar and the high of the hour bar before it?
Close of previous bar: Close[1];
High of bar before that: High[2];
  • #6
  • Aug 19, 2009 10:47pm Aug 19, 2009 10:47pm
The above assumes your on a 1 hour TF. If not use the iClose and iHigh functions and specify the TF like...

Inserted Code
iClose(NULL,Period_H1,1)
iHigh(NULL,Period_H1, 2)

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #7
  • Edited 11:06pm Aug 19, 2009 10:53pm | Edited 11:06pm
Quoting luxinterior
The above assumes your on a 1 hour TF. If not use the iClose and iHigh functions and specify the TF like...

Inserted Code
iClose(NULL,Period_H1,1)
iHigh(NULL,Period_H1, 2)
Lux

Thanks Guys, so will this work?

extern pricepoint=40 //allowed drop in pips per hour before order send


if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)--pricepoint >= iClose(NULL,Period_H1,1)))
{
MayOpenRealOrder = true;
  • #8
  • Aug 19, 2009 11:12pm Aug 19, 2009 11:12pm
Quoting asgard2
Thanks Guys, so will this work?

extern pricepoint=40 //allowed drop in pips per hour before order send


if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)--pricepoint >= iClose(NULL,Period_H1,1)))
{
MayOpenRealOrder = true;
No.

Pricepoint must be converted into pips. You do so by multiplying it by Point. This also assumes that you are using a standard broker and not one that uses fractional pip pricing.

Also, you only need one - sign just before pricepoint.
  • #9
  • Aug 19, 2009 11:33pm Aug 19, 2009 11:33pm
Quoting magnumfreak
No.

Pricepoint must be converted into pips. You do so by multiplying it by Point. This also assumes that you are using a standard broker and not one that uses fractional pip pricing.

Also, you only need one - sign just before pricepoint.
Hmm

Ok to covert pricepoint to pips, I always thought they were the same, just call me a nuff head. Been doing this a while now and I am in shock that I have missed this. Would appreciate some direction here?

I am running a 5 digit broker by adding a zero to the end of each relevant variable.

Do I need to normalize the result of the bar condition?

fixed the - sign below


extern pricepoint=40 //allowed drop in pips per hour before order send


if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)-pricepoint >= iClose(NULL,Period_H1,1)))
{
MayOpenRealOrder = true;
  • #10
  • Aug 19, 2009 11:53pm Aug 19, 2009 11:53pm
Quoting asgard2
Hmm

Ok to covert pricepoint to pips, I always thought they were the same, just call me a nuff head. Been doing this a while now and I am in shock that I have missed this. Would appreciate some direction here?

I am running a 5 digit broker by adding a zero to the end of each relevant variable.

Do I need to normalize the result of the bar condition?

fixed the - sign below


extern pricepoint=40 //allowed drop in pips per hour before order send


if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)-pricepoint >= iClose(NULL,Period_H1,1)))...
You have to see it the same way a computer sees it. Just as an example let's say that GBPJPY's high two bars ago was 156.27 if you subtract 40 from that you would get 116.27 definitely not the number you were looking for. In order for the calculation to be correct you must convert it into the actual price change that represents that 40 pips. That is why you need to multiply it by Point. Point is the decimal equivalent to a single pip for that pair. So in the case of GBPJPY point is 0.01. If you multiply 40 by 0.01 you get 0.40 which will work for the calculation.
  • #11
  • Aug 20, 2009 12:14am Aug 20, 2009 12:14am
Quoting magnumfreak
In order for the calculation to be correct you must convert it into the actual price change that represents that 40 pips. That is why you need to multiply it by Point. Point is the decimal equivalent to a single pip for that pair. So in the case of GBPJPY point is 0.01. If you multiply 40 by 0.01 you get 0.40 which will work for the calculation.
OK, I got you now.. so this should work and I could then change pricepoint from 40 to 400 for a five digit broker, yes?

Extern pricepoint=40 //allowed drop in pips per hour before order send

if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)-(pricepoint*0.0001) >= iClose(NULL,Period_H1,1)))

{
MayOpenRealOrder = true;
  • #12
  • Edited 12:47am Aug 20, 2009 12:21am | Edited 12:47am
In your top where you have the extern variables put:

int Mult = 1;

Then in the init() put:

if ( Digits == 3 || Digits == 5 )
Mult = 10;

Then in the code you have put:

if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)-(pricepoint*Point*Mult) >= iClose(NULL,Period_H1,1)))

{
MayOpenRealOrder = true;

This will automatically account for a 4 or 5 digit broker.
  • #13
  • Aug 20, 2009 12:47am Aug 20, 2009 12:47am
Quoting smjones
In your top where you have the extern variables put:

int Mult = 1;

Then in the init() put:

if ( Digits == 3 || Digits == 5 )
mult = 10;

Then in the code you have put:

if((type == _OP_Buy) && (iHigh(NULL,Period_H1, 2)-(pricepoint*Point*mult) >= iClose(NULL,Period_H1,1)))

{
MayOpenRealOrder = true;

This will automatically account for a 4 or 5 digit broker.
Ok, thank you for that..

Now, the last and very important question... Where do I paste that line of code in the EA so it doesn't do any harm but still works?

Would some one take a look at it just to let me know where I should paste it.

thanks everyone, you have all been great!
  • #14
  • Edited 1:56am Aug 20, 2009 1:55am | Edited 1:56am
No, the code is not working.. still sending buy orders on a downtrend. Maybe I have it in the wrong place or maybe it they are some other orders than real orders.

I changed it a bit to see if it was the fault of the code but it is not making a difference.

I have pasted some original code so you guys can tell me if it is in the wrong place

thanks A


if(MayOpenRealOrder)
{
if(!glCheckHighLowLimit(_OrderOpenPrice, type, typestr)) MayOpenRealOrder = false;
}

if(MayOpenRealOrder)
{
if(!glCheckOpenOrdersBeforeAdding(_OrderOpenPrice, _OrderType, CurrentPrice)) MayOpenRealOrder = false;
}
if(MayOpenRealOrder) //code added Aug 20 2009
{
if((type == _OP_BUY) && (iHigh(NULL,PERIOD_H1,2) >= iClose(NULL,PERIOD_H1,1)+(pricepoint*0.0001))) MayOpenRealOrder = false;
}
  • #15
  • Last Post: Aug 20, 2009 2:51am Aug 20, 2009 2:51am
Thanks so much to the people that helped me here.

You are a credit to this forum..

It is all working now, let me know if there is something I can give back

cheers

A
0 traders viewing now