Learning out of desperation----a bit of a blog | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Learning at the speed of snail [Newbie Learning Journal] 9 replies

Questions to Analyze a Trading Plan (boring bit that actually makes you profitable) 0 replies

It's been a bit crazy... 1 reply

Learning out of desperation----a bit of a blog

  • #1
  • First Post: Aug 18, 2009 4:37am Aug 18, 2009 4:37am
A few weeks ago I came up with an idea for an EA. I put the idea around and noone is particularly interested in coding it for me, and why should they.

So I decided to code it myself, I did a little OO coding at uni (smalltalk) and I'm no idiot (i hope). I figure I should be able to scrape my way through.

I've been through the mql4 site tutorial over the last few days and I am a little wiser for it, I am currently fumbling through another tutorial by trendchaser (http://trendchaser.org/forum/phpBB3/...php?f=64&t=350) but the site seems to be down at the minute and can't get off page 1.

So I thought I'd write a bit here whilst the site is restarting/recovering.

This little blog isn't aimed at anyone in particular, just a bit of a diary for me and if anyone finds it of any use then good luck to you.
If any seasoned coders wish to kick me in the right direction then please do and I hope I can learn from you.

Ben
  • #2
  • Aug 18, 2009 5:27am Aug 18, 2009 5:27am
My 1st question, I think I got it but just to clarify.

The init and deinit sections, those bits are executed when the EA is applied to the chart, and the start bit is run every tick.

Is that correct?
  • #3
  • Aug 18, 2009 5:29am Aug 18, 2009 5:29am
Quoting BenScoobert
My 1st question, I think I got it but just to clarify.

The init and deinit sections, those bits are executed when the EA is applied to the chart, and the start bit is run every tick.

Is that correct?
init when applied
deinit when removed
start on each tick

true for both EA's and indicators.
  • #4
  • Aug 18, 2009 5:42am Aug 18, 2009 5:42am
Quoting magnumfreak
init when applied
deinit when removed
start on each tick

true for both EA's and indicators.
That is what I meant....But not what I said

Thanks for your quick reply
  • #5
  • Aug 18, 2009 1:42pm Aug 18, 2009 1:42pm
ok so i got an ea to open a trade, yay for me

could anyone assist me with opening another trade, based on the profit or loss of the one already open?
  • #6
  • Edited 6:09pm Aug 18, 2009 6:07pm | Edited 6:09pm
Take a look at the OrderProfit() function in the help file. It should be all you need really. If you want to know the pips rather than the $ amount you can use OrderOpenPrice() and either add/subtract it to the current Ask/Bid depending on whether the order is a buy/sell.

Good luck

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #7
  • Aug 18, 2009 10:25pm Aug 18, 2009 10:25pm
id be happy to help, send the questions, il check here daily and answere what i can

coding is not complicated, theres always a short and simple way, thats my way
  • #8
  • Aug 19, 2009 10:08am Aug 19, 2009 10:08am
Quoting luxinterior
Take a look at the OrderProfit() function in the help file. It should be all you need really. If you want to know the pips rather than the $ amount you can use OrderOpenPrice() and either add/subtract it to the current Ask/Bid depending on whether the order is a buy/sell.

Good luck

Lux
OrderProfit() will give the amount in $ then?
  • #9
  • Aug 19, 2009 10:08am Aug 19, 2009 10:08am
Quoting trendchaser
id be happy to help, send the questions, il check here daily and answere what i can

coding is not complicated, theres always a short and simple way, thats my way
Thanks TC, if i give up through frustration, ill just pay you to do it :-)
  • #10
  • Aug 19, 2009 1:42pm Aug 19, 2009 1:42pm
Quoting trendchaser
coding is not complicated
then why does my head hurt so much!!!!
  • #11
  • Aug 19, 2009 1:43pm Aug 19, 2009 1:43pm
You think it's complicated =D

coding is really just learning another language. Once you can 'speak' it, you are comfortable and think nothing of it.
  • #12
  • Aug 19, 2009 1:47pm Aug 19, 2009 1:47pm
Quoting Ronald Raygun
You think it's complicated =D

coding is really just learning another language. Once you can 'speak' it, you are comfortable and think nothing of it.
If i could write an ea at 10% the speed you do, id be a happy bunny
  • #13
  • Aug 19, 2009 1:51pm Aug 19, 2009 1:51pm
Quoting BenScoobert
If i could write an ea at 10% the speed you do, id be a happy bunny
Wanna know my secret?

I have a template.

The only thing which really changes from EA to EA is the order entry logic. Everything else (trade management, order entry, order exit, etc). is already there. I do have to tweak that from time to time, but it's overall not that bad.
  • #14
  • Aug 19, 2009 1:55pm Aug 19, 2009 1:55pm
Ive copy and pasted bits from other eas and added bits myself. But its so slow.

I have to look up a command, then the syntax and work out how I can apply that. Thats an hour wasted per command
  • #15
  • Aug 20, 2009 11:30am Aug 20, 2009 11:30am
I've come up with a learning plan following a discussion with trendchaser.

I will work through this 1 function at a time and build the EA post by post, this way it may be more like a step by step tutorial.

So here goes, firstly I want to use this EA as a template so I can edit the entry and try different things. For now I will use the initial 10p3 entry I have here, I dont fully understand it, but I hope to as we progress.

Inserted Code
int MACD()
{
   myOrderType=3;

   double MACDMainCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift);
   double MACDSigCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift);
   double MACDMainPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift+1);
   double MACDSigPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift+1);

   double SellRange=TradingRange*Point;
   double BuyRange=(TradingRange-(TradingRange*2))*Point;

   if(MACDMainCurr>MACDSigCurr && MACDMainPre<MACDSigPre && MACDSigPre<BuyRange && MACDMainCurr<0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=2; TimeStamp=iTime(NULL,0,0);}
   if(MACDMainCurr<MACDSigCurr && MACDMainPre>MACDSigPre && MACDSigPre>SellRange && MACDMainCurr>0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=1; TimeStamp=iTime(NULL,0,0);}
   
   text3=DoubleToStr(SellRange,Digits);
   text4=DoubleToStr(BuyRange,Digits);

return(myOrderType);
  • #16
  • Aug 20, 2009 12:13pm Aug 20, 2009 12:13pm
I'd just like to point out at this point that I'm not re-creating 10p3, nor any other martingale EA where you double up your losses. Although with my initial variables it does look like that.

OK heres my starting code
Inserted Code
//+------------------------------------------------------------------+
//|                                                      Stacker.mq4 |
//|                                                    Ben Coulthard |
//|                            bencoulthard at hotmail dot co dot uk |
//+------------------------------------------------------------------+
#property copyright "Ben Coulthard"
#property link      "bencoulthard at hotmail dot co dot uk"

//---- input parameters
extern int       myOrderType        = 0;
extern double    TakeProfit         = 200.0;
extern double    StopLoss           = 200.0;
extern double    Multiplier         = 2.0;
extern double    LotSize            = 0.01;
extern int       MagicNumber        = 801369;
extern double    Pips               = 200.0;
extern int       Fast_EMA           = 12;
extern int       Slow_EMA           = 26;
extern int       Signal_SMA         = 9;
extern int       Shift              = 1;
extern int       TradingRange       = 0;
datetime         TimeStamp          = 0;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {

   myOrderType=3;

   double MACDMainCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift);
   double MACDSigCurr=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift);
   double MACDMainPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_MAIN,Shift+1);
   double MACDSigPre=iMACD(NULL,0,Fast_EMA,Slow_EMA,Signal_SMA,PRICE_CLOSE,MODE_SIGNAL,Shift+1);

   double SellRange=TradingRange*Point;
   double BuyRange=(TradingRange-(TradingRange*2))*Point;

   if(MACDMainCurr>MACDSigCurr && MACDMainPre<MACDSigPre && MACDSigPre<BuyRange && MACDMainCurr<0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=2; TimeStamp=iTime(NULL,0,0);}
   if(MACDMainCurr<MACDSigCurr && MACDMainPre>MACDSigPre && MACDSigPre>SellRange && MACDMainCurr>0 && TimeStamp!=iTime(NULL,0,0)) {myOrderType=1; TimeStamp=iTime(NULL,0,0);}

return(myOrderType);
  }
//+------------------------------------------------------------------+
This doesn't open a trade at the moment, as I understand it this bit of code defines whether it will be a buy or a sell.
Now I'm a little stuck how to use this. Something along the lines of
IF (myOrderType == 1) do this
IF (myOrderType == 2) do the other

HELP
  • #17
  • Aug 20, 2009 1:21pm Aug 20, 2009 1:21pm
Ive added this to the end of teh code to see if im right

if (myOrderType == 1) Comment ( "type 1" );
if (myOrderType == 2) Comment ( "type 2" );
  • #18
  • Aug 20, 2009 2:03pm Aug 20, 2009 2:03pm
Its not working.......... :-(

It should show the comment in the top left of the window right?
  • #19
  • Aug 20, 2009 2:13pm Aug 20, 2009 2:13pm
if (myOrderType == 1) Comment("type 1");
if (myOrderType == 2) Comment("type 2");

Extra spaces might be a problem.

Alternatively:

if (myOrderType == 1) Print("type 1");
if (myOrderType == 2) Print("type 2");

Check the "Experts" tab to see the results
  • #20
  • Aug 20, 2009 2:18pm Aug 20, 2009 2:18pm
Quoting Ronald Raygun
if (myOrderType == 1) Comment("type 1");
if (myOrderType == 2) Comment("type 2");

Extra spaces might be a problem.

Alternatively:

if (myOrderType == 1) Print("type 1");
if (myOrderType == 2) Print("type 2");

Check the "Experts" tab to see the results
2009.08.20 20:16:51 Stacker GBPJPY,M1: initialized
0 traders viewing now