unusual histogram problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Problem with 3 MA Histogram output 1 reply

Unusual Bug with DDE and Excel Scripts in MT4 8 replies

Looking for MT4 indicator - beeps when price volatile or unusual volume? 7 replies

broker for unusual pairs 0 replies

Unusual market game 0 replies

Attachments: unusual histogram problem
Exit Attachments

unusual histogram problem

  • #1
  • First Post: Jul 28, 2009 12:29pm Jul 28, 2009 12:29pm
First let me say that I have an extensive programming background (40 years, many languages) but not much with mql4 - just saying I'm not stupid but I am ignorant

I'm writing an indicator to collect non-timebased data and display it in a time-based fashion e.g. I collect the data in user arrays and as each new bar appears I copy my user arrays to index arrays. Data that may have taken only the time of 1 bar may take several to display and vice-versa.

All is fine with the data on the chart but I can't get the histogram to display the correct color as the value rises and falls - all bars are shown with the "up" color. I'm quite sure I have the greater value in the proper buffer for each bar.

Does anyone know why this might be? And how to fix it...

Thanks in advance.
Old Benjamin was right
  • #2
  • Jul 28, 2009 3:14pm Jul 28, 2009 3:14pm
Quoting Lou G
First let me say that I have an extensive programming background (40 years, many languages) but not much with mql4 - just saying I'm not stupid but I am ignorant

I'm writing an indicator to collect non-timebased data and display it in a time-based fashion e.g. I collect the data in user arrays and as each new bar appears I copy my user arrays to index arrays....
I have only 29 years' programming experience.

But if you post your source, I'll have a look for you.
  • #3
  • Jul 28, 2009 4:00pm Jul 28, 2009 4:00pm
Quoting hanover
I have only 29 years' programming experience.

But if you post your source, I'll have a look for you.
I'm sorry, I did not mean to exalt myself or be offensive - only wanted to make it clear that I am not just some guy who installed MT4 and wants to write indicators with no prior knowledge.
Old Benjamin was right
  • #4
  • Jul 28, 2009 4:10pm Jul 28, 2009 4:10pm
In my embarassment, forgot to post the code. I must have written a dozen or more indys that color the up bars green and the down bars red - can't imagine why this one won't do red.

If you run the code (and wait a while for ticks to accumulate or change the bricksize to 2 pips and wait a shorter while) you'll see that the highs and lows are just as they should be.

Please note that my demo server is 5 decimal, which is why bricksize is 50 and not 5.

I'm actually willing to live with the indy as it stands but it's making me nuts from a coding standpoint that it won't color the bars!

Thanks for responding.
Attached File(s)
File Type: mq4 Renko_v3.mq4   4 KB | 310 downloads
Old Benjamin was right
  • #5
  • Jul 28, 2009 4:11pm Jul 28, 2009 4:11pm
Quoting Lou G
I'm sorry, I did not mean to exalt myself or be offensive - only wanted to make it clear that I am not just some guy who installed MT4 and wants to write indicators with no prior knowledge.
Please forgive me, Lou, just my cryptic sense of humor..... another one of my failed attempts to be light-hearted.

It's always good to meet somebody who actually knows what Assembler and punched cards are! We 'oldies' are the real programmers, LOL.

All the best,
David
  • #6
  • Jul 28, 2009 4:37pm Jul 28, 2009 4:37pm
Quoting hanover
Please forgive me, Lou, just my cryptic sense of humor..... another one of my failed attempts to be light-hearted.

It's always good to meet somebody who actually knows what Assembler and punched cards are! We 'oldies' are the real programmers, LOL.

All the best,
David
I can not only sort cards, I can wire a 407 board (or used to). I got into computers in 1965 with 1401s and Autocoder...

Hope you can see what's wrong with my indy - I must be standing too close to it and can't find the problem.

Best regards,
Lou
Old Benjamin was right
  • #7
  • Jul 28, 2009 7:02pm Jul 28, 2009 7:02pm
I finally isolated the problem and am in the process of correcting it. Like many programming problems, it was really obvious and I can't believe I could not have seen it sooner.

Programming can be very humbling sometimes...

Thanks David for looking at this - sorry if you wasted any time on something so elementary.

Best,
Lou
Old Benjamin was right
  • #8
  • Jul 28, 2009 8:55pm Jul 28, 2009 8:55pm
Quoting Lou G
I finally isolated the problem and am in the process of correcting it. Like many programming problems, it was really obvious and I can't believe I could not have seen it sooner.

Programming can be very humbling sometimes...

Thanks David for looking at this - sorry if you wasted any time on something so elementary.

Best,
Lou
Hi Lou,

My involvement in software development began when I left high school in 1979. During my last years in high school I'd purchased a TRS-80 micro, hence I started out learning BASIC and Z-80 Assembler. Then onto COBOL when I landed my first job in 1980.

Anyway, I'm very glad you've solved your problem. I'd been stripping out sections of your code and then re-attaching the indy to try to find which statement was causing the fault. The job became time consuming because of the wait for it to gather enough data and plot the bricks going forward, for each recompile and test. Then I got interrupted by visitors arriving.

My initial guess was that both 'green' RenkoUp and 'red' RenkoDn buffers might have had values, with the 'green' (buffer 0) taking priority (I'd experienced a similar problem in the past, by initializing a buffer with a value (0.0) instead of EMPTY_VALUE). I noticed your:

SetIndexEmptyValue(0,0.0);
ArrayInitialize(RenkoUp,0.0);

SetIndexEmptyValue(1,0.0);
ArrayInitialize(RenkoDn,0.0);

Anyway, that was as far as I'd got, although I managed to figure out the basic procedural structure (the first part: FirstTick=1 gets executed only once, then it was a case of plotting the bricks upward or downward based on PrevBrick==1 or -1........ and so on).

Anyway, it's all academic now.

All the best,
David
  • #9
  • Jul 29, 2009 3:44am Jul 29, 2009 3:44am
Quoting hanover
TRS-80
I learned BASIC on ye 'olde TRS-80, sorry for butting in David but your post was making me all nostalgic.
The breaking of a wave cannot explain the whole sea.
  • #10
  • Last Post: Jul 29, 2009 7:22am Jul 29, 2009 7:22am
My first home computer was a C64 on which I learned my first non-mainframe language (Basic). My staple languages at that time were Assembler and Cobol for IBM mainframes - this was in the early '80s. I actually purchased a Cobol compiler for the C64 (yes, there really was one) to speed my home programming along while I got up to speed with Basic. As I upgraded hardware I learned more and more new languages (all flavors of C, a dash of Visual Basic, etc.).

My current favorite is Python, though Perl looks interesting and I may learn that as well if I can find the time...

Thanks for responding, gentlemen - nice reminiscing with you,

Lou
Old Benjamin was right
0 traders viewing now