Compilation errors and warnings

#1
First Post: Jun 17, 2009 12:31pm Jun 17, 2009 12:31pm

bobomini
| Joined Jun 2006 | Status: Trader | 50 Posts

I am trying my hand on making an EA that will alert and send email. Essentially, I have copied and pasted together various bits that satisfy the logic I have in mind. However, when I compile in MT4, it gives errors and warnings.
Please if you can, do help.
Cheers:

//+------------------------------------------------------------------+
//| WPR ALERT.mq4 |
//| Copyright

2009, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright

2009, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"
//---- input parameters
extern int periodWPR=14;
extern int HFEhigh1=-20;
extern int HFElow2=-80;
double WPR1,WPR2;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int start()
{
WPR1=iWPR(NULL,0,periodWPR,0);
WPR2=iWPR(NULL,0,periodWPR,1);
Comment("WPR(",periodWPR,") = ",WPR1,"\n",
"TYPE1SELL =",HFEhigh1,"\n",
"TYPE3BUY =",HFElow2);

static int LastAlert = 0;
if( LastAlert == 0 || LastAlert_1 < Bars )

{

Alert(alert_msg);

LastAlert = Bars;

}
bool AlertOnce(string alert_msg, int ref)

{

static int LastAlert_1 = 0;

static int LastAlert_2 = 0;

switch(ref)

{

case 1:

if( LastAlert_1 == 0 || LastAlert_1 < Bars )

{

Alert(alert_msg);

LastAlert_1 = Bars;

return (1);

}

break;

case 2:

if( LastAlert_2 == 0 || LastAlert_2 < Bars )

{

Alert(alert_msg);

LastAlert_2 = Bars;

return (1);

}

break;

}

}

if(WPR2 >HFEhigh1 && WPR1 <HFEhigh1)

{
AlertOnce("WPR >",HFEhigh1,"...TYPE1SELL ", Symbol()); Sleep(100);
SendMail(Symbol()+" SELL", Symbol()+"SELL TIME ");
}
if(WPR2 < HFElow2 && WPR1 > HFElow2 )

{
AlertOnce("WPR <",HFElow2,"... TYPE3BUY ", Symbol());
Sleep(100);
SendMail(Symbol()+" BUY", Symbol()+" BUY TIME ");

}

}
return(0);

#2
Edited Jun 18, 2009 1:16pm Jun 17, 2009 4:00pm | Edited Jun 18, 2009 1:16pm

hanover
Joined Sep 2006 | Status: ... | 8,112 Posts

Quoting bobomini

Disliked

I am trying my hand on making an EA that will alert and send email. Essentially, I have copied and pasted together various bits that satisfy the logic I have in mind. However, when I compile in MT4, it gives errors and warnings.
Please if you can, do help.
Cheers:

Ignored

-- You must define variables before you can reference them.
-- You had unmatched curly braces in your code.
-- You were calling the AlertOnce() function from inside itself, and were sending 4 parameters to it when you had defined it to accept only 2.

I've rearranged your code so that it compiles cleanly, but of course I have no idea whether it will perform what you originally intended it to.

Inserted Code

#property indicator_chart_window

//---- input parameters
extern int periodWPR = 14;
extern int HFEhigh1  = -20;
extern int HFElow2   = -80;
double WPR1, WPR2;

datetime prev_time;

//+------------------------------------------------------------------+
int init()  {
//+------------------------------------------------------------------+
  prev_time = -9999;
  return(0);
}

//+------------------------------------------------------------------+
int start()  {
//+------------------------------------------------------------------+
  if(prev_time != Time[0])  {
    SoundAlert();
    prev_time = Time[0];
  }
  return(0);
}

//+------------------------------------------------------------------+
int SoundAlert()  {

  WPR1 = iWPR(NULL,0,periodWPR,0);
  WPR2 = iWPR(NULL,0,periodWPR,1);
  Comment("WPR(",periodWPR,") = ",WPR1,"n","TYPE1SELL =",HFEhigh1,"n","TYPE3BUY =",HFElow2);
  if(WPR2 > HFEhigh1 && WPR1 < HFEhigh1)
    Alert("WPR >",HFEhigh1,"...TYPE1SELL ", Symbol());
  if(WPR2 < HFElow2 && WPR1 > HFElow2 )
    Alert("WPR <",HFElow2,"... TYPE3BUY ", Symbol());
  return(0);
}

#3
Jun 18, 2009 9:24am Jun 18, 2009 9:24am

bobomini
| Joined Jun 2006 | Status: Trader | 50 Posts

Hi Hanover,
Thanks for your help. Unfortunately, the new EA based on your modifications do not do what I want.
Here is the initial EA which does what I want but sends too many alerts......:

//+------------------------------------------------------------------+
//| WPR ALERT.mq4 |
//| Copyright

2009, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright

#4
Jun 18, 2009 1:15pm Jun 18, 2009 1:15pm

hanover
Joined Sep 2006 | Status: ... | 8,112 Posts

You haven't told me exactly what you want, so I can only try to guess.

The code below should sound an alert whenever the WPR indicator falls below -20 or rises above -80, from the previous bar to the current (newly forming) one. It should only sound once per bar, when the first tick of the new bar occurs.

Inserted Code

#property indicator_chart_window

//---- input parameters
extern int periodWPR = 14;
extern int HFEhigh1  = -20;
extern int HFElow2   = -80;
double WPR1, WPR2;

datetime prev_time;

//+------------------------------------------------------------------+
int init()  {
//+------------------------------------------------------------------+
  prev_time = -9999;
  return(0);
}

//+------------------------------------------------------------------+
int start()  {
//+------------------------------------------------------------------+
  if(prev_time != Time[0])  {
    SoundAlert();
    prev_time = Time[0];
  }
  return(0);
}

//+------------------------------------------------------------------+
int SoundAlert()  {

  WPR1 = iWPR(NULL,0,periodWPR,0);
  WPR2 = iWPR(NULL,0,periodWPR,1);
  Comment("WPR(",periodWPR,") = ",WPR1,"n","TYPE1SELL =",HFEhigh1,"n","TYPE3BUY =",HFElow2);
  if(WPR2 > HFEhigh1 && WPR1 < HFEhigh1)
    Alert("WPR >",HFEhigh1,"...TYPE1SELL ", Symbol());
  if(WPR2 < HFElow2 && WPR1 > HFElow2 )
    Alert("WPR <",HFElow2,"... TYPE3BUY ", Symbol());
  return(0);
}

#5
Jun 19, 2009 4:21am Jun 19, 2009 4:21am

bobomini
| Joined Jun 2006 | Status: Trader | 50 Posts

Hi Hanover,
Thanks a zillion........there seems to be some light in the horizon. I am indeed trying to make an EA that triggers only when 2 out of the 4 possible crossings of the WPR occur. These are the crossing of the -20 from above and the -80 from below (where 0 is on top and -100 is below).
Then I want the EA to both send an email and sound an alert once per the crossing (it should not alert more than once on the same bar). However, there are two different messages to be sent in the email: In the case of crossing the -20 from above, the heading will be "Time (Computer time) + SELL + SYMBOL" and the message will be: "The time is (Computer Time) + You may SELL + Symbol"

I compiled and loaded your code but MT4 kept removing it and saying ".....is an indicator and cannot be executed".

I just hope you can find the time to help again.
Having said that, any other competent coder can help as Honover has more than been kind........I feel guilty to have taken up so much of his time.
Thanks all.

#6
Jun 19, 2009 5:01am Jun 19, 2009 5:01am

hanover
Joined Sep 2006 | Status: ... | 8,112 Posts

OK, let's try again.

The indicator should alert (and now send e-mail) if/when the first tick of a newly emerging candle appears, that causes WPR to move below -20, after the value of the last completed candle caused a WPR value above -20. That should send the SELL alert/e-mail.

The indicator should alert (and now send e-mail) if/when the first tick of a newly emerging candle appears, that causes WPR to move above -80, after the value of the last completed candle caused a WPR value below -80. That should send the BUY alert/e-mail.

Only one alert/e-mail should be sent per candle. However, if you do any of (1) re-attach the indicator; (2) edit the indicator (e.g. press Ctrl-I etc); or (3) toggle between timeframes, MT4 will refresh the indicator, which means that the alert/e-mail could potentially sound again, if the next tick causes the criteria to once again be met. That is the way that MT4 operates.

I've written this as an indicator rather than an EA. Hence it should be loaded and compiled as an indicator. Unless you specifically require MT4 to place the orders with the broker, it's generally simpler (and more flexible, e.g. you can attach multiple indicators to the same chart, but only one EA) to operate with indicators rather than EAs. But it can be compiled as an EA if you wish - let me know, and I will modify the code accordingly.

Inserted Code

#property indicator_chart_window

//---- input parameters
extern int periodWPR = 14;
extern int HFEhigh1  = -20;
extern int HFElow2   = -80;
double WPR1, WPR2;

datetime prev_time;

//+------------------------------------------------------------------+
int init()  {
//+------------------------------------------------------------------+
  prev_time = -9999;
  return(0);
}

//+------------------------------------------------------------------+
int start()  {
//+------------------------------------------------------------------+
  if(prev_time != Time[0])  {       // This ensures that the alerts get sent only once per candle
    SoundAlert();
    prev_time = Time[0];
  }
  return(0);
}

//+------------------------------------------------------------------+
int SoundAlert()  {

  WPR1 = iWPR(NULL,0,periodWPR,0);      // This is the value of WPR on the newly emerging candle
  WPR2 = iWPR(NULL,0,periodWPR,1);      // This is the value of WPR on the previous (i.e. last completed) candle
  Comment("WPR(",periodWPR,") = ",WPR1,"n","TYPE1SELL =",HFEhigh1,"n","TYPE3BUY =",HFElow2);
  if(WPR2 > HFEhigh1 && WPR1 < HFEhigh1)  {   
    Alert("WPR >",HFEhigh1,"...TYPE1SELL ", Symbol());
    string mail_hdg = "Time: " + TimeToStr(TimeLocal(),TIME_SECONDS) + " SELL " + Symbol();
    string mail_msg = "The time is " + TimeToStr(TimeLocal(),TIME_SECONDS) + " You may SELL " + Symbol();
    SendMail(mail_hdg,mail_msg);
  }  
  if(WPR2 < HFElow2 && WPR1 > HFElow2)   {
    Alert("WPR <",HFElow2,"... TYPE3BUY ", Symbol());
    mail_hdg = "Time: " + TimeToStr(TimeLocal(),TIME_SECONDS) + " BUY " + Symbol();
    mail_msg = "The time is " + TimeToStr(TimeLocal(),TIME_SECONDS) + " You may BUY " + Symbol();
    SendMail(mail_hdg,mail_msg);
  }  
  return(0);
}

#7
Jun 19, 2009 5:07am Jun 19, 2009 5:07am

hanover
Joined Sep 2006 | Status: ... | 8,112 Posts

Sorry, forgot to mention: the previous post assumes that you have the e-mail facilities in MT4 set up correctly. Press Ctrl-O, select the Email tab, fill in the panel and use the Test button facility to ensure that an e-mail gets sent to your address. See my post here for more info and/or press F1 for the MT4 on-line help.

#8
Jun 19, 2009 7:02am Jun 19, 2009 7:02am

bobomini
| Joined Jun 2006 | Status: Trader | 50 Posts

Yes, I have indeed set up my email correctly and have tested it......it works.
There are however some aspect I want to clarify......
1- The alert can occur at any tick within the current bar .....once the the WPR crosses the designated value; but then only that once for that bar.

2- This part of your explanation: "after the value of the last completed candle caused a WPR value" may not be the best representation. The WPR being above or under (as the case may be) before the cross should not be down to only the last bar...it may have been in this state since the last "n" bars but the important thing is that it was in this current bar that it crossed the designated value.

Thank you so very much for this much time you have spent helping.
Cheers.

#9
Jun 19, 2009 4:10pm Jun 19, 2009 4:10pm

hanover
Joined Sep 2006 | Status: ... | 8,112 Posts

Sorry, I assumed from the code that you originally posted that you wanted to compare the current bar's WPR value with the previous bar's.

Try the code below.

This will now compare the WPR value from once price tick to the next, and if it falls from above to below -20, or rises from below to above -80, will sound/e-mail the alert, but (assuming I understand you correctly) only one alert will be sent per bar (on the timeframe to which the indicator is attached).

I can't test this, my broker has shut down for the weekend. Please post again if it doesn't work properly.

Inserted Code

#property indicator_chart_window

//---- input parameters
extern int periodWPR = 14;
extern int HFEhigh1  = -20;
extern int HFElow2   = -80;
double WPR1, WPR2;

datetime last_alert;

//+------------------------------------------------------------------+
int init()  {
//+------------------------------------------------------------------+
  last_alert = -9999;
  WPR1 = -9999;
  WPR2 = -9999;
  return(0);
}

//+------------------------------------------------------------------+
int start()  {
//+------------------------------------------------------------------+
  WPR2 = WPR1;                          // Value of WPR on the previous tick
  WPR1 = iWPR(NULL,0,periodWPR,0);      // Value of WPR on the lastest tick
  if(WPR2 >= HFEhigh1 && WPR1 < HFEhigh1 && last_alert != Time[0])  {   
    Alert("WPR >",HFEhigh1,"...TYPE1SELL ", Symbol());
    string mail_hdg = "Time: " + TimeToStr(TimeLocal(),TIME_SECONDS) + " SELL " + Symbol();
    string mail_msg = "The time is " + TimeToStr(TimeLocal(),TIME_SECONDS) + " You may SELL " + Symbol();
    SendMail(mail_hdg,mail_msg);
    last_alert = Time[0];
  }
  if(WPR2 <= HFElow2 && WPR1 > HFElow2 && last_alert != Time[0])   {
    Alert("WPR <",HFElow2,"... TYPE3BUY ", Symbol());
    mail_hdg = "Time: " + TimeToStr(TimeLocal(),TIME_SECONDS) + " BUY " + Symbol();
    mail_msg = "The time is " + TimeToStr(TimeLocal(),TIME_SECONDS) + " You may BUY " + Symbol();
    SendMail(mail_hdg,mail_msg);
    last_alert = Time[0];
  }  
  return(0);
}

#10
Jun 19, 2009 4:22pm Jun 19, 2009 4:22pm

hanover
Joined Sep 2006 | Status: ... | 8,112 Posts

Just re-read your explanation in post #8 and I now think that the code in post #6 will meet your requirement. If WPR has been in the upper/lower areas for multiple bars, and then crosses into the middle area on any tick in the current bar, then the previous bar's closing WPR value would necessarily be outside the middle area, and then the alert would be sent immediately a tick on the currently forming candle causes WPR to move back into the middle area.

Anyway, I leave it to you to test both versions (#6, #9). Both versions should allow only a maximum of one alert per bar.

#11
Jun 22, 2009 1:01am Jun 22, 2009 1:01am

bobomini
| Joined Jun 2006 | Status: Trader | 50 Posts

Quoting hanover

Disliked

Just re-read your explanation in post #8 and I now think that the code in post #6 will meet your requirement. If WPR has been in the upper/lower areas for multiple bars, and then crosses into the middle area on any tick in the current bar, then the previous bar's closing WPR value would necessarily be outside the middle area, and then the alert would be sent immediately a tick on the currently forming candle causes WPR to move back into the middle area.

Anyway, I leave it to you to test both versions (#6, #9). Both versions should allow only a...

Ignored

I will be testing the post 9 version today.....I will report back tommorrow.
Thanks.

#12
Last Post: Jun 23, 2009 7:22am Jun 23, 2009 7:22am

bobomini
| Joined Jun 2006 | Status: Trader | 50 Posts

Hi Hanover,
Thanks a zillion again. It is all working fine now.
Thanks indeed.

Platform Tech
/
Compilation errors and warnings
Reply to Thread

0 traders viewing now

Options

Similar Threads

Compilation errors and warnings