Request for modification of zig zag indicator. | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Non repaint zig zag modification 10 replies

Indicator Request Zig Zag with volume 6 replies

I Have Zig Zag Non Repaint Indicator!! A Programmer Needed To Optimize It! 25 replies

Detecting entry point with Zig Zag indicator? 1 reply

Zig and Zag - anyone tried this indicator? 5 replies

Attachments: Request for modification of zig zag indicator.
Exit Attachments

Request for modification of zig zag indicator.

  • #1
  • First Post: Jun 16, 2009 1:17am Jun 16, 2009 1:17am
Thank You for taking your time out for checking out my request.

I have attached the mql of the normal zig zag indicator that comes with metatrader.

I needed a couple of modifications with this piece of code.



Details of the two images attached:-
zig zag 1 - I have attached the zig zag indicator into the chart here.

zig zag 2 - The indicator draws the line but I needed some text and values printed on it.

As you can clearly see if the swing high was higher than the previous swing high I have typed HH meaning Higher High and the value of the swing high.

LL - Lower Low
HL - Higher Low
SH - Same High
SL - Same Low

Can any of you expert programmers here please modify the code for me so that the swing highs and lows and the corresponding values automatically show up as soon as the indicator is attached.?

Cheers
D
Attached Image(s) (click to enlarge)
Click to Enlarge Name: zig zag 1.gif Size: 19 KB
Click to Enlarge Name: zig zag 2.gif Size: 19 KB
  • #2
  • Jun 16, 2009 2:54am Jun 16, 2009 2:54am
"Modification" suggests there's something given to modify. you've not given that "something" yet.

post the zig zag indicator's codes first.
Programming for a better future.
  • #3
  • Jun 16, 2009 3:04am Jun 16, 2009 3:04am
Oops.... :-)

I have attached the zigzag indicator with this post.
Attached File(s)
File Type: mq4 ZigZag.mq4   6 KB | 1,143 downloads
  • #4
  • Jun 16, 2009 12:13pm Jun 16, 2009 12:13pm
here. not sure if it'll work though.
Attached File(s)
File Type: mq4 ZigZag_wLabel.mq4   9 KB | 1,774 downloads
Programming for a better future.
  • #5
  • Edited 12:38pm Jun 16, 2009 12:35pm | Edited 12:38pm
Quoting Zen_Leow
here. not sure if it'll work though.

Thank You Zen,

It works but when the same high happens it shows LH where as it must show SH.

And the same problem with "Same Low"

Cheers
D
Attached Image(s) (click to enlarge)
Click to Enlarge Name: samehighproblem.gif Size: 14 KB
Click to Enlarge Name: samelowproblem.gif Size: 11 KB
  • #6
  • Jun 16, 2009 10:43pm Jun 16, 2009 10:43pm
fixed it.... that was a simple correction :-)
PHP Code
//+------------------------------------------------------------------+
//|                                                       Zigzag.mq4 |
//|                 Copyright © 2005-2007, MetaQuotes Software Corp. |
//|                                       http://www.metaquotes.net/ |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2007, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net/"

#property indicator_chart_window
#property indicator_buffers 1
#property indicator_color1 Black
//---- indicator parameters
extern int ExtDepth=2;
extern int ExtDeviation=2;
extern int ExtBackstep=1;
extern color LabelColor = Blue;
extern int Labeldistance = 30;
//---- indicator buffers
double ZigzagBuffer[];
double HighMapBuffer[];
double LowMapBuffer[];
int level=3; // recounting's depth 
bool downloadhistory=false;

int PipFactor = 1;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
   // Cater for fractional pips
   if (Digits == 3 || Digits == 5)
   {
      PipFactor = 10;
   }
   ObjectsDeleteAll(0,OBJ_TEXT);
   IndicatorBuffers(3);
//---- drawing settings
   SetIndexStyle(0,DRAW_SECTION);
//---- indicator buffers mapping
   SetIndexBuffer(0,ZigzagBuffer);
   SetIndexBuffer(1,HighMapBuffer);
   SetIndexBuffer(2,LowMapBuffer);
   SetIndexEmptyValue(0,0.0);

//---- indicator short name
   IndicatorShortName("ZigZag("+ExtDepth+","+ExtDeviation+","+ExtBackstep+")");
//---- initialization done
   return(0);
  }
  
  int deinit()
  {
    ObjectsDeleteAll(0,OBJ_TEXT);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
int start()
  {
   int i, counted_bars = IndicatorCounted();
   int limit,counterZ,whatlookfor;
   int shift,back,lasthighpos,lastlowpos;
   double val,res;
   double curlow,curhigh,lasthigh,lastlow;

   if (counted_bars==0 && downloadhistory) // history was downloaded
     {
      ArrayInitialize(ZigzagBuffer,0.0);
      ArrayInitialize(HighMapBuffer,0.0);
      ArrayInitialize(LowMapBuffer,0.0);
     }
   if (counted_bars==0) 
     {
      limit=Bars-ExtDepth;
      downloadhistory=true;
     }
   if (counted_bars>0) 
     {
      while (counterZ<level && i<100)
        {
         res=ZigzagBuffer[i];
         if (res!=0) counterZ++;
         i++;
        }
      i--;
      limit=i;
      if (LowMapBuffer[i]!=0) 
        {
         curlow=LowMapBuffer[i];
         whatlookfor=1;
        }
      else
        {
         curhigh=HighMapBuffer[i];
         whatlookfor=-1;
        }
      for (i=limit-1;i>=0;i--)  
        {
         ZigzagBuffer[i]=0.0;  
         LowMapBuffer[i]=0.0;
         HighMapBuffer[i]=0.0;
        }
     }
      
   for(shift=limit; shift>=0; shift--)
     {
      val=Low[iLowest(NULL,0,MODE_LOW,ExtDepth,shift)];
      if(val==lastlow) val=0.0;
      else 
        { 
         lastlow=val; 
         if((Low[shift]-val)>(ExtDeviation*Point)) val=0.0;
         else
           {
            for(back=1; back<=ExtBackstep; back++)
              {
               res=LowMapBuffer[shift+back];
               if((res!=0)&&(res>val)) LowMapBuffer[shift+back]=0.0; 
              }
           }
        } 
      if (Low[shift]==val) LowMapBuffer[shift]=val; else LowMapBuffer[shift]=0.0;
      //--- high
      val=High[iHighest(NULL,0,MODE_HIGH,ExtDepth,shift)];
      if(val==lasthigh) val=0.0;
      else 
        {
         lasthigh=val;
         if((val-High[shift])>(ExtDeviation*Point)) val=0.0;
         else
           {
            for(back=1; back<=ExtBackstep; back++)
              {
               res=HighMapBuffer[shift+back];
               if((res!=0)&&(res<val)) HighMapBuffer[shift+back]=0.0; 
              } 
           }
        }
      if (High[shift]==val) HighMapBuffer[shift]=val; else HighMapBuffer[shift]=0.0;
     }

   // final cutting 
   if (whatlookfor==0)
     {
      lastlow=0;
      lasthigh=0;  
     }
   else
     {
      lastlow=curlow;
      lasthigh=curhigh;
     }
   for (shift=limit;shift>=0;shift--)
     {
      res=0.0;
      switch(whatlookfor)
        {
         case 0: // look for peak or lawn 
            if (lastlow==0 && lasthigh==0)
              {
               if (HighMapBuffer[shift]!=0)
                 {
                  lasthigh=High[shift];
                  lasthighpos=shift;
                  whatlookfor=-1;
                  ZigzagBuffer[shift]=lasthigh;
                  DrawHighLabel(shift);
                  res=1;
                 }
               if (LowMapBuffer[shift]!=0)
                 {
                  lastlow=Low[shift];
                  lastlowpos=shift;
                  whatlookfor=1;
                  ZigzagBuffer[shift]=lastlow;
                  DrawLowLabel(shift);
                  res=1;
                 }
              }
             break;  
         case 1: // look for peak
            if (LowMapBuffer[shift]!=0.0 && LowMapBuffer[shift]<lastlow && HighMapBuffer[shift]==0.0)
              {
               ZigzagBuffer[lastlowpos]=0.0;
               RemoveLabel(lastlowpos);
               lastlowpos=shift;
               lastlow=LowMapBuffer[shift];
               ZigzagBuffer[shift]=lastlow;
               DrawLowLabel(shift);
               res=1;
              }
            if (HighMapBuffer[shift]!=0.0 && LowMapBuffer[shift]==0.0)
              {
               lasthigh=HighMapBuffer[shift];
               lasthighpos=shift;
               ZigzagBuffer[shift]=lasthigh;
               DrawHighLabel(shift);
               whatlookfor=-1;
               res=1;
              }   
            break;               
         case -1: // look for lawn
            if (HighMapBuffer[shift]!=0.0 && HighMapBuffer[shift]>lasthigh && LowMapBuffer[shift]==0.0)
              {
               ZigzagBuffer[lasthighpos]=0.0;
               RemoveLabel(lasthighpos);
               lasthighpos=shift;
               lasthigh=HighMapBuffer[shift];
               ZigzagBuffer[shift]=lasthigh;
               DrawHighLabel(shift);
               res=1;
              }
            if (LowMapBuffer[shift]!=0.0 && HighMapBuffer[shift]==0.0)
              {
               lastlow=LowMapBuffer[shift];
               lastlowpos=shift;
               ZigzagBuffer[shift]=lastlow;
               DrawLowLabel(shift);
               whatlookfor=1;
               res=1;
              }   
            break;               
         default: return; 
        }
     }

   return(0);
  }
  
void DrawHighLabel(int shift)
{
   string status = "";
   double currentHigh = HighMapBuffer[shift];
   double previousHigh;
   // find the previous high
   for (int i=shift+1; i<shift+1000; i++)
   {
      if (HighMapBuffer[i] != 0 && ZigzagBuffer[i] != 0)
      {
         previousHigh = HighMapBuffer[i];
         break;
      }
   }
   if (currentHigh > previousHigh)
   {
     // status = "HH : "+DoubleToStr(currentHigh,Digits);
      status = "HH";
   }
   else
   if (currentHigh == previousHigh)
   {
     // status = "SH : "+DoubleToStr(currentHigh,Digits);
      status = "SH";
   }
   else
   {
      //status = "LH : "+DoubleToStr(currentHigh,Digits);
      status = "LH";
   }
   double position = HighMapBuffer[shift] + (Labeldistance * Point * PipFactor);
   ObjectCreate( "statusLabel"+Time[shift], OBJ_TEXT, 0, Time[shift], position);
   ObjectSetText("statusLabel"+Time[shift], status, 10, "Arial", LabelColor);
}

void DrawLowLabel(int shift)
{
   string status = "";
   double currentLow = LowMapBuffer[shift];
   double previousLow;
   // find the previous Low
   for (int i=shift+1; i<shift+1000; i++)
   {
      if (LowMapBuffer[i] != 0 && ZigzagBuffer[i] != 0)
      {
         previousLow = LowMapBuffer[i];
         break;
      }
   }
   if (currentLow > previousLow)
   {
      //status = "HL : "+DoubleToStr(currentLow,Digits);
      status = "HL";
   }
   else
   if (currentLow == previousLow)
   {
      //status = "SL : "+DoubleToStr(currentLow,Digits);
      status = "SL";
   }
   else
   {
      //status = "LL : "+DoubleToStr(currentLow,Digits);
      status = "LL";
   }
   double position = LowMapBuffer[shift] - (Labeldistance/2 * Point * PipFactor);
   ObjectCreate( "statusLabel"+Time[shift], OBJ_TEXT, 0, Time[shift], position);
   ObjectSetText("statusLabel"+Time[shift], status, 10, "Arial", LabelColor);
}


void RemoveLabel(int shift)
{
   ObjectDelete("statusLabel"+Time[shift]);
}
//+------------------------------------------------------------------+
  • #7
  • Last Post: Jun 17, 2009 10:05am Jun 17, 2009 10:05am
that fix actually won't work 100% because of the way the code works in the earlier portions. but since its enough for you, then I don't need to probe further. =)
Programming for a better future.
0 traders viewing now