Trying to make indicator that puts comment on chart, help!

Hello everyone,

I am trying to code a small indicator in which if Price > SMA30 > SMA50 > SMA100, then a small comment on the upper left corner shows as TRADEABLE. If not, it shows as NOT TRADEABLE.

Funnily enough, even though I think everything is properly coded, only the NOT TRADEABLE message appears despite the conditions being met.

I would very greatly appreciate if anyone could have a quick look at this because I am just going nuts here. I cannot figure out whether the !#%#@'ing bug is.

Thank you in advance

Following I copy/paste the code:

--------------------------

//+------------------------------------------------------------------+
//| Trend Filter.mq4 |
//| Copyright 2005, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright 2005, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"

#property indicator_chart_window



//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();

//PFX MAs variables definition for 30 minutes chart
double a30=iMA(NULL,PERIOD_M30,30,0,MODE_SMA,PRICE_CLOSE,0);
double b30=iMA(NULL,PERIOD_M30,50,0,MODE_SMA,PRICE_CLOSE,0);
double c30=iMA(NULL,PERIOD_M30,100,0,MODE_SMA,PRICE_CLOSE,0);
double p=PRICE_CLOSE;

//PFX MAs variables definition for Hourly chart
double a60=iMA(NULL,PERIOD_H1,30,0,MODE_SMA,PRICE_CLOSE,0);
double b60=iMA(NULL,PERIOD_H1,50,0,MODE_SMA,PRICE_CLOSE,0);
double c60=iMA(NULL,PERIOD_H1,100,0,MODE_SMA,PRICE_CLOSE,0);

//PFX MAs variables definition for 4H chart
double a240=iMA(NULL,PERIOD_H4,30,0,MODE_SMA,PRICE_CLOSE,0);
double b240=iMA(NULL,PERIOD_H4,50,0,MODE_SMA,PRICE_CLOSE,0);
double c240=iMA(NULL,PERIOD_H4,100,0,MODE_SMA,PRICE_CLOSE,0);

//PFX MAs variables definition for Daily chart
double aDaily=iMA(NULL,PERIOD_D1,30,0,MODE_SMA,PRICE_CLOSE,0);
double bDaily=iMA(NULL,PERIOD_D1,50,0,MODE_SMA,PRICE_CLOSE,0);
double cDaily=iMA(NULL,PERIOD_D1,100,0,MODE_SMA,PRICE_CLOSE,0);


string Filter30 = "not tradeable";
if(a30>b30 && b30>c30 && p>c30) Filter30="TRADEABLE";
if(a30<b30 && b30<c30 && p<c30) Filter30="TRADEABLE";



Comment("30 minutes chart is ", Filter30);


//----

//----
return(0);
}
//+------------------------------------------------------------------+

I'm not a coder, but I changed it like this and it worked


//+------------------------------------------------------------------+
//| Trend Filter.mq4 |
//| Copyright 2005, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright 2005, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"
#property indicator_chart_window
string Filter30;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();
//PFX MAs variables definition for 30 minutes chart
double a30=iMA(NULL,PERIOD_M30,30,0,MODE_SMA,PRICE_CLOSE, 0);
double b30=iMA(NULL,PERIOD_M30,50,0,MODE_SMA,PRICE_CLOSE, 0);
double c30=iMA(NULL,PERIOD_M30,100,0,MODE_SMA,PRICE_CLOSE ,0);
double p=PRICE_CLOSE;
//PFX MAs variables definition for Hourly chart
double a60=iMA(NULL,PERIOD_H1,30,0,MODE_SMA,PRICE_CLOSE,0 );
double b60=iMA(NULL,PERIOD_H1,50,0,MODE_SMA,PRICE_CLOSE,0 );
double c60=iMA(NULL,PERIOD_H1,100,0,MODE_SMA,PRICE_CLOSE, 0);
//PFX MAs variables definition for 4H chart
double a240=iMA(NULL,PERIOD_H4,30,0,MODE_SMA,PRICE_CLOSE, 0);
double b240=iMA(NULL,PERIOD_H4,50,0,MODE_SMA,PRICE_CLOSE, 0);
double c240=iMA(NULL,PERIOD_H4,100,0,MODE_SMA,PRICE_CLOSE ,0);
//PFX MAs variables definition for Daily chart
double aDaily=iMA(NULL,PERIOD_D1,30,0,MODE_SMA,PRICE_CLOSE,0);
double bDaily=iMA(NULL,PERIOD_D1,50,0,MODE_SMA,PRICE_CLOSE,0);
double cDaily=iMA(NULL,PERIOD_D1,100,0,MODE_SMA,PRICE_CLOSE,0);

if(a30>b30 && b30>c30 && p>c30) Filter30="TRADEABLE"; else Filter30 = "not tradeable";
if(a30<b30 && b30<c30 && p<c30) Filter30="TRADEABLE"; else Filter30 = "not tradeable";

Comment("30 minutes chart is ", Filter30);

//----
//----
return(0);
}

I don't think you can have "p=PRICE_CLOSE".
"PRICE_CLOSE" does not have a value by its own, it is only used to call indiactors based on certain calculation (CLOSE, OPEN...).

use instead "p=Ask" (or "Bid", Close[0], Open[0]...)

not yet sure if this is the only mistake there.

Thank you deeply for your help guys. I have updated your suggestions, but still the comment would invariable show as NOT TRADEABLE for some reason.

The problem is in the following lines:


----------------------
if(a30>b30 && b30>c30 && p>c30) Filter30="TRADEABLE"; else Filter30 = "not tradeable";
if(a30<b30 && b30<c30 && p<c30) Filter30="TRADEABLE"; else Filter30 = "not tradeable";

Comment("30 minutes chart is ", Filter30);
---------------------

Any other ideas?

Like I said, I'm not a coder, but when I tested this on the GBP/JPY the 30 minute showed not tradeable because it didn't fit your porofile, when I changed the code to look at the 15min, which did fit your profile it worked.

Who knows, maybe I just got lucky

Thank you guys I made it work WOOHOOO

As soon as Im done with it, I will post it in case you're interested. I plan on have it set up for 30mins, hourly, 4H and daily chart, and comments attached to the upper left corner so, with one quick look at the chart, you can see if a pair is trending in any time frame as per the 30SMA, 50SMA and 100SMA criteria.

Cheers

Can this be made to display other messages? I mean, I could do with some sort of sarcastic put down when I make a stupid trade. Just a thought...

LOL, yea i made this one you can download awhile ago for a spoof, here is the screen shot. It shows the time remaining until the current candle close and you can change the text to whatever.

http://accrete.com/fx-posts/sillyzillions.gif

Cheers,
Thom

LOL - That is exactly the thing I need.

Cool...that's what my siggy file (and one of the major-fun-goals in my personality/life) is all about!