Joined Jun 2008
|
Status: Programming for a better future.
|652 Posts
the codes and comments in this indicator are conflicting.
Anyway, if it makes you feel better. Yellow is only used here as an underlying color. if the indicator cannot decide if this part of the line should be green or red, then it won't paint green or red, thereby yellow is seen.
No point trying to modify this indicator if the coding is flawed.
Just don't use it.
do you think code in this ind. flawed? if so, code is very simple - what is the flaw and how it should be wright?
thank you
Ignored
huh? what do you mean "code is very simple"? how does that relate to code logic being flawed?
the point of coloring the MA line is so that if line is going up, the line should be green, if line is going down, it should be red. the only time when the line should be yellow is when it is horizontal (which should be extremely rare). since there's so much yellow, obviously the programmer fail to realise it takes 2 points to draw a line. It'll take a while to explain this concept so I'm not going to bother.
This code file is poorly indented, the comments were conflicting with the actual codes (commented yellow when its actually tagged to red, vice versa).
On a sidenote, even if he/she has factored in two points necessary to draw a colored line, there are limitations in MT4 that can't give it a 100% correct drawing. In this case, red seems to have priority since it's the last buffer to be drawn... again if you want me to explain this limitation, it's going to take a while and I don't think anyone would be interested.
Reference the amended codes in the attachment and you'll see what I mean. Good luck
Joined Jun 2008
|
Status: Programming for a better future.
|652 Posts
sign... If you read and understood the codes, you probably won't like it either.
Anyway, you're saying yellow means change direction, then shouldn't one be expecting green-yellow-red-yellow-green-yellow-red kinda sequence?
in your example screenshots, you can clearly see a red-yellow-red sequence. Hence, the indicator is wrong.
I also said in my earlier post that no one will be able to get a 100% correct drawing when it comes to directional changes, that includes me and my indicator.
Btw, my indicator is coded in such a way you won't see yellow at all. either red or green. I believe that's even simpler.
it's ok... just use what you like. It's really too troublesome for me to explain clearly why the indicator posted by threadstarter isn't working the way it should be.
Anyway, you're saying yellow means change direction, then shouldn't one be expecting green-yellow-red-yellow-green-yellow-red kinda sequence?
in your example screenshots, you can clearly see a red-yellow-red sequence.
Hence, the indicator is wrong.
Ignored
no. yellow bar - change of direction; bar after yellow in same direction as yellow - opposite color of bar, previous to yellow (green-yellow-red)
if 2 yellow bars- dir changed twice - same direction (as previous to yellow: red-yellow-yellow-red), etc so red yellow-red - doesn't make sense (and you can't see it on the picture)
therefore ma color (not amended) - absolutely correct
btw, author, fx sniper, is a genius (and he did knew how many points take to build line); his few lines of code - flawless, - it shows exactly what it suppose and intended to, and - Correctly, without major flaws of ma amended;
Hence, ma amended - basically spoiled sniper's ind; author of amendments fail to realise logic and principles of work org. ind; added code doesnt shows correct colors just maid it basically major repainter, therefore - useless (and waste of code)
I also said in my earlier post that no one will be able to get a 100% correct drawing when it comes to directional changes, that includes me and my indicator.
...
.
Ignored
no one? or just you? at least you can realise which ind is wrong (flawed) - your, amended or fx sniper's? does ma in color lying (like yours)?
