Generic Breakout V5 | Page 4 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Generic Breakout Version 7 [TD] 70 replies

Generic Breakout EA 7 16 replies

Generic Finite Impulse Response Filter - Ever wanted to design your own MA? 16 replies

Generic Breakout Version 6 [TD] 18 replies

MT4 a generic platform? 3 replies

Attachments: Generic Breakout V5
Exit Attachments

Generic Breakout V5

  • #61
  • May 12, 2009 2:34pm May 12, 2009 2:34pm
Quoting kore
Hi RR -- nice work... I was backtesting and found that no long positions were being opened, with an error 130 (invalid stop level) in the journal. Upon further inspection I found that the problem was with the %range stop loss, specifically dividing the %range by 100 (an int) instead of 100.0 (a float).

The attached version fixes this bug, it didn't seem to affect the TP levels or Short orders, but I fixed it in all 4 locations anyway.

There was another bug on line 353, was...
I appreciate the effort kore,

Line 353: Should be greater than. (>) Remember, if the EA is given multiple stoploss options, it takes the tightest one. On the buy side, if the new stoploss is greater than the current stoploss, then that stoploss is tighter.

The 100 vs. 100.0, what's the difference? It wasn't a variable.

Lines 352, 356, 393, 397: The levels need to be compared with the existing stoploss or takeprofit, you are right that for each of those lines, that value is 0. I put them in there so I can add in more stoploss/takeprofit features in the future should there be more feature requests. You are right in that that specific snippet of code is not necessary for this current iteration.
  • #62
  • May 12, 2009 2:58pm May 12, 2009 2:58pm
Quoting Ronald Raygun
Line 353: Should be greater than. (>) Remember, if the EA is given multiple stoploss options, it takes the tightest one. On the buy side, if the new stoploss is greater than the current stoploss, then that stoploss is tighter.
OK. I got confused because you used the same (>) for both buy and sell SLs, so on buy orders you are using the tightest SL, and on sell orders the opposite... One or the other probably needs to be switched around. Or else I am not thinking straight.

Quoting Ronald Raygun
The 100 vs. 100.0, what's the difference? It wasn't a variable.
Seems as though MT4 casts the result as an int when dividing by an int. In my case, the SL on buy orders was always being calculated as (Ask - 0) isntead of (Ask - 0.0126), which threw errors and prevented any buy orders from being opened. Changing the divisor to 100.0 gives the correct value. I don't know exactly why, but it fixed the problem I was having.

Since "100" is not a typed variable, MQ4 has to guess whether it is an int or a float, and apparently will cast the division result accordingly... afaict.

Quoting Ronald Raygun
Lines 352, 356, 393, 397: The levels need to be compared with the existing stoploss or takeprofit, you are right that for each of those lines, that value is 0. I put them in there so I can add in more stoploss/takeprofit features in the future should there be more feature requests. You are right in that that specific snippet of code is not necessary for this current iteration.
Cool, I just took them out in the course of debugging to make it easier to see what was going on...
  • #63
  • May 12, 2009 3:27pm May 12, 2009 3:27pm
Quoting kore
OK. I got confused because you used the same (>) for both buy and sell SLs, so on buy orders you are using the tightest SL, and on sell orders the opposite... One or the other probably needs to be switched around. Or else I am not thinking straight.

StopLossLevel and TakeProfitLevel are prices, thus:

When Buying

 

  1. The tightest stoploss is the StopLossLevel with the highest price
  2. The widest takeprofit is the TakeProfitLevel with the highest price

When Selling

 

  1. The tightest stoploss is the StopLossLevel with the lowest price
  2. The widest takeprofit is the TakeProfitLevel with the lowest price.


As for the float value, if it's working for one side, but not the other, maybe something else is causing the problem.

  • #64
  • May 12, 2009 3:44pm May 12, 2009 3:44pm
Quoting Ronald Raygun
StopLossLevel and TakeProfitLevel are prices, thus:

When Buying

 

  1. The tightest stoploss is the StopLossLevel with the highest price
  2. The widest takeprofit is the TakeProfitLevel with the highest price

When Selling

 

  1. The tightest stoploss is the StopLossLevel with the lowest price
  2. The widest takeprofit is the TakeProfitLevel with the lowest price.

I agree, thus I was confused by the line (in the sell order logic)

Inserted Code
if (UseStopLoss && UseFixedStopLoss && Bid + (StopLoss * Point) > StopLossLevel) StopLossLevel = Bid + (StopLoss * Point);
Which will not result in the tightest stop loss: it will use the fixed SL if it is HIGHER (for both buy and sell orders, in your current version).

This is not a big deal, just inconsistent.

Quoting Ronald Raygun
As for the float value, if it's working for one side, but not the other, maybe something else is causing the problem.
Maybe. Any idea what? It works fine for me with 100.0 instead of 100...

Thanks for sharing this great EA. I am working on tweaking it for a couple of different breakout strategies...
  • #65
  • May 12, 2009 4:34pm May 12, 2009 4:34pm
I've gone through the code and made sure there are no inconsistencies here. And Kore, I appreciate the effort you are putting into tweaking this EA. I would love it if you also shared your work here on ForexFactory. I suggest either changing the name of your resulting EAs or by adding something to the end of "Generic Breakout Version 5" to prevent confusion.
Attached File(s)
File Type: mq4 Generic Breakout Version 5.mq4   17 KB | 643 downloads
  • #66
  • May 13, 2009 3:03am May 13, 2009 3:03am
Quoting Ronald Raygun
I've gone through the code and made sure there are no inconsistencies here. And Kore, I appreciate the effort you are putting into tweaking this EA. I would love it if you also shared your work here on ForexFactory. I suggest either changing the name of your resulting EAs or by adding something to the end of "Generic Breakout Version 5" to prevent confusion.

Hi,

I put the EA to test this morning. It does not seem to accept 0 GMT as starting hour for the range. When I put 0 it chooses 1 GMT instead. All hours are accepted except 0, why could this be? I tried with 24 GMT, but then the EA freezes. Also, I can't get the minutes to work. E.g. 0:10 GMT makes the EA freeze.

Regards

Archie
  • #67
  • May 13, 2009 7:48am May 13, 2009 7:48am
Quoting Archie
Hi,

I put the EA to test this morning. It does not seem to accept 0 GMT as starting hour for the range. When I put 0 it chooses 1 GMT instead. All hours are accepted except 0, why could this be? I tried with 24 GMT, but then the EA freezes. Also, I can't get the minutes to work. E.g. 0:10 GMT makes the EA freeze.

Regards

Archie
Where does the EA draw the lines?
  • #68
  • May 13, 2009 7:01pm May 13, 2009 7:01pm
Quoting Ronald Raygun
I've gone through the code and made sure there are no inconsistencies here. And Kore, I appreciate the effort you are putting into tweaking this EA. I would love it if you also shared your work here on ForexFactory. I suggest either changing the name of your resulting EAs or by adding something to the end of "Generic Breakout Version 5" to prevent confusion.
mmmm - lost the 1st post of this try again.

Hi Ronald,
I have latest version loaded and running on IBFX mini.
Have noticed a few bits with the times, if I use like 15 or 45 for minutes, it doesnt show in the H1 chart and shows in the M15 chart 1 bar later.

While my server time was 22:35 +/- I put in for end hours of 22 & end minutes 0. The display eventually appeared on yesterdays bars.

If the first bar has the highest(or lowest) for the range, that figure doesnt get used in the UpperEntry(LowerEntry) or UpperRange(LowerRange) values.

Havent had a play with 24GMT or straddling it.

cheers scalpz
Target 2 : Stoploss in the green
  • #69
  • May 14, 2009 2:05am May 14, 2009 2:05am
Quoting Ronald Raygun
Where does the EA draw the lines?

It draws them at 01 and 06. I would like it to include 0 as well, but when I choose 0, the EA draws the line at 01, and when I choose 23 the EA draws the line at 23. How to include 0?

Regards

Archie
  • #70
  • May 14, 2009 2:44am May 14, 2009 2:44am
hello - I have 2 questions: 1. what has to be changes into the coded to let 'mastercandle' work on a 5 digit broker?
2. how can we define 'previous low' and 'previous high' to trade this break-out? do you have any idea?
THX
  • #71
  • May 14, 2009 4:55am May 14, 2009 4:55am
Hi again,

I set the range from 0 to 6 this morning and let the EA run. When time had passed 7, the EA had changed the range from 0 to 7. Why did this happen?

Archie
  • #72
  • May 14, 2009 5:54am May 14, 2009 5:54am
Quoting Archie
Hi again,

I set the range from 0 to 6 this morning and let the EA run. When time had passed 7, the EA had changed the range from 0 to 7. Why did this happen?

Archie
Hi Archie,
If this was on an H1 chart, it sounds similar to how I am seeing the displayed range shifted 1 bar to the right on my M15 charts.

cheers scalpz
Target 2 : Stoploss in the green
  • #73
  • May 14, 2009 9:17pm May 14, 2009 9:17pm
Hi Ron,
Great job on the master candle EA. I notice that if the EA is in a trade and it encounters another mastercandle, this new candle is ignored. Is there a way to include this second and third candle as indicated in the attached pic?
Cheers
CanuckCT
Attached Image (click to enlarge)
Click to Enlarge Name: 2009-05-14_2232EJ-MC.png Size: 37 KB
  • #74
  • May 14, 2009 9:18pm May 14, 2009 9:18pm
Also, is it possible to have the option to enter only one trade rather than two?
Cheers
CanuckCT
  • #75
  • May 14, 2009 11:16pm May 14, 2009 11:16pm
Quoting CanuckCT
Hi Ron,
Great job on the master candle EA. I notice that if the EA is in a trade and it encounters another mastercandle, this new candle is ignored. Is there a way to include this second and third candle as indicated in the attached pic?
Cheers
CanuckCT
Hi Canuck,
Missed this MasterCandle ea of Ronalds posted way back.
Have loaded it to see how it goes, are you able to explain what the RangeBreakShift vertical line is for?
Is there a thread with some background on what to expect after a master candle ? or what do you use it for, pairs & times etc.

I have it on IBFX demo, which is now 5 digit - unfortunately
and no Pending Orders in opposite trade direction - unfortunately.

Thanks once again Ronald, looks good, I'll see if I can break it

cheers scalpz
Target 2 : Stoploss in the green
  • #76
  • May 17, 2009 12:09am May 17, 2009 12:09am
Ronald,
First of all, i want to express my appreciation for the work done on the Generic EA.
I backtested them and found 2 issues.

1. The % risk is programed only as a % of the balance equity.It does not take into account the stop loss size.
2. Can't backtest broker which has extra digits eg Alpari. But is able to when backtested with FXDD which do not have extra digit.

Thank you again.
  • #77
  • May 17, 2009 5:49am May 17, 2009 5:49am
Quoting Ronald Raygun
Ok, new features added:
[list=1][*]Reworked the range-finding code. The current iteration does not necessarily work through midnight as I found out. This one should now work through midnight.[*]I added a TP based on percentage of range. A note on TPs: You can use multiple TPs and enable all the TP options. When presented with multiple TPs, the EA will use the larger TP.[*]I also added trade limiters. You can set limits based on total trades, long trades, and short trades. Set any of those to '0' to disable them. You can enable all 3 settings....

Hi Ronald,
Been spending the whole weekend trying to backtest your Generic EA.
I don't seems to get the trade limiter to work. When i set MaxtradesPerDay : 1 and both MaxLongs and MaxShorts : 1,
the number of trades triggered would sometimes be two per day.
I am trying only to trade one trade per day but it trades more than that even after setting the MaxTradesPerDay : 1.
And the other question relates to the Time Reset feature. What is its function?

Thank you and best regards
  • #78
  • May 17, 2009 8:00am May 17, 2009 8:00am
Ronald,
I forgot to mentioned that i used Kore's EA to backtest. All the issues were from Kore's EA.
I tried to backtest your latest EA but it just could not work. No data come out.
Regards
  • #79
  • May 17, 2009 8:58am May 17, 2009 8:58am
Nicole,

Risk is available equity.
Oh really? I'm able to backtest on FxPro, they're 5-digits.

MaxTradesPerDay is reset whenever the ResetTime is passed. What is the setting for your reset time?

Who is Kore?
What was the lot size?


In light of all the problems and big reports I've been getting, I've once again overhauled the EA, this time using Hanover's much simpler range-finding code.

 

  1. extern string Remark1 = "== Main Settings ==";
  2. extern int MagicNumber = 0;

    1. This is the Identifying Number an EA uses to determine which trades belong to it. Make sure this is different from other EAs you're using on the same terminal

  3. extern bool SignalsOnly = False;

    1. If set to true, the EA will only send signals (below) but not place trades.

  4. extern bool Alerts = False;

    1. This enables/disables the pop-up window type alert

  5. extern bool SignalMail = False;

    1. This enables/disables the e-mail function.

  6. extern bool PlaySounds = False;

    1. This enables/disables the sound. The EA will play the sound 'alert.wav'

  7. extern bool EachTickMode = True;

    1. If set to true, the EA will take trade signals immediately when they appear. If set to false, the EA will wait until the end of the bar to place a trade.

  8. extern double Lots = 0;

    1. Fixed lot size

  9. extern bool MoneyManagement = False;

    1. Enables/disables the Money-Management function

  10. extern int Risk = 0;

    1. Percent risk.

  11. extern int Slippage = 5;

    1. Maximum slippage allowed

  12. extern bool UseStopLoss = True;

    1. Enables/Disables Stoploss

  13. extern bool UsePercentageStopLoss = True;

    1. Enables/Disables the stoploss based on the percentage of the range

  14. extern int PercentofRangeSL = 50;

    1. Percent of the range used.

  15. extern bool UseFixedStopLoss = True;

    1. Enables/Disables the fixed stoploss

  16. extern int StopLoss = 100;

    1. Stoploss value in pips.

  17. extern bool UseTakeProfit = False;

    1. Enables/Disables TakeProfits

  18. extern bool UsePercentageTakeProfit = True;

    1. Enables/Disables the percentage of range used for takeprofit

  19. extern int PercentofRangeTP = 100;

    1. The percent of the range used for the takeprofit

  20. extern bool UseFixedTakeProfit = True;

    1. Enables/Disables the fixed takeprofit

  21. extern int TakeProfit = 60;

    1. TakeProfit value in pips

  22. extern bool UseTrailingStop = False;

    1. Enables/Disables the trailing stop

  23. extern int TrailingStop = 30;

    1. Trailing stop value in pips. Trailing stop only trails profit.

  24. extern bool MoveStopOnce = False;

    1. Enables/Disables the movestoponce function

  25. extern int MoveStopWhenPrice = 50;

    1. The trigger price to move the stop once

  26. extern int MoveStopTo = 1;

    1. The new value of the stoploss in pips relative to breakeven.
    2. In this case, when the trade hits 50 pips in profit, move the stoploss to breakeven + 1

  27. extern string Remark2 = "";
  28. extern string Remark3 = "== Breakout Settings ==";
  29. extern string StartTime = "00:00";

    1. StartTime for the range: Must be in "HH:MM" format

  30. extern string EndTime = "00:00";

    1. EndTime for the range: Must be in "HH:MM" format

  31. extern string ResetTime = "00:00";

    1. Time when the trade count is reset.

  32. extern int BreakoutBuffer = 10;

    1. The buffer outside the range to determine the long/short entry prices.

  33. extern bool UseMaxRange = False;

    1. Enables/Disables the maximum range allowed filter.

  34. extern int MaxRange = 100;

    1. Maximum range allowed in pips.

  35. extern int MaxTradesPerDay = 3;

    1. Maximum trades per day. Set to 0 to disable.

  36. extern int MaxLongTrades = 2;

    1. Maximum long trades allowed per day. Set to 0 to disable

  37. extern int MaxShortTrades = 2;

    1. Maximum short trades allowed per day. Set to 0 to disable


Notes:

 

  1. Whenever multiple stoploss options are presented to the EA, the EA will use the tightest stoploss option
  2. Whenever multiple takeprofit options are presented to the EA, the EA will use the widest takeprofit option
  3. MaxTradesPerDay, MaxLongTrades, and MaxShortTrades, will have their corresponding values reset at the reset time.

Attached File(s)
File Type: mq4 Generic Breakout Version 5.5.mq4   19 KB | 902 downloads
  • #80
  • May 17, 2009 2:50pm May 17, 2009 2:50pm
Hi Ronald

That's great help you are providing here! May I ask you to post an example of what specific settings one can put in to have some trades when backtesting the EA on any pair over a certain period? The problem is that when I run the EA in a strategy tester (I've changed the lot size from 0 to 1 in all three boxes, added start and end times, the pair is GBP/USD), it doesn't seem to generate any trades... I have to admit that I haven't had much MT4 backtesting experience so need some guidance... By the way, I was changing the settings by clicking on them in the "Expert properties" button.

Many thanks for your generous help!
0 traders viewing now