News Trading Function | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

Order-matching exchange function (trading between local traders) to avoid broker fees 0 replies

stop loss function and edit time function for Breakout EA 1 reply

If there is a trading platform with such function? 1 reply

News Function Filter 2 replies

News Trading Function

  • #1
  • First Post: Apr 11, 2007 11:51pm Apr 11, 2007 11:51pm
So here is the function that I have been using in a few of my EA's to disable trading before and after an announcement. . . it seemed to be working fine but now for some reason it always seems to return NewsTime == true. Can anyone take a look and tell me what is wrong.... Feel free to use it in your EA's as well. When it works right it really helps eliminate huge losses. it also allows you to change your strategy to one that works for the announcements.
PHP Code
 // ===================================== NEWS TIME =============================================================
bool NewsTime(){
    
    int MinUntil_EURUSD = iCustom("EURUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_EURUSD = iCustom("EURUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
    int MinUntil_USDJPY = iCustom("USDJPY", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_USDJPY = iCustom("USDJPY", 0, "FFCal_v05", true, true, false, true, true, 1, 1);

    int MinUntil_GBPUSD = iCustom("GBPUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_GBPUSD = iCustom("GBPUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
     int MinUntil_USDCHF = iCustom("USDCHF", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_USDCHF = iCustom("USDCHF", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
     int MinUntil_AUDUSD = iCustom("AUDUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_AUDUSD = iCustom("AUDUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
     int MinUntil_USDCAD = iCustom("USDCAD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_USDCAD = iCustom("USDCAD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);

     if ((MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) < 30){
         DisableTrading = true;
         Print(".....We have Less than 30 Minutes until the next news announcement, Trading is disabled");
          return(true);
          }
    if ((MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) < 10){
        Print(".....Closing our orders because its almost newstime");
        DisableTrading = true;
          KillLongs();
          KillShorts();
          }
    if ((MinSINCE_EURUSD||MinSINCE_USDJPY||MinSINCE_GBPUSD||MinSINCE_USDCHF||MinSINCE_AUDUSD||MinSINCE_USDCAD) < 30){
        DisableTrading = true;
        Print(".....It has been less than 30 minutes since the last News announcement, Trading is disabled");
          return(true);
          }
     
    else{
    Print(".....is NOT news time, returning FALSE");
    return(false);
    }
}
Thanks

Also is this the best way to kill the open orders ?

PHP Code

void KillLongs(){
        for (int i=OrdersTotal()-1;i>=0;i--){
            OrderSelect(i,SELECT_BY_POS);{
            if (OrderSymbol() == Symbol() && OrderMagicNumber() == (LongOneMagic||LongTwoMagic||LongThreeMagic||LongFourMagic)){
            OrderClose(OrderTicket(),OrderLots(),Bid,SLIPPAGE,White);
            Print ("Kill Longs");
            }
         }
   }
}

void KillShorts(){
        for (int i=OrdersTotal()-1;i>=0;i--) {
            OrderSelect(i,SELECT_BY_POS);{
            if (OrderSymbol() == Symbol() && OrderMagicNumber() == (ShortOneMagic||ShortTwoMagic||ShortThreeMagic||ShortFourMagic)){
            OrderClose(OrderTicket(),OrderLots(),Ask,SLIPPAGE,White);
            Print ("Kill Shorts");
            }
         }
   }
}
Keep it simple stoopid....
  • #2
  • Apr 13, 2007 2:30pm Apr 13, 2007 2:30pm
Nobody.... Getting this working properly will help everyones EA's
Keep it simple stoopid....
  • #3
  • Apr 13, 2007 2:58pm Apr 13, 2007 2:58pm
I'm sure there will be someone who will take action on this problem very soon

I'm not a big fan of EA, I like trade manually.

One thing I agree is that trading news can significally decrease profitability, so something like this what you mentioned above can prevent or decrease losses.

Happy Trading
  • #4
  • Apr 14, 2007 8:58am Apr 14, 2007 8:58am
where is the 'FFCal_v05.mq4' file?
  • #5
  • Apr 15, 2007 11:43pm Apr 15, 2007 11:43pm
  •  tesla
  • Joined Oct 2006 | Status: Friendly Neighborhood Programmer | 533 Posts
Sorry guys, I've been off the boards for a bit.

I took a quick look at this and here's what I found:

The indicator seems to return a zero in many cases for the "minutes until" and "minutes since" values. This doesn't seem to be an indication that there's a news release at that very moment but rather an indication that no relevant info was found for the symbol in question. The way you're using the indicator, a zero return value trips your function and you're almost always going to get a true result.

On a related note, the "minutes since" value returned by the indicator is no longer expressed as negative integers.
  • #6
  • Last Post: Apr 16, 2007 2:44am Apr 16, 2007 2:44am
Her is what i did to fix it..... eliminates the 0 problem requires a > 1 value... and sleeps through the event. Not best practice but it should work.

PHP Code
bool NewsTime(){
    
    int MinUntil_EURUSD = iCustom("EURUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_EURUSD = iCustom("EURUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
    int MinUntil_USDJPY = iCustom("USDJPY", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_USDJPY = iCustom("USDJPY", 0, "FFCal_v05", true, true, false, true, true, 1, 1);

    int MinUntil_GBPUSD = iCustom("GBPUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_GBPUSD = iCustom("GBPUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
     int MinUntil_USDCHF = iCustom("USDCHF", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_USDCHF = iCustom("USDCHF", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
     int MinUntil_AUDUSD = iCustom("AUDUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_AUDUSD = iCustom("AUDUSD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);
     
     int MinUntil_USDCAD = iCustom("USDCAD", 0, "FFCal_v05", true, true, false, true, true, 1, 0);
    int MinSINCE_USDCAD = iCustom("USDCAD", 0, "FFCal_v05", true, true, false, true, true, 1, 1);

     
     // To and From but filtering out the false 0 
     if ((MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) < 30 && (MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) > 2){
         DisableTrading = true;
         Print(".....We have Less than 30 Minutes until the next news announcement, Trading is disabled");
          return(true);
          }
    if ((MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) < 10 && (MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) > 2){
        Print(".....Closing our orders because its almost newstime");
        DisableTrading = true;
          KillLongs();
          KillShorts();
          return(true);
          }
    if ((MinSINCE_EURUSD||MinSINCE_USDJPY||MinSINCE_GBPUSD||MinSINCE_USDCHF||MinSINCE_AUDUSD||MinSINCE_USDCAD) < 30 && (MinSINCE_EURUSD||MinSINCE_USDJPY||MinSINCE_GBPUSD||MinSINCE_USDCHF||MinSINCE_AUDUSD||MinSINCE_USDCAD) > 2){
        DisableTrading = true;
        Print(".....It has been less than 30 minutes since the last News announcement, Trading is disabled");
          return(true);
          }
     
     // Sleeping through the News Event....
     if ((MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD) < 2 && (MinUntil_EURUSD||MinUntil_USDJPY||MinUntil_GBPUSD||MinUntil_USDCHF||MinUntil_AUDUSD||MinUntil_USDCAD)> 1){
        Sleep (480000);
        }
     
    else{
    return(false);
    }
}
Keep it simple stoopid....
0 traders viewing now