Fib. Reverse Engineered. | Page 19 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

ICCE. Bemac's Fib. Reverse Engineered 2,027 replies

Can a successful system be reverse engineered? 14 replies

Reversed Engineered Trading System 27 replies

Meta Trader .. fixeing fib when scrolling 2 replies

Short Term Trades and Fib 1 reply

Attachments: Fib. Reverse Engineered.
Exit Attachments

Fib. Reverse Engineered.

  • #361
  • Edited 10:31am May 8, 2009 9:39am | Edited 10:31am
I just went 3 Lots Long on Bemac losing his Experts Tab It's a right not a given you know

Quote
Do you have any ideas?
Sounds like you are having VLine alignment issues, maybe it's something specific with vlines. don't know maybe its an anchoring issue thats all i can think of. All you should need is one Vline point stored in a global then transpose all the rest. Take the point off one of the corners of the rectangle.

nb: I'd calculate the transpose using fib math ( take the nearest H/L difference to start ), whatever works best. There's probably lots of formulas you can apply to the spacing.
  • #362
  • May 8, 2009 9:59am May 8, 2009 9:59am
Quoting kd3726
I just went 3 Lots Long on Bemac losing his Experts Tab It's a right not a given you know
I'll Take that Trade.

Quoting kd3726
Sounds like you are having VLine alignment issues, maybe it's something specific with vlines. don't know maybe its an anchoring issue thats all i can think of. I'd say all of those vlines co-ordinates are going to have to be stored in an array and then retrieved and drawn.
Tech stuff I don't fully understand but I'm not sure how you could expect to Anchor a Vert Line @ 1:15 on a 30 min Chart?

Here's how I dealt with it in VTT Platform.

{Automatically Determine the ChartInterval And Allow for Weekends/Holidays}
FirstBar :=ValueWhen(1,Barnum=1,DayOfMonth()*1440)
+ValueWhen(1,Barnum=1,Hour()*60)
+ValueWhen(1,Barnum=1,Minute());
SecondBar:=ValueWhen(1,Barnum=2,DayOfMonth()*1440)
+ValueWhen(1,Barnum=2,Hour()*60)
+ValueWhen(1,Barnum=2,Minute());
ThirdBar :=ValueWhen(1,Barnum=3,DayOfMonth()*1440)
+ValueWhen(1,Barnum=3,Hour()*60)
+ValueWhen(1,Barnum=3,Minute());
FourthBar:=ValueWhen(1,Barnum=4,DayOfMonth()*1440)
+ValueWhen(1,Barnum=4,Hour()*60)
+ValueWhen(1,Barnum=4,Minute());
FifthBar :=ValueWhen(1,Barnum=5,DayOfMonth()*1440)
+ValueWhen(1,Barnum=5,Hour()*60)
+ValueWhen(1,Barnum=5,Minute());

Scnd_First:= IF(SecondBar-FirstBar < 0
, Abs(SecondBar - FirstBar )
, SecondBar - FirstBar );
Thrd_Scnd := IF(ThirdBar -SecondBar < 0
, Abs(ThirdBar - SecondBar)
, ThirdBar - SecondBar);
Frth_Thrd := IF(FourthBar-ThirdBar < 0
, Abs(FourthBar - ThirdBar )
, FourthBar - ThirdBar );
Ffth_Frth := IF(FifthBar -FourthBar < 0
, Abs(FifthBar - FourthBar)
, FifthBar - FourthBar);

{ChartInterval =}
ChartInt := IF(Barnum>=5
,MIN( Min(Scnd_First, Thrd_Scnd)
, Min(Frth_Thrd, Ffth_Frth ))
,Null);

hth.
  • #363
  • May 8, 2009 10:05am May 8, 2009 10:05am
now your unknowingly giving all the programmers a headache

Semi-seriously though, VTT the implementation of vlines may be completely different. there may be hidden gotchas.

Infact I'll go 3 Lots Long now on 'Hidden Gotchas' converting that code over.
  • #364
  • May 8, 2009 10:25am May 8, 2009 10:25am
Hi Bemac,

Do you mean that you dragged the ex4 file onto the chart or that you opened the mq4 file in the editor and tried to compile it?



Iif you mean that you dragged the ex4 onto the chart, as to what might be the cause:
There are two reasons I can think of:
1) I tied this indie now on on a different instance of mt4 that I didn't develop it on, and I also didn't see anything at first. I think that the reason may be is this is a 'clean' installation, and while I was developing it I might have set global variables in one of the earlier versions and then taken that part of the code out. What you can do open the indie and set ResetGlobals to true in the indie. When I did this in my clean 223 build then everything was fine (Turn it off afterward or things will not stay in place when you change tfs)

2) However, I see that your build is different from mine. I have build 223. When I tried the indicator on an old version of mt4 that was build 221 it didn't work, and reseting the globals didn't help either. However that instance is a dead instance in which nothing else is working either, so you can try it.

If you mean you got the error while compiling it, maybe it's due to the differences in versions. But, I've gotten an error like that occasionally while developing things, when I try to compile. What I usually have to do in that case is to save my working collection of charts in one profile name, and then open a clean profile in it with a clean chart (no indies), then compile, and then add the indie.

I didn't get that error deleting it though.

Meanwhile I'm going to try to find some mt4 broker that I haven't installed yet and see if I can fix the indie so it shows up the first time you load it without having to reset globals.

I'd like to talk about the ADR range too. Will you let me know what happend when you reset globals?



Quoting Bemac
Hello MissP.
I loaded mq4 on a chart & didn't see anything.
When I tried to delete it & try again, I got this...
Attachment
Tried it 3 times & got the same thing.

I know you know I am lacking in IT savvy
I can send you the details if it would help.

Can you 'splain it to me like I'm a 56 year old?

ps. want to talk to you a little more about that ADR thing.
  • #365
  • May 8, 2009 10:34am May 8, 2009 10:34am
Reset Globals to "True" & FXDD crashed again.
  • #366
  • May 8, 2009 11:43am May 8, 2009 11:43am
Hi Bemac,

Ok, I reproduced the error here in an old 220 installation. Sorry for all this bother, but can you do me one more favor? Can you try the last version of the Eights (V1.17), which also draws the lines. I tried that here on a clean version of a 220 build and it didn't cause me any problems. If you try it and it also doesn't cause problems, then we can assume it's the global variables and not the vertical lines (which I suspect from the Windows error). Then I will go back to the other way of place holding without the globals

Quoting Bemac
Reset Globals to "True" & FXDD crashed again.
  • #367
  • May 8, 2009 11:51am May 8, 2009 11:51am
Quoting MissPips
Hi Bemac,

Ok, I reproduced the error here in an old 220 installation. Sorry for all this bother, but can you do me one more favor? Can you try the last version of the Eights (V1.17), which also draws the lines. I tried that here on a clean version of a 220 build and it didn't cause me any problems. If you try it and it also doesn't cause problems, then we can assume it's the global variables and not the vertical lines (which I suspect from the Windows error). Then I will go back to the other way of place holding without the globals
(V1.17) plots lines & can be Deleted.
  • #368
  • May 8, 2009 12:01pm May 8, 2009 12:01pm
Great, thanks. Now I will try to make Bemac-Default hold it's position without using globals.

Quoting Bemac
(V1.17) plots lines & can be Deleted.
  • #369
  • May 8, 2009 12:56pm May 8, 2009 12:56pm
I do use an array, and the vlines logic is similar in the version that works (the eights) and the one abends(Bemak default). The rectangle is drawn according to where you put the first two vlines in Bemack default, whereas the vlines are draw according to where the box is in the Eights, but it's 6 of one and half a dozen of the other. My difficulty is logical not programmatic. That is, if you put either the box corner or the vline on 1:15 in the 5 min tf and then switch up to the 30 m tf, what exactly did you mean? Should the range on the 30 min chart start at 1 or at 1:30?


Quoting kd3726
I just went 3 Lots Long on Bemac losing his Experts Tab It's a right not a given you know

Sounds like you are having VLine alignment issues, maybe it's something specific with vlines. don't know maybe its an anchoring issue thats all i can think of. All you should need is one Vline point stored in a global then transpose all the rest. Take the point off one of the corners of the rectangle.

nb: I'd calculate the transpose using fib math ( take the nearest H/L difference to start ), whatever works best. There's probably lots of formulas...
  • #370
  • May 8, 2009 1:16pm May 8, 2009 1:16pm
MissPips, you are developing another masterpiece of coding art here, great.

Can you get rid of the price labels on the right side vertical price grid?

I was reading somewhere that it is possible but don't remember exactly where it was, as soon as I find it I'll give you a PM.
  • #371
  • May 8, 2009 1:33pm May 8, 2009 1:33pm
Which indie are you referring to - Bemac default or Eights? If Bemac Default - did you download it before I removed it and did it work on your mt4 without causing an abend?

Quoting cobraforex
MissPips, you are developing another masterpiece of coding art here, great.

Can you get rid of the price labels on the right side vertical price grid?

I was reading somewhere that it is possible but don't remember exactly where it was, as soon as I find it I'll give you a PM.
  • #372
  • May 8, 2009 8:33pm May 8, 2009 8:33pm
Quoting MissPips
Which indie are you referring to - Bemac default or Eights? If Bemac Default - did you download it before I removed it and did it work on your mt4 without causing an abend?
I refere to default but didn't have chance to download it before it got deleted.

I only saw it on the screenshots.
  • #373
  • May 10, 2009 11:34am May 10, 2009 11:34am
Quote
That is, if you put either the box corner or the vline on 1:15 in the 5 min tf and then switch up to the 30 m tf, what exactly did you mean? Should the range on the 30 min chart start at 1 or at 1:30?
If you switch TF's you get a screwy line. The programmer shouldnt be making rounding decisions of such magnitude, thats not your responsibility, that you are about to take on. You have to erase the lines and then redraw them when the TF changes, imo its a visual glitch. You may be trying to accomplish too much in init, i don't know. Testing takes time, time = money. Just my 2C.
  • #374
  • May 10, 2009 4:51pm May 10, 2009 4:51pm
>Testing takes time, time = money

Right about that LOL.

I don't want to redraw them when the tf changes - the whole point was that people didn't want to loose the range when the tf changes. It is a visual glitch in a way. If you entered a range that started at 1:05 on the 5 min chart, when you switch to the 1 hour chart, that vertcal line looks like it's on the 1 am bar. But if you check the line, it says 1:05, and that's what causes the screwy lines. the only way to fix the screwy parallel lines is to move the vertical line a little left and then replace it on the 1 am bar. Then it gets the value 1 am, and the lines look ok.

So my choices are
either round to the nearest bar ( and I think you are right - the programmer should probably not decide this)

Or leave the lines screwy looking and let the user move the vertical bars. If the user already had the vertical line on the 1am bar in the 5 m tf there won't be a problem, and if he didn't then he will at least see that there is a problem that needs to be fixed.

Definately needs more work.

Quoting kd3726
If you switch TF's you get a screwy line. The programmer shouldnt be making rounding decisions of such magnitude, thats not your responsibility, that you are about to take on. You have to erase the lines and then redraw them when the TF changes, imo its a visual glitch. You may be trying to accomplish too much in init, i don't know. Testing takes time, time = money. Just my 2C.
  • #375
  • May 10, 2009 6:24pm May 10, 2009 6:24pm
Quoting MissPips
>Testing takes time, time = money

Right about that LOL.

I don't want to redraw them when the tf changes - the whole point was that people didn't want to loose the range when the tf changes. It is a visual glitch in a way. If you entered a range that started at 1:05 on the 5 min chart, when you switch to the 1 hour chart, that vertcal line looks like it's on the 1 am bar. But if you check the line, it says 1:05, and that's what causes the screwy lines. the only way to fix the screwy parallel lines is to move the vertical line a little left and...
Hi MissPips,

To ensure Box Integrity, I would suggest,

The Start Time looks for the First Close Time >than Initial Start Time.

The End Time looks for the Previous Close Time <than Initial End Time.

Can that be done?

Bemac
  • #376
  • May 11, 2009 1:43am May 11, 2009 1:43am
Hi Bemac,

For example, you mean that if I chose 1:10 as my start and 3:15 as my end on the 5 min, when tf is changed to 30 min, the start should become 1 and the end should become 3?

Quoting Bemac
Hi MissPips,

To ensure Box Integrity, I would suggest,

The Start Time looks for the First Close Time >than Initial Start Time.

The End Time looks for the Previous Close Time <than Initial End Time.

Can that be done?

Bemac
  • #377
  • May 11, 2009 7:16am May 11, 2009 7:16am
If I chose 1:10 as my start and 3:15 as my end on the 5 min, when tf is changed to 30 min, the start should become 1:30 and the end should become 3?
  • #378
  • May 11, 2009 10:46am May 11, 2009 10:46am
Ok, got it. Thanks. Still working on this indie. I have a version that doesn't cause an abend on a clean install of build 220, but I am still trying to improve the parallel lines.

Quoting Bemac
If I chose 1:10 as my start and 3:15 as my end on the 5 min, when tf is changed to 30 min, the start should become 1:30 and the end should become 3?
  • #379
  • Edited May 13, 2009 3:08am May 12, 2009 2:20pm | Edited May 13, 2009 3:08am
Hi All,

I think I have most of the bugs out of this indie. Mainly, the line glitches are fixed, and removing the indie does not cause mt4 build 220 to abend. This version will hold its position when you switch tfs.

This version is a combination of Bemac's default and the Eights indie.

That is, you can either have a Cobra-stye fib, where you can control the line style or a regular fib. You can reverse the regular fib, but not the Cobra style fib.

The indie does not have an automatic update. You have to click on it and then click ok to get it to update after you moved the lines.
The fib and the selection box are controlled by dragging the horizontal and vertical lines. (This is easier than grabbing the box). The box is just to highlight the selection area now.

It also does not remove the 4 control lines from the chart when you remove the indie unless you set DeleteAllObjects to true before removing it. (All this is to avoid using Globals, which cause an abend on build 220 when it was removed.)

The glitches with the lines are fixed. When you change timeframes they snap correctly - not crooked. However they snap to the previous bar. For example, if your selection was 1:10 to 3:15 on the five minute, they snap to 1 to 3 when you change tfs to the hourly. (This has to do with how MT4 calculates bars. I tried to avoid it but if you use a time based calculation instead of a bar based one you have to do an incredibly complicated calculation for each timeframe of whether the selection box contains weekends, and add or subtract the time for however many weekends there are.)
Attached Image (click to enlarge)
Click to Enlarge Name: fib.png Size: 65 KB
Attached File(s)
File Type: ex4 Bemac 20ICCE bemac default v1[1][1]12.ex4   41 KB | 312 downloads
File Type: mq4 Bemac 20ICCE bemac default v1[1][1]12.mq4   33 KB | 411 downloads
  • #380
  • May 13, 2009 10:34am May 13, 2009 10:34am
This version contains improvements suggested by Scrutch :
Different color options for left, right and center line, ability to choose different number of left and right lines, and different defaults.

Please note that if you prefer the original Fib tool you can set the fibstyle param to 1. However the fib is still controlled by dragging the lines, not the box. (Too many people had trouble either seleting or understanding the box, so I ditched it.)
Attached Image(s) (click to enlarge)
Click to Enlarge Name: fib3.png Size: 55 KB
Click to Enlarge Name: fib4.png Size: 54 KB
Attached File(s)
File Type: ex4 Bemac 20ICCE bemac-defaultcombo v1[1][1]13.ex4   41 KB | 442 downloads
File Type: mq4 Bemac 20ICCE bemac-defaultcombo v1[1][1]13.mq4   33 KB | 677 downloads
1 trader viewing now