I am testing it in DEMO too.. I think this problem is due to slippage?
Maybe Steve can increase the slippage or let the users decide what slippage to use?
- #101
- Mar 28, 2009 1:54pm Mar 28, 2009 1:54pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I'm not so sure, but then I coded the EA and know how it tries to deal with failed basket trade closures. I am afraid that the dreaded TradeContextBusy error is impossible to work around, and some brokers appear to use this for fun.
Doesn't stop me trying, though. I have increased the slippage from 3 to 10 - download from the first post as usual.
will test it and see how the new slippage for Basket trading works !
- #104
- Mar 30, 2009 7:40am Mar 30, 2009 7:40am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Just discovered this handy EA and testing it on my demo account.
One thing i'm investigating is the partial close in conjunction with BreakEven routine. It says that those can be combined, but from my tests and reading the code it seems that partial close can only be used with JumpingStop.
(Mind you, i'm not a programmer).
I guess, what I'm asking is this:
Can this EA close part of my position at breakEven pips without using JumpingStop or any other trailing routine? That would be handy.
Any help with this greatly appreciated.
J
Details and download in post 1 as usual.
- #106
- Mar 30, 2009 4:24pm Mar 30, 2009 4:24pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Hello Steve,
I just want to say a very big thank you for this EA.
You have suceeded in solving a major set back in my trading career.
As U know, entering a trade is not the issue, but its how and when you exit that matters, because it's the profits or losses that determines if ur trading decision was right or wrong.
I am a full time 9-5 worker, and like many others , have been struggling to manage F/T employment and trading. As such I trade at work (discreetly) from my PDA /mobile phone.
Before now, am able enter trades according to my signals,...
It didn't before you posted this, so I have added code to make this possible. Let me know if it does not work properly.
Details and download in post 1 as usual.
That was less than 24 hours for an updated version...
And you call yourself an amateur?... I disagree...
Running it now in demo and its performing as expected. Will do a few more tests before i go live with it. Thanks a lot for that.
One more suggestion, if I may. Its not a request, as I'm happy with the current version, but have you thought about using an option to specify the initial Close_lots and consecutive ones in percent value rather than hard coded lots? I saw a few open_order scripts floating around that open a position using money management routine... say 2% risk of their account and not a specific number of lots.
Being able to always close say 50% of their opened position, no matter how many lots they bought initially, and then maybe 25% of the ramaining on each consecutive jump could be handy.
Just a suggestion, anyway.
I've tried just about all other Trade managers found on these pages and yours is head and shoulders above the rest in functionality and flexibility.
Very good work.
J
First of all, Thanks for this Wonderful EA, Steve
Just throwing a idea around.. not sure if its possible.. many times when my trade is near my Take Profit Target.. I wish my Trailing Stop can Tighten on its own.. so as to squeeze as much profit as possible before it turns
Hope you know what I mean?
For example, if my target is 100 pips and it hit 80 pips and I got a 50 pips trailing stop set on it.. so if it falls to 30 pips.. it would close and I would only get 30 pips.. and lose the 50 pips due to trailing stop..
So my question is can a special "flexible" trailing feature be included.. lets say if target is 100 pips, once it hit 50% target it would tighten its trailing stop to a pre-determined value.. and maybe once it hit 80% target it would tighten its trailing stop to another pre-determined value?
Hope you can help I like your EA very much.. makes life so much easier
Keep up the good work!!
Just throwing a idea around.. not sure if its possible.. many times when my trade is near my Take Profit Target.. I wish my Trailing Stop can Tighten on its own.. so as to squeeze as much profit as possible before it turns
Hope you know what I mean?For example, if my target is 100 pips and it hit 80 pips and I got a 50 pips trailing stop set on it.. so if it falls to 30 pips.. it would close and I would only get 30 pips.. and lose the 50 pips due to trailing stop..
So my question is can a special "flexible" trailing feature be included.. lets say if target is 100 pips, once it hit 50% target it would tighten its trailing stop to a pre-determined value.. and maybe once it hit 80% target it would tighten its trailing stop to another pre-determined value?
Hope you can help
I like your EA very much.. makes life so much easier Keep up the good work!!
- #109
- Mar 31, 2009 1:24pm Mar 31, 2009 1:24pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
First of all, Thanks for this Wonderful EA, Steve
Just throwing a idea around.. not sure if its possible.. many times when my trade is near my Take Profit Target.. I wish my Trailing Stop can Tighten on its own.. so as to squeeze as much profit as possible before it turns
For example, if my target is 100 pips and it hit 80 pips and I got a 50 pips trailing stop set on it.. so if it falls to 30 pips.. it would close and I would only get 30 pips.. and lose the 50 pips due to trailing stop..
So my question is can...
Hello Steve,
First of all I want to congratulate you for the great EA, which I'm beginning to use now, essencially to manage my exits with jumping stop and partial closures (the hardest part to respect for me), as well as for adding missing stops
I haven't gone through the all thread, so excuse me if this has been brought up before... but I read on the pdf file about the placement of the missing stop not being exact by the pip, so I went to check it out in the code, tried a little change, and seems to be working correctly now (at least it did in the 4 trades I placed since market's openning);
And it seems to me that you've used a similar procedure in other parts of the code... wonder if you forgot it in this part, or you didn't put it for some specific reason (might affect something else)?
Anyway, in this piece of code:
I've replaced the "ask" and "bid" by "OrderOpenPrice()", like that:
And my stops are being correctly placed now.
Please check if this is ok (I'm not a programmer, just can do little changes here and there) and if it won't affect anything else;
If it's fine this way, maybe you'll want to "refine" it and update post #1 and pdf file.
I hope this helps, in a way of thanking you for sharing it with us
Regards.
First of all I want to congratulate you for the great EA, which I'm beginning to use now, essencially to manage my exits with jumping stop and partial closures (the hardest part to respect for me), as well as for adding missing stops
I haven't gone through the all thread, so excuse me if this has been brought up before... but I read on the pdf file about the placement of the missing stop not being exact by the pip, so I went to check it out in the code, tried a little change, and seems to be working correctly now (at least it did in the 4 trades I placed since market's openning);
And it seems to me that you've used a similar procedure in other parts of the code... wonder if you forgot it in this part, or you didn't put it for some specific reason (might affect something else)?
Anyway, in this piece of code:
PHP Code
void InsertStopLoss() { if (OrderStopLoss() != 0 || MissingStopLossPips == 0) return; //Nothing to do // Buy trade if (OrderType() == OP_BUY) { double SL = NormalizeDouble(ask - (MissingStopLossPips * point),digits); }//if (OrderType() == OP_BUY) // Sell trade if (OrderType() == OP_SELL) { SL = NormalizeDouble(bid + (MissingStopLossPips * point), digits); }//if (OrderType() == OP_BUY) int ticket = OrderModify(OrderTicket(),OrderOpenPrice(), SL, OrderTakeProfit(), OrderExpiration(),CLR_NONE);
PHP Code
void InsertStopLoss() { if (OrderStopLoss() != 0 || MissingStopLossPips == 0) return; //Nothing to do // Buy trade if (OrderType() == OP_BUY) { double SL = NormalizeDouble(OrderOpenPrice() - (MissingStopLossPips * point),digits); }//if (OrderType() == OP_BUY) // Sell trade if (OrderType() == OP_SELL) { SL = NormalizeDouble(OrderOpenPrice() + (MissingStopLossPips * point), digits); }//if (OrderType() == OP_BUY) int ticket = OrderModify(OrderTicket(),OrderOpenPrice(), SL, OrderTakeProfit(), OrderExpiration(),CLR_NONE);
Please check if this is ok (I'm not a programmer, just can do little changes here and there) and if it won't affect anything else;
If it's fine this way, maybe you'll want to "refine" it and update post #1 and pdf file.
I hope this helps, in a way of thanking you for sharing it with us
Regards.
- #112
- Apr 27, 2009 5:53am Apr 27, 2009 5:53am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Cheers tonirai. I think it is brilliant when people learn enough mql code to make these sorts of changes for themselves; you know how much easier it makes your life to be able to do so.
Your code will ensure pinpoint accuracy from the trade open price.
I am going to leave the code as it is because it allows for the spread. At least, I think it does. I don't actually use this function but will make the change with pleasure if there is a demand.
Anybody who has followed my instructions about customising script code will be able to make this change for themselves as well.
Your code will ensure pinpoint accuracy from the trade open price.
I am going to leave the code as it is because it allows for the spread. At least, I think it does. I don't actually use this function but will make the change with pleasure if there is a demand.
Anybody who has followed my instructions about customising script code will be able to make this change for themselves as well.
- #114
- Apr 29, 2009 12:53pm Apr 29, 2009 12:53pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I propose an additional feature - closing positions on pressing short key combination (for currency displayed on the chart):
Close All - Shift+F9
Close Buy orders -Shift+B+F9
Close Sell Orders -Shift+S+F9
Sometimes I have to exit manually all positions or all buys or sells and there is no option for that in MT4.
Hope you love the idea as well.
- #117
- Apr 30, 2009 9:41pm Apr 30, 2009 9:41pm
- | Commercial User | Joined Jan 2009 | 1,815 Posts
The trend always ends.
- #118
- Apr 30, 2009 9:43pm Apr 30, 2009 9:43pm
- | Commercial User | Joined Jan 2009 | 1,815 Posts
First of all, Thanks for this Wonderful EA, Steve
Just throwing a idea around.. not sure if its possible.. many times when my trade is near my Take Profit Target.. I wish my Trailing Stop can Tighten on its own.. so as to squeeze as much profit as possible before it turns
For example, if my target is 100 pips and it hit 80 pips and I got a 50 pips trailing stop set on it.. so if it falls to 30 pips.. it would close and I would only get 30 pips.. and lose the 50 pips due to trailing stop..
So my question is...
I had a "meeting in the middle" ts ea programmed that I was going to suggest to Steve a while back during the basket trade testing. I'm not sure if I still have it but will look.
The trend always ends.
- #119
- Apr 30, 2009 9:46pm Apr 30, 2009 9:46pm
- | Commercial User | Joined Jan 2009 | 1,815 Posts
The trend always ends.
- #120
- Apr 30, 2009 9:52pm Apr 30, 2009 9:52pm
- | Commercial User | Joined Jan 2009 | 1,815 Posts
The trend always ends.