ordermodify() whats wrong with my logic? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify - Error code 1 9 replies

Why ordermodify error 1? 9 replies

OrderModify error 1 ?? 0 replies

OrderModify problem 3 replies

Question about OrderModify() 2 replies

ordermodify() whats wrong with my logic?

  • #1
  • First Post: Apr 1, 2009 8:10am Apr 1, 2009 8:10am
Hello,

So what im trying to do is... When 50 points are reached, move my stop to break even.


But what ends up happening, it moves my stop to breakeven, but then every pip it goes up so does my stop. Like a trailing stop. BUT, if it goes down.. my stop moves down too ... thus pointless... How do I get this to run once without it moving with the current price?

SelectTrailingStopValue = 50 pips say ..



if (SelectTrailingStop == "Yes")
{
for(int x=0;x<=OrdersTotal();x++)
{
OrderSelect(x,SELECT_BY_POS,MODE_TRADES);
if(OrderMagicNumber() == 16384)
{
// OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,CLR_NONE);
if (OrderProfit() > SelectTrailingStopValue)
{
//Move stop to BE
OrderModify(OrderTicket(),OrderOpenPrice(),Ask-SelectTrailingStopValue*Point,OrderTakeProfit(),0,Blue);
}
}

}
}
Know your indicators!
  • #2
  • Apr 1, 2009 10:46am Apr 1, 2009 10:46am
Use this part of code, it is better, and more customizable!


PHP Code
extern   int      LevelProfit1 = 20;
extern   int      LevelMoving1 = 1;
extern   int      LevelProfit2 = 35;
extern   int      LevelMoving2 = 10;
extern   int      LevelProfit3 = 55;
extern   int      LevelMoving3 = 30;
extern   int      TrailingStop = 30;
extern   int      TrailingStep = 5;
extern   int      Slippage = 2;
 
//+------------------------------------------------------------------+
void deinit()
{
Comment("");
}
//+------------------------------------------------------------------+
void start()
{
double point;
int    digits;
string msg = "";
for (int i = 0; i < OrdersTotal(); i++)
   {
   if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
      {
      if (OrderSymbol() == Symbol())
         {
         ThreeLevelSystemOfOutput();
         digits = MarketInfo(OrderSymbol(),MODE_DIGITS);
         point = MarketInfo(OrderSymbol(),MODE_POINT);
         msg = msg + OrderSymbol() + "  Symbol: " + DoubleToStr(OrderOpenPrice(),digits) + "  SL = " + DoubleToStr(OrderStopLoss(),digits) + " (" + StopLossInPoint() + ")n";
         }
      }
   }
Comment(msg);
}
//+------------------------------------------------------------------+
void ThreeLevelSystemOfOutput()
{
int profit = ProfitPosition();
int sl = StopLossInPoint();
int spread = MarketInfo(OrderSymbol(),MODE_SPREAD);
if ((profit > LevelProfit1) && (profit <= LevelProfit2) && (sl < LevelMoving1))
   {
   ModifyStopLossInPoint(LevelMoving1);
   }
if ((profit > LevelProfit2) && (profit <= LevelProfit3) && (sl < LevelMoving2)) ModifyStopLossInPoint(LevelMoving2);
if ((profit > LevelProfit3) && (sl < LevelMoving3)) ModifyStopLossInPoint(LevelMoving3);
}
//+------------------------------------------------------------------+
void ModifyStopLossInPoint(int stoploss)
{
bool   result;
double sl = 0;
double point = MarketInfo(OrderSymbol(),MODE_POINT);
if (OrderType() == OP_BUY) sl = OrderOpenPrice() + stoploss * point;
if (OrderType() == OP_SELL) sl = OrderOpenPrice() - stoploss * point;
result = OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,CLR_NONE);
}
//+------------------------------------------------------------------+
int ProfitPosition()
{
double bid;
double ask;
double point = MarketInfo(OrderSymbol(),MODE_POINT);
double profit = 0;
if (OrderType() == OP_BUY)
   {
   bid = MarketInfo(OrderSymbol(),MODE_BID);
   profit = (bid - OrderOpenPrice()) / point;
   }
if (OrderType() == OP_SELL)
   {
   ask = MarketInfo(OrderSymbol(),MODE_ASK);
   profit = (OrderOpenPrice() - ask) / point;
   }
return(MathRound(profit));
}
//+------------------------------------------------------------------+
int StopLossInPoint()
{
double point = MarketInfo(OrderSymbol(),MODE_POINT);
double sl = 0;
if (OrderType() == OP_BUY) sl = (OrderStopLoss() - OrderOpenPrice()) / point;
if (OrderType() == OP_SELL) sl = (OrderOpenPrice() - OrderStopLoss()) / point;
if (OrderStopLoss() == 0.0) sl = -OrderOpenPrice() / point;
return(MathRound(sl));
}
forexflash
  • #3
  • Last Post: Apr 1, 2009 12:31pm Apr 1, 2009 12:31pm
Quoting trader346
Hello,

So what im trying to do is... When 50 points are reached, move my stop to break even.


But what ends up happening, it moves my stop to breakeven, but then every pip it goes up so does my stop....
OrderProfit() returns the profit of the selected order in the base currency of the account. It does not return the value in pips.
0 traders viewing now