The AshFX System - Version II | Page 4 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Looser Trading System (Version 0.01-1/3) 595 replies

AshFX Daily 2,650 replies

AshFX Daily (EA - MTaboneWeb) 250 replies

Fish Net System Version 2 145 replies

Help: Backtest a Version of the First Strike System 0 replies

Attachments: The AshFX System - Version II
Exit Attachments

The AshFX System - Version II

  • #61
  • Mar 26, 2009 9:01am Mar 26, 2009 9:01am
No I haven't disabled the Stop loss - if I did, then neither positions would close (one is closing and not the other).

I should have mentioned, in the example above, the first position was closed at break even (despite hitting the initial stop loss at swing high first) but the second position was closed at the initial stop loss.

This is also the situation with buy orders... the second position is closed correctly at the swing low , but the first position is not closed at the swing low -rather at the break even point (despite hitting the swing low first).
  • #62
  • Mar 26, 2009 9:30am Mar 26, 2009 9:30am
Quoting Ronald Raygun
Was there a stoploss?

The stoploss is what closes the trade in the event of a non-profit...are you sure you're not disabling the stoploss?
Hi Ronald,

When I use your EA (AshFX Version II), is the following statement is true for the stoploss? :

When I leave everything in default (UseStoploss=true, sl=100), then in a single trade the maximal loss can be 100 pips?

Because I backtested it with this settings, and I saw some much bigger losses (over 200 pips). Am I doing something wrong? Or just should I stop backtesing? :-)
  • #63
  • Mar 26, 2009 9:53am Mar 26, 2009 9:53am
Quoting uafx
Hi Ronald,

When I use your EA (AshFX Version II), is the following statement is true for the stoploss? :

When I leave everything in default (UseStoploss=true, sl=100), then in a single trade the maximal loss can be 100 pips?

Because I backtested it with this settings, and I saw some much bigger losses (over 200 pips). Am I doing something wrong? Or just should I stop backtesing? :-)
Was OverRideStopLoss set to true?



Quoting D_Trader
No I haven't disabled the Stop loss - if I did, then neither positions would close (one is closing and not the other).

I should have mentioned, in the example above, the first position was closed at break even (despite hitting the initial stop loss at swing high first) but the second position was closed at the initial stop loss.

This is also the situation with buy orders... the second position is closed correctly at the swing low , but the first position is not closed at the swing low -rather at the break even point (despite hitting the swing...
When you're using terms such as "first position" or "second position" you are referring to "Trade #1" and "Trade #2" that you see in the trade comments, correct?

I ask because this little snippet of code should take care of that already:

PHP Code
//If the previous bar was in the direction of the trade, and the trade is in profit.
if(OrderComment() == "Buy(#" + MagicNumber + ") Trade #1" && iBarShift(NULL, 0, OrderOpenTime(), false) != 0 && CandleDirection == "Long" && OrderProfit() > 0) 
      {
      Order = SIGNAL_CLOSEBUY;
      }
//If the first trade's criterion were hit, move the second trade to breakeven
if(OrderComment() == "Buy(#" + MagicNumber + ") Trade #2" && iBarShift(NULL, 0, OrderOpenTime(), false) != 0 && CandleDirection == "Long")
      {
      if(OrderStopLoss() < OrderOpenPrice() + Point * MoveStopTo) 
         {
         OrderModify(OrderTicket(),OrderOpenPrice(), OrderOpenPrice() + Point * MoveStopTo, OrderTakeProfit(), 0, Red);
         }
      }   
//if the AO or PSAR are against the trade, close trade #2
if(OrderComment() == "Buy(#" + MagicNumber + ") Trade #2" && (PSARPosition == "Short" || AODirection == "Red"))
   {
   Order = SIGNAL_CLOSEBUY;
   }

//If you see the opposite signal, close both trades
if(CloseOnOppositeSignal && TradeTrigger == "Open Short") Order = SIGNAL_CLOSEBUY;
  • #64
  • Mar 26, 2009 12:22pm Mar 26, 2009 12:22pm
[quote=Ronald Raygun;2630582]Was OverRideStopLoss set to true?


OverRideStopLoss was set to "false".

Some examples for large SLs (GBPJPY H4):

SELL 134.646, close at 136.067 (about 150 pips)
SELL 119.565, close at 128.320 (more than 800!!! pips...:-))
and so on, a lot more...

Maybe I am missing something, or what else? :-)
  • #65
  • Mar 26, 2009 12:59pm Mar 26, 2009 12:59pm
Quoting uafx

OverRideStopLoss was set to "false".

Some examples for large SLs (GBPJPY H4):

SELL 134.646, close at 136.067 (about 150 pips)
SELL 119.565, close at 128.320 (more than 800!!! pips...:-))
and so on, a lot more...

Maybe I am missing something, or what else? :-)
Yes, you are missing something. =D

That stoploss value is the value the EA uses if the OverRideStopLoss is set to True. See, if OverRideStopLoss is set to True, then the StopLoss value overrides what the EA calculates.
  • #66
  • Mar 26, 2009 6:22pm Mar 26, 2009 6:22pm
I don't get "Trade #1" or "Trade #2" in the top left hand corner if that's what you're referring to when you say that it should be in 'trade comments'?

When I say 'first position' or 'second position' I'm just referring to the order that they appear in the results tab. So, lets say it opens a position, in the results tab we have in the order column - 1 and 2, I make the assumption that 1 = Trade #1 and 2 = Trade #2. Then lets say it opens order 3 and 4, I assume 3 = Trade #1 and 4 = Trade #2 and so on. Is this is a valid assumption to make?

I think it would be easiest if you can replicate the results... the currency pair and time period i have tested have been consistent throughout my screenshots - GMT + 2 broker, EURUSD, Jan 1 2006 - Jan 1 2007.

In the code you posted, I can't see any code that tells me the position is to be closed if the swinghigh/swinglow is hit

Quoting Ronald Raygun
When you're using terms such as "first position" or "second position" you are referring to "Trade #1" and "Trade #2" that you see in the trade comments, correct?

I ask because this little snippet of code should take care of that already:

[php]
//If the previous bar was in the direction of the trade, and the trade is in profit.
if(OrderComment() == "Buy(#" + MagicNumber + ") Trade #1" && iBarShift(NULL, 0, OrderOpenTime(), false) !=...
  • #67
  • Mar 26, 2009 6:33pm Mar 26, 2009 6:33pm
Right click on the trade, then click on "comments"

Quoting D_Trader
I don't get "Trade #1" or "Trade #2" in the top left hand corner if that's what you're referring to when you say that it should be in...
  • #68
  • Mar 26, 2009 7:37pm Mar 26, 2009 7:37pm
I'm not getting that option to see trade comments in visual test ... Right clicked on the trade in the 'results' tab and there's no comment option; if I right click on the arrows on the chart itself, it tells me whether Trade #1 or Trade #2, but the closing arrows don't give this information.

The journal doesn't give this info either ... apologies if I've missed the way to get the comments - still familiarizing myself with MT
  • #69
  • Mar 29, 2009 10:38am Mar 29, 2009 10:38am
Quoting forexmoments
This system is simple, easy, & profitable.
Thanks 4 system. I have one question. What GMT time of your broker?
  • #70
  • Mar 29, 2009 2:21pm Mar 29, 2009 2:21pm
Quoting D_Trader
I'm not getting that option to see trade comments in visual test ... Right clicked on the trade in the 'results' tab and there's no comment option; if I right click on the arrows on the chart itself, it tells me whether Trade #1 or Trade #2, but the closing arrows don't give this information.

The journal doesn't give this info either ... apologies if I've missed the way to get the comments - still familiarizing myself with MT

If you're only using the backtester, Trade #1 is odd and Trade #2 is even. (It's supposed to be)
  • #71
  • Mar 29, 2009 4:14pm Mar 29, 2009 4:14pm
Quoting Ronald Raygun
If you're only using the backtester, Trade #1 is odd and Trade #2 is even. (It's supposed to be)
Hi Ronald The rules from Ashfx 2, for the stop loss is swinghigh or swinglow, in your EA its -100 as default.
My Email For Help: [email protected]
  • #72
  • Mar 29, 2009 4:55pm Mar 29, 2009 4:55pm
Quoting tcmm
Hi Ronald The rules from Ashfx 2, for the stop loss is swinghigh or swinglow, in your EA its -100 as default.
Did you read all of my posts on my version of the EA?

If you set OverRideStopLoss to "True" then yes, the EA uses 100 pips as its stoploss (or whatever the value there is).

Otherwise, as long as "UseStopLoss" is True, the EA will use the most recent fractal which is higher/lower than the current price.
  • #73
  • Mar 29, 2009 5:29pm Mar 29, 2009 5:29pm
Quoting Ronald Raygun
Did you read all of my posts on my version of the EA?

If you set OverRideStopLoss to "True" then yes, the EA uses 100 pips as its stoploss (or whatever the value there is).

Otherwise, as long as "UseStopLoss" is True, the EA will use the most recent fractal which is higher/lower than the current price.
Does that explain the Red line which shows Swing High and Swing Low, which would be your Fractals of course and your Stoploss in your EA.
My Email For Help: [email protected]
  • #74
  • Mar 29, 2009 7:23pm Mar 29, 2009 7:23pm
Yep.

The red and green lines are the positions of the fractals.
  • #75
  • Mar 29, 2009 7:25pm Mar 29, 2009 7:25pm
Quoting Ronald Raygun
Yep.

The red and green lines are the positions of the fractals.
Ok Great, Thanks
My Email For Help: [email protected]
  • #76
  • Mar 30, 2009 8:34am Mar 30, 2009 8:34am
Hi Ronald, Let me ask you this. If the EA triggered a trade and lets say the trade made a lot of pips on that first candle and you want to take those good pips. If you take 1/2 manually does the EA still work the same or continue the same
My Email For Help: [email protected]
  • #77
  • Mar 30, 2009 9:48am Mar 30, 2009 9:48am
Quoting tcmm
Hi Ronald, Let me ask you this. If the EA triggered a trade and lets say the trade made a lot of pips on that first candle and you want to take those good pips. If you take 1/2 manually does the EA still work the same or continue the same
The EA should still continue to work the same. Are you encountering difficulties?
  • #78
  • Mar 30, 2009 10:09am Mar 30, 2009 10:09am
Quoting Ronald Raygun
The EA should still continue to work the same. Are you encountering difficulties?
Ron, I am going to let you know.
The EUR/JPY got in the trade last night on the Ashfx2 Signal.
The EA put the trade in at 129.69 and because it moved a lot, I took 1/2 out at 128.24, for 145 pips. The other 1/2 is still in at about now 127.57.
So because I took it out manually, I will let you know what the EA will do at 5.00pm est. next candle.
I also have EUR/USD and GBP/USD in, that the EA put in also from last night, they are in profit, I did not take 1/2 on those. Keep An Eye out.
My Email For Help: [email protected]
  • #79
  • Edited 11:51am Mar 30, 2009 10:22am | Edited 11:51am
.
  • #80
  • Mar 30, 2009 11:43am Mar 30, 2009 11:43am
Quoting Ronald Raygun
Did you read all of my posts on my version of the EA?

If you set OverRideStopLoss to "True" then yes, the EA uses 100 pips as its stoploss (or whatever the value there is).

Otherwise, as long as "UseStopLoss" is True, the EA will use the most recent fractal which is higher/lower than the current price.
Hi Ronald,
I think there is a typo in the EA that may explain problems with stoplosses on short positions. In the Sell routine you define the swing high using ifractals with the swinglow variable instead of the swinghigh. So it looks like it's using the wrong price for a stop loss on shorts.

Wayne
0 traders viewing now