Ea code request: Close previous order when open new position | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA open position on demo, but not open position on real account. Any Comment 7 replies

Help needed to make EA open/close position at start of new bar 0 replies

Close Losing Position, Set Trailing Stop to Winning Position 2 replies

Oanda fxTrade, close position and open another in one order 4 replies

program: open a position when (close-open)==** 3 replies

Ea code request: Close previous order when open new position

  • #1
  • First Post: Edited 4:53pm Mar 20, 2009 4:05pm | Edited 4:53pm
Hi, i would like to make request for code for when the new position is open,automatically the previous order will close.Mean i dont want to use take profit or trailling.

Example:
When order buy is open,previous order sell will close
When order sell is open,previous order buy will close

i found the code is OrderCloseBy() but i dont know exactly where to put this code

thanks
  • #2
  • Mar 20, 2009 6:05pm Mar 20, 2009 6:05pm
You will have to close the orders with OrderClose() - It will have to be part of your OrderSend() routine. Close the BUY when you Open the SELL.
  • #3
  • Mar 20, 2009 6:22pm Mar 20, 2009 6:22pm
Thanks Fulltime247 for your respond...see bellow

int Buy,Sell;
Buy=OrderSend(Symbol(),OP_BUY,1,Ask,3,Ask-25*Point,Ask+25*Point,"My order #2",16384,0,Green);
OrderClose(Sell,1,Ask,25,Red);

Sell=OrderSend(Symbol(),OP_Sell,1,Bid,3,Bid-25*Point,Bid+25*Point,"My order #2",16385,0,Red);
OrderClose(Buy,1,Ask,25,Green);

It is correct?Please correct me if i wrong
  • #4
  • Mar 20, 2009 8:29pm Mar 20, 2009 8:29pm
you update a new code right?coz i try the earlier it give error message

the problem now is when i put

if(btotal>0){OrderClose(ticket);}
ticket=OrderSend(Symbol(),OP_BUY,lots,Ask,3,0,0,"Order Comment",MAGICTerminal,0,Magenta);

if(stotal>0){OrderClose(ticket);}
ticket=OrderSend(Symbol(),OP_SELL,lots,Bid,3,0,0,"Order Comment",MAGICTerminal,0,Lime);


this message appear
')' - wrong parameters count
  • #5
  • Edited 9:15pm Mar 20, 2009 8:56pm | Edited 9:15pm
i updated the code. I added a LOTSize extern for the lots. - (thought you'd replace that with your own variable) - Also make sure your LOTSize is a DOUBLE.
  • #6
  • Edited 9:46pm Mar 20, 2009 9:33pm | Edited 9:46pm
Still error,

'Order Comment Text' - wrong initialization
'cnt' - variable not defined
  • #7
  • Mar 20, 2009 9:45pm Mar 20, 2009 9:45pm
Inserted Code
extern int MAGICTerminal=101;
extern double LOTSize=0.10;
extern string ORDERComment="Order Comment Text";

//TOTAL Count..
         int btotal=0; int stotal=0; int ticket=0; bool xbool;
         for( int cnt=OrdersTotal()-1;cnt>=0;cnt--)
         {        
            xbool=OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);   
            if(OrderType()==OP_BUY && OrderMagicNumber()==MAGICTerminal && OrderSymbol()==Symbol()){btotal++;  ticket=OrderTicket();}   
            if(OrderType()==OP_SELL && OrderMagicNumber()==MAGICTerminal && OrderSymbol()==Symbol()){stotal++; ticket=OrderTicket();} 
    
         }// END TOTAL count..
         
          
         if(WHATEVER YOUR CONDITION FOR A BUY)
         {
         if(btotal>0){OrderClose(ticket);}
         ticket=OrderSend(Symbol(),OP_BUY,LOTSize,Ask,3,0,0,ORDERComment,MAGICTerminal,0,Magenta);
         }
         
         if(WHATEVER YOUR CONDITION FOR A SELL)
         {
         if(stotal>0){OrderClose(ticket);}
         ticket=OrderSend(Symbol(),OP_SELL,LOTSize,Bid,3,0,0,ORDERComment,MAGICTerminal,0,Lime);
         }
  • #8
  • Mar 20, 2009 9:55pm Mar 20, 2009 9:55pm
Ha! Thnx! Magnum - I always screw em up when I just write em online and cut/paste from existing code.
  • #9
  • Mar 20, 2009 10:09pm Mar 20, 2009 10:09pm
if(btotal>0){OrderClose(ticket);}
ticket=OrderSend(Symbol(),OP_BUY,LOTSize,Ask,3,0,0,ORDERComment,MAGICTerminal,0,Magenta);

if(stotal>0){OrderClose(ticket);}
ticket=OrderSend(Symbol(),OP_SELL,LOTSize,Bid,3,0,0,ORDERComment,MAGICTerminal,0,Lime);

Problem at the bold area

')' - wrong parameters count
')' - wrong parameters count
  • #10
  • Mar 20, 2009 10:15pm Mar 20, 2009 10:15pm
Quoting darkkiller
if(btotal>0){OrderClose(ticket);}
ticket=OrderSend(Symbol(),OP_BUY,LOTSize,Ask,3,0,0,ORDERComment,MAGICTerminal,0,Magenta);

if(stotal>0){OrderClose(ticket);}
ticket=OrderSend(Symbol(),OP_SELL,LOTSize,Bid,3,0,0,ORDERComment,MAGICTerminal,0,Lime);

Problem at the bold area

')' - wrong parameters count
')' - wrong parameters count
spend some time in the help section of metaeditor it will do wonders for you.


Inserted Code
if(btotal>0){OrderClose(ticket,OrderLots(),OrderClosePrice(),3,CLR_NONE);}
         ticket=OrderSend(Symbol(),OP_BUY,LOTSize,Ask,3,0,0,ORDERComment,MAGICTerminal,0,Magenta);

 if(stotal>0){OrderClose(ticket,OrderLots(),OrderClosePrice(),3,CLR_NONE);}
         ticket=OrderSend(Symbol(),OP_SELL,LOTSize,Bid,3,0,0,ORDERComment,MAGICTerminal,0,Lime);
  • #11
  • Mar 20, 2009 10:44pm Mar 20, 2009 10:44pm
Inserted Code
extern int MAGICTerminal=101;
extern double LOTSize=0.10;
extern string ORDERComment="Order Comment Text";

//TOTAL Count..
         int btotal=0; int stotal=0; int ticket=0; bool xbool;
         for( int cnt=OrdersTotal()-1;cnt>=0;cnt--)
         {        
            xbool=OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);   
            if(OrderType()==OP_BUY && OrderMagicNumber()==MAGICTerminal && OrderSymbol()==Symbol()){btotal++;  ticket=OrderTicket();}   
            if(OrderType()==OP_SELL && OrderMagicNumber()==MAGICTerminal && OrderSymbol()==Symbol()){stotal++; ticket=OrderTicket();} 
    
         }// END TOTAL count..
         
          
         if(WHATEVER YOUR CONDITION FOR A BUY)
         {
        
if(btotal>0){OrderClose(ticket,OrderLots(),OrderClosePrice(),3,CLR_NONE);}
         ticket=OrderSend(Symbol(),OP_BUY,LOTSize,Ask,3,0,0,ORDERComment,MAGICTerminal,0,Magenta);
         }
         
         if(WHATEVER YOUR CONDITION FOR A SELL)
         {
if(stotal>0){OrderClose(ticket,OrderLots(),OrderClosePrice(),3,CLR_NONE);}

         ticket=OrderSend(Symbol(),OP_SELL,LOTSize,Bid,3,0,0,ORDERComment,MAGICTerminal,0,Lime);
         }

This code is okay and not give any error but when i try backtest,still not close previous position..
  • #12
  • Mar 20, 2009 10:50pm Mar 20, 2009 10:50pm
please attach the file you are editing. Looking at just small segments of code sucks
  • #13
  • Mar 20, 2009 11:00pm Mar 20, 2009 11:00pm
Quoting darkkiller
Hi, i would like to make request for code for when the new position is open,automatically the previous order will close.Mean i dont want to use take profit or trailling.

Example:
When order buy is open,previous order sell will close
When order sell is open,previous order buy will close

i found the code is OrderCloseBy() but i dont know exactly where to put this code

thanks
i think you can achieve it by putting this command:


if (your condition for buy.........)
{
CloseSell();
Ordersend(Buy command...........);
}

you can get closesell or closeall function easily...if not, i send u later
  • #14
  • Mar 20, 2009 11:43pm Mar 20, 2009 11:43pm
Inserted Code
extern int MAGICTerminal=101;
extern double LOTSize=0.10;
extern string ORDERComment="Order Comment Text";

//TOTAL Count..
         int btotal=0; int stotal=0; int ticket=0; double closelots=0; bool xbool;
         for( int cnt=OrdersTotal()-1;cnt>=0;cnt--)
         {        
            xbool=OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);   
            if(OrderType()==OP_BUY && OrderMagicNumber()==MAGICTerminal && OrderSymbol()==Symbol()){btotal++;  ticket=OrderTicket(); closelots=OrderLots();}   
            if(OrderType()==OP_SELL && OrderMagicNumber()==MAGICTerminal && OrderSymbol()==Symbol()){stotal++; ticket=OrderTicket(); closelots=OrderLots();} 
    
         }// END TOTAL count..
         
          
         if(WHATEVER YOUR CONDITION FOR A BUY)
         {
        
if(btotal>0){OrderClose(ticket,closelots,Bid,3,CLR_NONE);}
         ticket=OrderSend(Symbol(),OP_BUY,LOTSize,Ask,3,0,0,ORDERComment,MAGICTerminal,0,Magenta);
         }
         
         if(WHATEVER YOUR CONDITION FOR A SELL)
         {
if(stotal>0){OrderClose(ticket,closelots,Ask,3,CLR_NONE);}

         ticket=OrderSend(Symbol(),OP_SELL,LOTSize,Bid,3,0,0,ORDERComment,MAGICTerminal,0,Lime);
         }

You really have to start using the [Help] though. Anytime I code the bottom 25% of the screen is the open Help window - It has code snippets and will help you UNDERSTAND the commands. When the compiler gives you a command error just lookup the syntax. usually thats all you need to see what you need to fix. - These type of operations require carrying info through the program from one area to another via variables. this is no one command that will do what you want. - Most of MQ4 is like that. its just a set of lego blocks you put together to make the computer do what you want to.
  • #15
  • Mar 21, 2009 12:12am Mar 21, 2009 12:12am
Thanks guys (Fulltime247,magnumfreak,akukaya) for your support and feedback.Your posting give me some idea how to solve it

My problem already solved,i always use HELP because i still beginner coder.After many time i try,this code is so simple like bellow

Inserted Code
[b]put after OrderSend BUY[/b]
{
                 OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet); // close position
                
                }

[b]put after OrderSend SELL[/b]
  {
               OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet); // close position
           
              }
  • #16
  • May 6, 2009 7:58pm May 6, 2009 7:58pm
Just wanted to bring this thread back to the front and share a message with the board.

This board thrives due to the contibutions of those who are able and willing. For those of us who are often looking for a piece or 2 of code please accept our thanks, we are grateful to you.

BUT, as a message to those of us who are looking, the answer may already be under your nose.

I was wrestling with a trade closing issue as described in the thread title. Decided to invest some research time into the archives. This is a good habit to develop anyway as I've always come across something else that will help me grow as a trader.

Anyway, I found this thread on Page 8 and what'dya know... my answer was in here !!! After some time with "scizzors & crazy glue" I'm now actively forward testing a few demo versions and the results so far are exactly what I was looking for.

So don't be afraid to do a bit of archival digging before posting that "gotta know" question. There's a good chance you'll actually learn more than if you posted the question.

Best wishes for successful trading to all ...
  • #17
  • Last Post: Sep 22, 2009 1:45pm Sep 22, 2009 1:45pm
Hi,

please help me for the below logic.

how to open a new buy stop order immediately after executing the previous pending order.

for example.
i am having a pending order set EURUSD @ 1.4500. when ever it hits the rate i wanted to create a new buy stop order @ 1.4500+40.

please help me.

RAJ
0 traders viewing now