I made some more bug fixes and improvements. I hope the folks at ForexFactory dont mind some of my fixes, it will generate a bit more traffic to/from thier website when indicator is deleted/removed.
Here's a changelog of what I did:
-Added ability to disable Web/URL updates. This is so that the multiple instances of the indicator used by other charts or EAs dont fight with each other (Error code 4103)
-Fixed deleting OBJ_TREND, only deletes its own Trend Lines objects instad of all OBJ_TREND objects
-Fixed deleting OBJ_TEXT , only deletes its own Headlines instead of all text
-Made file name global and indicator now deletes the xml file each time the indicator is put on or removed from chart. Fixed one case of divide by zero where multiple charts indicator is on was trying to overwrite the same file (forces a new download of the xml)
I have attached the indicator to my chart and it does not work. I checked the code and fond that you read the data from an xml file "http://www.forexfactory.com/weekly_calendar.xml"
but the link is missing.
Do I have to do anything else or just compile the FFCal_v01.mq4?
I made some more bug fixes and improvements. I hope the folks at ForexFactory dont mind some of my fixes, it will generate a bit more traffic to/from thier website when indicator is deleted/removed.
Here's a changelog of what I did:
-Added ability to disable Web/URL updates. This is so that the multiple instances of the indicator used by other charts or EAs dont fight with each other (Error code 4103) -Fixed deleting OBJ_TREND, only deletes its own Trend Lines objects instad of all OBJ_TREND objects -Fixed deleting OBJ_TEXT , only deletes its own Headlines instead of all text -Made file name global and indicator now deletes the xml file each time the indicator is put on or removed from chart. Fixed one case of divide by zero where multiple charts indicator is on was trying to overwrite the same file (forces a new download of the xml)
I have attached the indicator to my chart and it does not work. I checked the code and fond that you read the data from an xml file "http://www.forexfactory.com/weekly_calendar.xml"
but the link is missing.
Do I have to do anything else or just compile the FFCal_v01.mq4?
Thanks ,
Bluewave
Ignored
please change to this "http://www.forexfactory.com/ff_calendar_thisweek.xml"
I made some more bug fixes and improvements. I hope the folks at ForexFactory dont mind some of my fixes, it will generate a bit more traffic to/from thier website when indicator is deleted/removed.
Here's a changelog of what I did:
-Added ability to disable Web/URL updates. This is so that the multiple instances of the indicator used by other charts or EAs dont fight with each other (Error code 4103)
-Fixed deleting OBJ_TREND, only deletes its own Trend Lines objects instad of all OBJ_TREND objects
-Fixed deleting OBJ_TEXT , only deletes its own Headlines instead of all text
-Made file name global and indicator now deletes the xml file each time the indicator is put on or removed from chart. Fixed one case of divide by zero where multiple charts indicator is on was trying to overwrite the same file (forces a new download of the xml)
Enjoy folks!
Mike
Ignored
Mike:
Why would they "fight with each other"?
Why did the XML file need deleting? Because two charts were trying to write it at the same time?
I am trying to get Ver_05 to work in my EA... again the goal is just to turn the EA off 30 min prior and 30 min after an announcement. . .
Here is what I have so far, thanks to Telsa on an eairlier post. I just cannot get it to work..
PHP Code
//Global
#define RETVALUE_CACHE 5 // Minutes since last function call to simply return previous value
#define NOTRADE_PRIOR 30 // Minutes prior to news release during which it's considered "news time"
#define NOTRADE_POST 30 // Minutes since news release during which it's considered "news time"
static bool NewsTime = false;
static datetime dtLastCall = 0;
//The Function
bool TradeNews() {
// if it's been less than 'x' minutes since this function was last
// called, simply return previously determined value.
if (dtLastCall + RETVALUE_CACHE*60 >= TimeCurrent())
return(NewsTime);
// check the calendar
int minsSinceEG = iCustom("EURGBP", 0, "FFCAL_v05", true, false, false, true, 1, 0);
int minsUntilEG = iCustom("EURGBP", 0, "FFCAL_v05", true, false, false, true, 1, 1);
int minsSinceUJ = iCustom("USDJPY", 0, "FFCAL_v05", true, false, false, true, 1, 0);
int minsUntilUJ = iCustom("USDJPY", 0, "FFCAL_v05", true, false, false, true, 1, 1);
Print("minsSinceEG = ", minsSinceEG);
Print("minsUntilEG = ", minsUntilEG);
Print("minsSinceEG = ", minsSinceUJ);
Print("minsUntilEG = ", minsUntilUJ);
// see if the return value should be tripped to true
if (minsUntilEG <= NOTRADE_PRIOR || minsSinceEG*(-1) <= NOTRADE_POST) NewsTime = true;
if (minsUntilUJ <= NOTRADE_PRIOR || minsSinceUJ*(-1) <= NOTRADE_POST) NewsTime = true;
// update the last call timestamp and return a value
dtLastCall = TimeCurrent();
return (NewsTime);
}
All I want to do is to say that if NewsTime is true (Dont trade) if NewsTime is false (go ahead and trade)....
This is a great indicator, just doesent do me much good unless i can incorperate it.
If you have FFCal_v05 loaded on two GBPUSD 5min charts, they will try to read/write to the same file. So the solution is to have FFCal_v05a on one chart be able to update/retrieve the xml file while having the second FFCal_v05a on the second chart only be able to read the xml file and not update it.
I was getting wierd divide by zero (not related to the mod operator one) errors and wierd behavior of the two charts with the two copies of FFCal_v05a running butting heads.
So that's why on the second chart you would set AllowWebUpdates=false, this would be useful to have two different EA's working on two GBPUSD 5min charts using two different FFCal_V05
FFCal is triggered to update those XML files at the top of the hour.
Instead of "Top of the hour" make it a little random.
Make it update the XML file every 3600 seconds + pip change since a random candle from yesterday This way, it is remotely possible for two or more copies of this indicator would collide updating the xml file.
Or another is
Inserted Code
int RefreshTime = 0; //ensure that 1st time will run
start () {
If (TimeLocal() > RefreshTime) {
RefreshTime = TimeLocal() + (Ask / Point) + 1800;
GrabWeb
save this xml file
}
}
But of course during dull hours when prices consolidate, it will not deviate much but will be highly improbable that they collide...
Do the Print statement you have in there print out the right values?
If you add a 5th boloean in each call, set to false, it will not display info on screen, but that should not matter for functionality. Do you have the FFCall loaded on the chart (running the EA) and is it working correctly?
If you have FFCal_v05 loaded on two GBPUSD 5min charts, they will try to read/write to the same file. So the solution is to have FFCal_v05a on one chart be able to update/retrieve the xml file while having the second FFCal_v05a on the second chart only be able to read the xml file and not update it.
I was getting wierd divide by zero (not related to the mod operator one) errors and wierd behavior of the two charts with the two copies of FFCal_v05a running butting heads.
So that's why on the second chart you would set AllowWebUpdates=false, this would be useful to have two different EA's working on two GBPUSD 5min charts using two different FFCal_V05
Thanks!
Mike
Ignored
Okay, thanks for the outline. I'll look over your code ASAP.
Do the Print statement you have in there print out the right values?
If you add a 5th boloean in each call, set to false, it will not display info on screen, but that should not matter for functionality. Do you have the FFCall loaded on the chart (running the EA) and is it working correctly?
We'll get this working.... :-)
Ignored
its not working right. its Choppy will say 0, then 250, then 0, then 45, ect..
The indicator seems to function properly.
When its added to the EA it kills the EA completly.
For use in an EA, mabye it wouyld be eaiser to just somehow retrieve the times for the announcements once a day then have the EA manage the time before and after the scheduled time.
This would also cut down on EA's accessing the FF site. If I understand right. currently the CAL is called every tick, at least thats what my journal says. All i need is the announcement times as a variable in my ea and i can code around it.
I've been thinking about it, and I have a bit of free time in the next day or two. If you want to just send me the .mq4 file, I can try to get it working...
If you want me to look at it, let me know which broker you are using, and send the code to me at [email protected], and I'll see if I can't get ya goin'. It shouldn't really matter, but you might also include which currency and TF yo uare using.
I've been thinking about it, and I have a bit of free time in the next day or two. If you want to just send me the .mq4 file, I can try to get it working...
If you want me to look at it, let me know which broker you are using, and send the code to me at [email protected], and I'll see if I can't get ya goin'. It shouldn't really matter, but you might also include which currency and TF yo uare using.
-Derk
Ignored
How about just a function with a NewsTime variable that can be copied and pasted into my EA's. I have 4 EA's currently running. Would like to turn them all off 30 min prior and 30 min after an announcement. Currently doing this manually.
I just trade the EUR/USD, USD/JPY and Cable
It would be nice to monitor all 4 currencies and filter out the high and med announcements.
It would be a good function for everyone to add to there EA's.
How about just a function with a NewsTime variable that can be copied and pasted into my EA's. I have 4 EA's currently running. Would like to turn them all off 30 min prior and 30 min after an announcement. Currently doing this manually.
I just trade the EUR/USD, USD/JPY and Cable
It would be nice to monitor all 4 currencies and filter out the high and med announcements.
It would be a good function for everyone to add to there EA's.
Thanks,
Kevin
Ignored
Kurka:
I think your problem might have been that you were multiplying by (-1) where you should not have been.
Those booleans mean:
true: include high priority
true: include medium priority
false: do NOT include low priority
true: include "speaks"
true: draw to chart --change to false to prevent any output to chart
Works fine for me. Hope this helps.
-Derk
PS: I have also enclosed FFCal v5 again. The only change was I turned off logging.
