Attachments: First EA Version1 Near Completion- Need Help

First EA Version1 Near Completion- Need Help

#41
Edited 7:49pm Mar 15, 2009 7:32pm | Edited 7:49pm

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Thanks Magnum! Randomizer working correctly now

Thus, it all works correctly, except I think I need some returns in there... I didn't have to use returns in VBA... I would just use "End Sub"

I think it is the returns problem that is hanging it up in the strategy tester, but it is opening orders, modifying, doing random tp now... but it gets stuck after that from going anywhere and times out in the strategy tester

#42
Mar 15, 2009 8:03pm Mar 15, 2009 8:03pm

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Here is the updated file... it is still hanging from the returns.... I added them in there where I thought it would end the check, but it apparently is not correct

Attached File(s)

Coach StdDev.mq4 18 KB | 194 downloads

#43
Mar 16, 2009 6:28am Mar 16, 2009 6:28am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Fixed the hanging.... it is opening and closing trades now in strategy tester.... however, it is modifying trades more than once.... can someone please tell me what is causing that with the logic?

If the linetrades<1 then it should never enter into the code where a modify can take place... maybe I need to move a bracket around or something?

Attached File(s)

Coach StdDev.mq4 18 KB | 187 downloads

#44
Mar 16, 2009 8:26am Mar 16, 2009 8:26am

sahron
| Membership Revoked | Joined Feb 2007 | 45 Posts

Dear friend,
I backtest and found 2 post without Tp not close for a long period??
But still profit. See Attach. I seriously looking for this improvement!!
Great work...thanks.

Attached Image (click to enlarge)

Click to Enlarge

Name: some.JPG
Size: 133 KB

#45
Mar 16, 2009 9:08am Mar 16, 2009 9:08am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Sahron,

If you take a closer look in the results, those that are hanging are being modified multiple times instead of just once right when the order is placed. It is this flaw in my code that I need to figure out how to fix.

It should never be able to go in and modify again an order... however, I think it has to do with my understanding of the brackets/returns/order of closing logic... that is where I can have an experienced coder tell me what is causing the problem... I have a leading if statement saying if line(x)trades<1 then continue in to the code.... inside another if statement in that block is where the Modify Order exists.... if any of line1trades, line2trades, line3trades, line4trades have a 1, it shouldn't be able to modify those trades

#46
Mar 16, 2009 9:14am Mar 16, 2009 9:14am

thatwasme
| Joined Feb 2008 | Status: Trader | 403 Posts

Quoting coach3131

Disliked

Sahron,

If you take a closer look in the results, those that are hanging are being modified multiple times instead of just once right when the order is placed....

Ignored

Hi, I did not look at all of your code, but I saw you have an If (....) and then you have else, in your order modify commands. Did you know that in the case of a if and else, when the if statement is false, the else statement is executed.

So

if ( false )
Comment( "Comment one" );
else
Comment( " Comment two");

Comment two will always be printed to the screen.

#47
Mar 16, 2009 9:25am Mar 16, 2009 9:25am

thatwasme
| Joined Feb 2008 | Status: Trader | 403 Posts

Also, why all the braces?

PHP Code

if  ((line1trades<1) && (StochSellLine>=StochBuyLine && StochSellLine>=88)  && ( (Open[0] < S_Line1 && Close[0] >= S_Line1)||(Open[0] > S_Line1 && Close[0] <= S_Line1)))
                        {  tp = 0;
                           LotSize= 0;
                           LotSize = LotSize();
                           rand = MathRand();
                           tp = (takeprofitlower + ((takeprofitupper-takeprofitlower)*(rand/32767)));
                           tp = NormalizeDouble(tp,0); 
                           {ticket = OrderSend(Symbol(),OP_SELL,LotSize, Bid, 3, 0, 0, "Coach Line1Sell",MagicNumber,0,Red); 
                              if (OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES))
                                 {  Print("SELL order opened : ",OrderOpenPrice());}
                              else
                                 {  Print("Error opening SELL order : ",GetLastError());}
                             {
                                 OrderModify(OrderTicket(),OrderOpenPrice() ,0,Bid-tp*Point,0,Red);
                                 line1trades = 1;
                                 line1comment = OrderComment();
                                 return;
                             }
                           }      
                         } 
                         }

#48
Mar 16, 2009 9:29am Mar 16, 2009 9:29am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Because I am very new to this programming language.... obviously, I am not a programmer by trade, but I have been able to create some complex things with VBA/Excel.... it is a much simpler language though... I am more of an Analyst by trade

#49
Mar 16, 2009 9:31am Mar 16, 2009 9:31am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

I found one error in my line4buy code... I will correct it when I get back and see if that is the problem... or just a side problem

#50
Mar 16, 2009 9:31am Mar 16, 2009 9:31am

thatwasme
| Joined Feb 2008 | Status: Trader | 403 Posts

This is effectively what you are coding and is far easier to read.

PHP Code

if  ((line1trades<1) && (StochSellLine>=StochBuyLine && StochSellLine>=88)  && ( (Open[0] < S_Line1 && Close[0] >= S_Line1)||(Open[0] > S_Line1 && Close[0] <= S_Line1)))
   {  
      tp = 0;
      LotSize= 0;
      LotSize = LotSize();
      rand = MathRand();
      tp = (takeprofitlower + ((takeprofitupper-takeprofitlower)*(rand/32767)));
      tp = NormalizeDouble(tp,0); 
      ticket = OrderSend(Symbol(),OP_SELL,LotSize, Bid, 3, 0, 0, "Coach Line1Sell",MagicNumber,0,Red); 
      if (OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES))
         {  
            Print("SELL order opened : ",OrderOpenPrice());
         }
      else
         {  
            Print("Error opening SELL order : ",GetLastError());
         }
      OrderModify(OrderTicket(),OrderOpenPrice() ,0,Bid-tp*Point,0,Red);
      line1trades = 1;
      line1comment = OrderComment();
      return;
   }

#51
Mar 16, 2009 9:33am Mar 16, 2009 9:33am

thatwasme
| Joined Feb 2008 | Status: Trader | 403 Posts

Oh Ok I see. Just use the Tab button for each logical indent.

BTW I haven't looked at your code so I do not know yet what the problem is and do not wish to intrude on Zen_Leow or Magnumfreak.

#52
Mar 16, 2009 10:17am Mar 16, 2009 10:17am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Thanks, I will give that a review as well as correct the error I found in the line4buy section in a couple of hours or so

#53
Mar 16, 2009 11:41am Mar 16, 2009 11:41am

Zen_Leow
Joined Jun 2008 | Status: Programming for a better future. | 652 Posts

Quoting thatwasme

Disliked

Oh Ok I see. Just use the Tab button for each logical indent.

BTW I haven't looked at your code so I do not know yet what the problem is and do not wish to intrude on Zen_Leow or Magnumfreak.

Ignored

I've not read the codes either. was waiting for it to be tidied up before I start straining my eyes reading it. It's easy to read our own codes but rather tedious to read others if you know what I mean.

Programming for a better future.

#54
Mar 16, 2009 3:15pm Mar 16, 2009 3:15pm

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Here is a working version

Using EurUsd, it won 79 of 80 for me on the 1 min chart for Jan and Feb... there is one hanger that reduces the profits so I am thinking about adding a stop loss or an MA cross stop for something like that... I will do some testing to figure out a better exit.... thoughts and suggestions would be greatly appreciated.... is there a way to put this on a past chart and see it visually? That will probably give me the best idea on how to handle that hanger...

Attached are the results....

Thanks so much for all that helped get this put together!

Attached Image (click to enlarge)

Click to Enlarge

Name: CoachStdDevResults.JPG
Size: 68 KB

Attached File(s)

Coach StdDev.mq4 18 KB | 210 downloads

#55
Mar 16, 2009 3:39pm Mar 16, 2009 3:39pm

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Actually, I need to put it in the logic not to open new orders on Friday... just to manage what is already opened which was part of the plan anyway.... I noticed the hanging one was a Friday trade and this strategy is not good to risk stuff hanging over the weekend

that will be included in a tradeable function that will look at the hours inputted and also not open new trades on Friday... if anyone else has any suggestions, that will be greatly appreciated

#56
Mar 16, 2009 4:31pm Mar 16, 2009 4:31pm