First EA Version1 Near Completion- Need Help | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Need help creating my first EA 12 replies

Amazing News System Expert Advisor - Needs Completion 2 replies

Need help with 10M chart - got it already but need some help! 1 reply

I need help with my first EA! 1 reply

Attachments: First EA Version1 Near Completion- Need Help
Exit Attachments

First EA Version1 Near Completion- Need Help

  • #1
  • First Post: Mar 11, 2009 12:31pm Mar 11, 2009 12:31pm
Any programmers able to take quick look at my post to help me add error handling and to make sure ticket recognition is correct, etc.

http://www.forexfactory.com/showthread.php?t=157072

I will come here and post it once I have it completed, which should only take a few minutes for an experienced programmer to review it and tidy it up so that it fits best practices
  • #2
  • Mar 12, 2009 2:24am Mar 12, 2009 2:24am
In the strategy tester, this only opens up one trade... it is giving me 131 and 4051 errors..... at least it is a profitable one :-)

Can somebody please explain to me why?

Also, the tp function keeps giving the same answer of 11 instead of being random.... is there some modification needed for that function? I am planning to have a tp randomizer that is shown to the broker and then a real one that is hidden... just trying to get the basic one first
Attached File(s)
File Type: mq4 Coach StdDev.mq4   13 KB | 213 downloads
  • #3
  • Mar 12, 2009 2:52am Mar 12, 2009 2:52am
I havn't had a chance to look at your code but the errors are for this :

131 error : is an "Invalid trade volume" so you need to make sure this value is not smaller or larger than your broker allows.

4051 error :is an "Invalid function parameter value" , check your functions (probably the custom ones you have written) and make sure they have the correct parameter values...parenthesis, values inside the parenthesis , etc.
  • #4
  • Edited 3:18am Mar 12, 2009 2:59am | Edited 3:18am
Thanks... I think I fixed that problem now... but now it is not following the rules and opening multiple orders per line

I accidentally had this on three charts on my demo, and it opened up a number of orders..... nice to make 10% on 10k demo account in seconds, but not the way it was intended to work :-)

What do I need to do in order to have only 1 line per trade?.... re-attaching and including indicators as well


Edit:
Fixed the multiple openings.... error for line2 code.... now strategy tester is only opening 4 lines (all wins, minimal drawdown which is the purpose of this EA).... anyway, when the t/p hits, it is not resetting that line to 0 now, thus not opening more trades... re-attaching most updated EA version
Attached File(s)
File Type: mq4 MA+StdDev.mq4   4 KB | 254 downloads
File Type: mq4 MA-StdDev.mq4   4 KB | 259 downloads
File Type: mq4 Coach StdDev.mq4   13 KB | 245 downloads
  • #5
  • Mar 12, 2009 3:33am Mar 12, 2009 3:33am
I see what it is doing now....

These two things need correction:
#1 Reset the lineorders to 0 when TP happens (right now it quits after one trade)
#2 There is some bug in it that it is opening all 4 orders at the same time instead of following the rules.... it should only open orders on line crosses with proper setup.... I think this has something to do with needing to count bars or something, but I am not sure
  • #6
  • Edited 4:09am Mar 12, 2009 3:49am | Edited 4:09am
Nothing to do with your problem at hand but I believe you need to relook your CloseMarketOrders() function because logically... I don't think it'll work.

Remember the positional index of the trades in your trade pool is much like an array index with the first position starting from 0. say you have 10 orders. their position index is going to be from 0 to 9.

OrdersTotal() gives you a number 10 because there are actually 10 trades in your trade pool. But if you throw that number straight into OrderSelect, it's going to tell you there's no such order or array out of bound exception kinda deal. Even by some off chance it continues, you have your "while (cnt>0)" in the way. that means if there's only 1 order or left with 1 order, which is at position 0, it will not be processed. as it doesn't fit in your condition. so... rule of thumb when it comes to looping backwards, use these instead.
Inserted Code
cnt = OrdersTotal() - 1;
while (cnt >= 0)
{
  // blah blah blah...
  cnt--;
}

alternatively you can just use a for loop which is what I prefer.

Inserted Code
int numberOfOrders = OrdersTotal();
if (numberOfOrders > 0)
{
   for (int cnt=numberOfOrders-1; cnt >= 0; cnt--)
   {
      // blah blah blah...
   }
}

regards,
Zen
Programming for a better future.
  • #7
  • Mar 12, 2009 4:01am Mar 12, 2009 4:01am
you can tackle ur #1 by using this function

Inserted Code
void CheckAndReset()
{
   if (line1ticket > 0)
   {
      if(!OrderSelect(line1ticket, SELECT_BY_TICKET, MODE_TRADES))
      {
         line1ticket = 0;
         line1trades = 0;
      }
   }
   if (line1ticket > 0)
   {
      if(!OrderSelect(line2ticket, SELECT_BY_TICKET, MODE_TRADES))
      {
         line2ticket = 0;
         line2trades = 0;
      }
   }
   if (line3ticket > 0)
   {
      if(!OrderSelect(line3ticket, SELECT_BY_TICKET, MODE_TRADES))
      {
         line3ticket = 0;
         line3trades = 0;
      }
   }
   if (line4ticket > 0)
   {
      if(!OrderSelect(line4ticket, SELECT_BY_TICKET, MODE_TRADES))
      {
         line4ticket = 0;
         line4trades = 0;
      }
   }
}

regards,
Zen

p.s., just a thought, this function would've been 1/4 its current size if you had used arrays to store and manage the line#ticket and line#trades values.
Programming for a better future.
  • #8
  • Mar 12, 2009 4:05am Mar 12, 2009 4:05am
Ok, here is the update....

When I use the for loop, it is continually giving error 138 messages with no orders open

The buy orders was working correct (not opening all 4 at same time) except it is not resetting line orders at TP

The sell orders was opening all 4 at the same time.... so I copied the buy logic and reset it all to sell logic to see if that would fix the problem

Also, why isn't tp random? It is always the lowertakeprofit amount instead of a random number between the two ranges
Attached File(s)
File Type: mq4 Coach StdDev.mq4   13 KB | 267 downloads
  • #9
  • Mar 12, 2009 4:09am Mar 12, 2009 4:09am
Quoting coach3131
Ok, here is the update....

When I use the for loop, it is continually giving error 138 messages with no orders open
I've amended the code in my post above. check it again.
Programming for a better future.
  • #10
  • Mar 12, 2009 4:14am Mar 12, 2009 4:14am
and can you spend some time tidying up your codes with proper indentations. codes within the same block should align. blocks within another block should indent. your codes aren't the worse I've read but there's definitely room for improvement when it comes to readability.

you can use the indicator I posted as a guide.

regards,
Zen
Programming for a better future.
  • #11
  • Mar 12, 2009 4:21am Mar 12, 2009 4:21am
Ok, ammended the code

As far as the arrays, can you give me a sample of what you are talking about?
Attached File(s)
File Type: mq4 Coach StdDev.mq4   14 KB | 236 downloads
  • #12
  • Edited 5:55am Mar 12, 2009 4:33am | Edited 5:55am
Edit: Went ahead and tidied up further.... will have to send this to a printer to make sure it is all lined up properly



Can you please show me an example of your array comment?

Why is the tp not random? I am using the random function, but it is always the lowertakeprofit range amount
Attached File(s)
File Type: mq4 Coach StdDev.mq4   16 KB | 224 downloads
  • #13
  • Mar 12, 2009 6:13am Mar 12, 2009 6:13am
It is now opening multiple trades per line instead of 1 trade per line.... why isn't line(x)trades = 1 after the order is complete not stopping the check of if line(x)trades < 1 then buy/sell on the next cycle through?
  • #14
  • Mar 12, 2009 8:02am Mar 12, 2009 8:02am
Perhaps you've already stated this before but I'm lazy to go dig up your old threads. That's the problem when members open too many threads for the same topic objective instead of maintaining just the one.

Can you write out in detail what your strategy is? What do you expect out of this EA, etc? as I see it, your EA don't wait for confirmed signals, meaning, it doesn't wait for the candle to close to open trade at the opening of the next candle... it'll just open trade as and when the current unclosed candle meets the criteria. Such a system usually generate a lot of false trades.

And there's a number of confusing stuffs I'm seeing in your code. e.g., why is Ask used to compare with the MA line? your MA line is derived from the prices on your chart and usually prices on your chart are based on Bid prices. If you want to compare Ask with something derived from Bid, spread should be catered for. either that or just use Bid to compare. But again, I won't know what exactly you want this EA to do until you write out in detail what's expected.

A couple of trade walkthroughs would be a good start.

regards,
Zen
Programming for a better future.
  • #15
  • Edited 9:00am Mar 12, 2009 8:40am | Edited 9:00am
Ok, I am going to post a summary now and will put up pictures of trade charts

The theory is a simple one really... at any point, the price can deviate for a number of reasons (banks just want their money, news, etc.)

The underlying principle is that the price will always return to the moving average over time.... the further the deviation, the likely that the price will gain pips, thus there is an increase in risk (this will be cleaned up and optimized in the future when I can do forward testing and use my trade analyzer in Excel that uses VBA something I am more familiar with)

so, what you will see with the indicator is standard deviations out based on this attached chart which shows statistical values.... so when the price crosses a standard deviation line and has upper momentum (or lower for a sell) on the Stochastic, then it is the time to buy or sell and snatch a few pips (scalper).... yes, I am wanting to make sure that the price close is spread + 5 to 20 pips or so.... it should only open 1 trade per standard deviation line on the indicator until it is closed... there are 4 lines.... so whatever array idea you have to manage that better would be great...

I want a random take profit to show for the broker (for example, 25 to 100 pips).... I will also have a random hidden take profit (5-20)... this will also be added when I have something that is functional... this random feature will be adjusted as I gather more data and can define ranges for each line, etc. (same as above... I will have win ratios for every line and every currency during every time period, etc. to find this)

=================================
Attached Image (click to enlarge)
Click to Enlarge Name: standard_deviation_chart.jpg Size: 24 KB
Attached Image
  • #16
  • Mar 12, 2009 9:54am Mar 12, 2009 9:54am
I'm just a programmer with little to no knowledge of all that statistical math. or even indicator methodology. What you've just said sounds like Greek to me...

what I actually meant by trade walkthrough is something like this.

http://www.forexfactory.com/showpost...42&postcount=1

proper, clear and concise illustrations of entries and exits using charts. I know how to code EAs to think what I'm thinking. But without specific details and understanding, I won't know how to think.

regards,
Zen
Programming for a better future.
  • #17
  • Mar 12, 2009 10:36am Mar 12, 2009 10:36am
Please let me know if this helps
Attached Image(s) (click to enlarge)
Click to Enlarge Name: ea_sample.gif Size: 30 KB
Click to Enlarge Name: ea_sample2.gif Size: 39 KB
  • #18
  • Mar 12, 2009 5:11pm Mar 12, 2009 5:11pm
is there a line by line execution with the MetaEditor like with VBA?

I would like to know why it is not making the trades =1 after an Order Modify or if it is resetting trades to 0 for some reason here

Inserted Code
{ 
                  if  ((line4trades<1) && (StochBuyLine>=StochSellLine && StochBuyLine<=12)  && ( (Open[0] < B_Line4 && Close[0] >= B_Line4)||(Open[0] > B_Line4 && Close[0] <= B_Line4)) && (OrderSymbol()==Symbol() && OrderMagicNumber() == MagicNumber))
                     {  tp = 0;
                        LotSize= 0;
                        LotSize = LotSize() * 6;
                        tp = (takeprofitlower + ((takeprofitupper-takeprofitlower)*(MathRand()/32767)));
                        tp = NormalizeDouble(tp,0); 
                        {ticket = OrderSend(Symbol(),OP_BUY,LotSize, Ask, 3, 0, 0, "Coach Line4Buy",MagicNumber,0,Green);
                           if (OrderSelect(ticket, SELECT_BY_TICKET, MODE_TRADES))
                                 {  Print("BUY order opened : ",OrderOpenPrice());}
                           else
                                 {  Print("Error opening BUY order : ",GetLastError());}
                           { OrderModify(OrderTicket(),OrderOpenPrice() ,0,Ask+tp*Point,0,Green);
                             line4trades = 1;
                             line4ticket = OrderTicket();
                           }
                     }
               }
  • #19
  • Mar 12, 2009 5:16pm Mar 12, 2009 5:16pm
also, can you provide me an example of how to use an array to shorten my code, etc.? I have never taken any programming course.... I have coded in VBA, and the thing with it is I really didn't have to use an array because the spreadsheet is an array that can store the data I need without storing it in an array
  • #20
  • Mar 12, 2009 5:34pm Mar 12, 2009 5:34pm
Quoting coach3131
is there a line by line execution with the MetaEditor like with VBA?
Nope, use the comment function to see what some of your variables are doing.
0 traders viewing now