Attachments: Syntax Help Needed

Syntax Help Needed

#1
First Post: Edited Mar 11, 2009 10:19am Mar 9, 2009 11:12pm | Edited Mar 11, 2009 10:19am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Why does the else give me an unexpected token error?

It should be if Ask > MA_Line do the series of top checks to open an order
else
do the series of bottom checks to open an order... don't understand what is wrong with this syntax

Thanks for your help!

Inserted Code

void OpenMarketOrders()
{
  double MA_Line=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 0,0);
  double S_Line1=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 1,0);
  double S_Line2=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 2,0);
  double S_Line3=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 3,0);
  double S_Line4=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 4,0);
  double U_StopLoss=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0,5,0);
  double L_StopLoss=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0,5,0);
  double B_Line1=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 1,0);
  double B_Line2=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 2,0);
  double B_Line3=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 3,0);
  double B_Line4=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 4,0);
  double StochBuyLine = iStochastic(Symbol(),0,14,3,3,1,1,0,0);
  double StochSellLine = iStochastic(Symbol(),0,14,3,3,1,1,1,0);
  int line1trades=0, line2trades=0, line3trades=0, line4trades=0;
  int ticket;

if (Tradeable==true)
{

if (Ask < MA_Line)
   {
      { if  (line4trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line4 && Close[0] >= B_Line4)||(Open[0] > B_Line4 && Close[0] <= B_Line4)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*6, Ask, 3, 0, 0, "Coach Line4Buy",MagicNumber,0,Green);
         line4trades = 1;
         }      
      

       if  (line3trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line3 && Close[0] >= B_Line3)||(Open[0] > B_Line3 && Close[0] <= B_Line3)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*3, Ask, 3, 0, 0, "Coach Line3Buy",MagicNumber,0,Green);
         line3trades = 1;
         }      
   
       if  (line2trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line2 && Close[0] >= B_Line2)||(Open[0] > B_Line2 && Close[0] <= B_Line2)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*2, Ask, 3, 0, 0, "Coach Line2Buy",MagicNumber,0,Green);
         line2trades = 1;
         }      
      
       if  (line1trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line1 && Close[0] >= B_Line1)||(Open[0] > B_Line1 && Close[0] <= B_Line1)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize, Ask, 3, 0, 0, "Coach Line1Buy",MagicNumber,0,Green);
         line1trades = 1;
         }      
   }
   
else 
   {
      { if  (line4trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line4 && Close[0] >= S_Line4)||(Open[0] > S_Line4 && Close[0] <= S_Line4)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*6, Bid, 3, 0, 0, "Coach Line4Sell",MagicNumber,0,Red);
         line4trades = 1;
         }      

       if  (line3trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line3 && Close[0] >= S_Line3)||(Open[0] > S_Line3 && Close[0] <= S_Line3)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*3, Bid, 3, 0, 0, "Coach Line3Sell",MagicNumber,0,Red);
         line3trades = 1;
         }      
      
       if  (line2trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line2 && Close[0] >= S_Line2)||(Open[0] > S_Line2 && Close[0] <= S_Line2)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*2, Bid, 3, 0, 0, "Coach Line2Sell",MagicNumber,0,Red);
         line2trades = 1;
         }      
      
       if  (line1trades<1 &&StochSellLine>=StochBuyLine && StochBuyLine>=90  && ( (Open[0] < S_Line1 && Close[0] >= S_Line1)||(Open[0] > S_Line1 && Close[0] <= S_Line1)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize, Bid, 3, 0, 0, "Coach Line1Sell",MagicNumber,0,Red);
         line1trades = 1;
         }
       }
   }
}
}
}

#2
Mar 9, 2009 11:41pm Mar 9, 2009 11:41pm

magnumfreak
Joined Nov 2007 | Status: Trying manual mode again | 2,210 Posts

Too many curly brackets.

Inserted Code

void OpenMarketOrders()
{
  double MA_Line=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 0,0);
  double S_Line1=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 1,0);
  double S_Line2=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 2,0);
  double S_Line3=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 3,0);
  double S_Line4=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 4,0);
  double U_StopLoss=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0,5,0);
  double L_StopLoss=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0,5,0);
  double B_Line1=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 1,0);
  double B_Line2=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 2,0);
  double B_Line3=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 3,0);
  double B_Line4=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 4,0);
  double StochBuyLine = iStochastic(Symbol(),0,14,3,3,1,1,0,0);
  double StochSellLine = iStochastic(Symbol(),0,14,3,3,1,1,1,0);
  int line1trades=0, line2trades=0, line3trades=0, line4trades=0;
  int ticket;
  
if (Tradeable==true)
{

if (Ask < MA_Line)
   {
       if  (line4trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line4 && Close[0] >= B_Line4)||(Open[0] > B_Line4 && Close[0] <= B_Line4)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*6, Ask, 3, 0, 0, "Coach Line4Buy",MagicNumber,0,Green);
         line4trades = 1;
         }      
      

       if  (line3trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line3 && Close[0] >= B_Line3)||(Open[0] > B_Line3 && Close[0] <= B_Line3)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*3, Ask, 3, 0, 0, "Coach Line3Buy",MagicNumber,0,Green);
         line3trades = 1;
         }      
   
       if  (line2trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line2 && Close[0] >= B_Line2)||(Open[0] > B_Line2 && Close[0] <= B_Line2)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*2, Ask, 3, 0, 0, "Coach Line2Buy",MagicNumber,0,Green);
         line2trades = 1;
         }      
      
       if  (line1trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=10  && ( (Open[0] < B_Line1 && Close[0] >= B_Line1)||(Open[0] > B_Line1 && Close[0] <= B_Line1)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize, Ask, 3, 0, 0, "Coach Line1Buy",MagicNumber,0,Green);
         line1trades = 1;
         }      
   }
   
else 
   {
     if  (line4trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line4 && Close[0] >= S_Line4)||(Open[0] > S_Line4 && Close[0] <= S_Line4)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*6, Bid, 3, 0, 0, "Coach Line4Sell",MagicNumber,0,Red);
         line4trades = 1;
         }      

       if  (line3trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line3 && Close[0] >= S_Line3)||(Open[0] > S_Line3 && Close[0] <= S_Line3)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*3, Bid, 3, 0, 0, "Coach Line3Sell",MagicNumber,0,Red);
         line3trades = 1;
         }      
      
       if  (line2trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line2 && Close[0] >= S_Line2)||(Open[0] > S_Line2 && Close[0] <= S_Line2)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*2, Bid, 3, 0, 0, "Coach Line2Sell",MagicNumber,0,Red);
         line2trades = 1;
         }      
      
       if  (line1trades<1 &&StochSellLine>=StochBuyLine && StochBuyLine>=90  && ( (Open[0] < S_Line1 && Close[0] >= S_Line1)||(Open[0] > S_Line1 && Close[0] <= S_Line1)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize, Bid, 3, 0, 0, "Coach Line1Sell",MagicNumber,0,Red);
         line1trades = 1;
         }  
       
   }
}

}

#3
Mar 10, 2009 7:04am Mar 10, 2009 7:04am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Ok, using that function above, I need to pass variables into this function.... what is the best way to do that?

Also, what is the best way logically to know what line is being closed so I can change it back to 0?

Where would I put the error handling in each? Once I get the close and error handling, I think my EA should be able to work since I don't have any modify

Inserted Code

void CloseMarketOrders()
{ 
if ClosingBuys
   {  if  (StochBuyLine > 50 && StochSellLine>=StochBuyLine && Ask > B_Line1 && OrderSymbol()=Symbol() && OrderMagicNumber()=MagicNumber)
      while line4trades>0 || line3trades>0 || line2trades>0 || line1trades>0
      OrderClose(ticket);
   }
if ClosingSells
   {  if  (StochSelLine < 50 && StochBuyLine>=StochBuyLine && Bid < S_Line1 && OrderSymbol()=Symbol() && OrderMagicNumber()=MagicNumber)
      while line4trades>0 || line3trades>0 || line2trades>0 || line1trades>0
      OrderClose(ticket);
   }
}

#4
Mar 10, 2009 7:06am Mar 10, 2009 7:06am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Actually, I need to also add the StopLoss line close, but that should be easy once I get a grasp of the overall concept.... thanks

#5
Mar 10, 2009 8:30am Mar 10, 2009 8:30am

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Ok, I made some further modifications.... please help me clean this up so that it includes best practices...

* need to pass variables to the CloseOrders function from OpenOrders function
* label whether a ticket is a buy or sell
* what to add so that an EA knows to monitor trades if for some reason it is MBT is restarted?
*any other recommendation to make sure there is not a hole somewhere
*the best way to handle trading is to have a continual loop checking whether to open or close orders in the start function, correct?
*the answer to these questions will likely help in going a long way to understanding the concepts of Metatrader Programming/Trading

Inserted Code

void CloseMarketOrders()
{ 
if ClosingBuys
   {  if  (StochBuyLine > 50 && StochSellLine>=StochBuyLine && Ask > B_Line1 && OrderSymbol()=Symbol() && OrderMagicNumber()=MagicNumber)
      while line4trades>0 || line3trades>0 || line2trades>0 || line1trades>0
      OrderClose(ticket);
      if (ticket = line4ticket) line4trades=0;
      if (ticket = line3ticket) line3trades=0;
      if (ticket = line2ticket) line2trades=0;
      if (ticket = line1ticket) line1trades=0;
   }
if ClosingSells
   {  if  (StochSelLine < 50 && StochBuyLine>=StochBuyLine && Bid < S_Line1 && OrderSymbol()=Symbol() && OrderMagicNumber()=MagicNumber)
      while line4trades>0 || line3trades>0 || line2trades>0 || line1trades>0
      OrderClose(ticket);
      if (ticket = line4ticket) line4trades=0;
      if (ticket = line3ticket) line3trades=0;
      if (ticket = line2ticket) line2trades=0;
      if (ticket = line1ticket) line1trades=0;
   }
}

double LotSize()
{
     double lotMM = MathCeil(AccountFreeMargin() *  Risk / 1000) / 100;
     return (lotMM);
}



void OpenMarketOrders()
{
  double MA_Line=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 0,0);
  double S_Line1=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 1,0);
  double S_Line2=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 2,0);
  double S_Line3=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 3,0);
  double S_Line4=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0, 4,0);
  double U_StopLoss=iCustom(NULL,0,"MA+StdDev",MA_Period, 1, 6, 0,5,0);
  double L_StopLoss=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0,5,0);
  double B_Line1=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 1,0);
  double B_Line2=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 2,0);
  double B_Line3=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 3,0);
  double B_Line4=iCustom(NULL,0,"MA-StdDev",MA_Period, 1, 6, 0, 4,0);
  double StochBuyLine = iStochastic(Symbol(),0,14,3,3,1,1,0,0);
  double StochSellLine = iStochastic(Symbol(),0,14,3,3,1,1,1,0);
  int line1trades=0, line2trades=0, line3trades=0, line4trades=0;
  int ticket;
  double LotSize = LotSize();
  bool Tradeable = true;
    
if (LotSize()<0.01*xecn) LotSize=0.01*xecn;
if (LotSize()>100) LotSize=100; 

if (Tradeable==true)

{

if (Ask < MA_Line)
   {
      { if  (line4trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=12  && ( (Open[0] < B_Line4 && Close[0] >= B_Line4)||(Open[0] > B_Line4 && Close[0] <= B_Line4)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*6, Ask, 3, 0, 0, "Coach Line4Buy",MagicNumber,0,Green);
         line4trades = 1;
         line4ticket = ticket;
         }      
      

       if  (line3trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=12  && ( (Open[0] < B_Line3 && Close[0] >= B_Line3)||(Open[0] > B_Line3 && Close[0] <= B_Line3)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*3, Ask, 3, 0, 0, "Coach Line3Buy",MagicNumber,0,Green);
         line3trades = 1;
         line3ticket = ticket;
         }      
   
       if  (line2trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=12  && ( (Open[0] < B_Line2 && Close[0] >= B_Line2)||(Open[0] > B_Line2 && Close[0] <= B_Line2)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize*2, Ask, 3, 0, 0, "Coach Line2Buy",MagicNumber,0,Green);
         line2trades = 1;
         line2ticket = ticket;
         }      
      
       if  (line1trades<1 &&StochBuyLine>=StochSellLine && StochBuyLine<=12  && ( (Open[0] < B_Line1 && Close[0] >= B_Line1)||(Open[0] > B_Line1 && Close[0] <= B_Line1)))
         {ticket = OrderSend(Symbol(),OP_BUY,LotSize, Ask, 3, 0, 0, "Coach Line1Buy",MagicNumber,0,Green);
         line1trades = 1;
         line1ticket = ticket;
         }      
      }
   }
else 
   {
      { if  (line4trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line4 && Close[0] >= S_Line4)||(Open[0] > S_Line4 && Close[0] <= S_Line4)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*6, Bid, 3, 0, 0, "Coach Line4Sell",MagicNumber,0,Red);
         line4trades = 1;
         line4ticket = ticket;
         }      

       if  (line3trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line3 && Close[0] >= S_Line3)||(Open[0] > S_Line3 && Close[0] <= S_Line3)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*3, Bid, 3, 0, 0, "Coach Line3Sell",MagicNumber,0,Red);
         line3trades = 1;
         line3ticket = ticket;
         }      
      
       if  (line2trades<1 &&StochSellLine>=StochBuyLine && StochSellLine>=90  && ( (Open[0] < S_Line2 && Close[0] >= S_Line2)||(Open[0] > S_Line2 && Close[0] <= S_Line2)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize*2, Bid, 3, 0, 0, "Coach Line2Sell",MagicNumber,0,Red);
         line2trades = 1;
         line2ticket = ticket;
         }      
      
       if  (line1trades<1 &&StochSellLine>=StochBuyLine && StochBuyLine>=90  && ( (Open[0] < S_Line1 && Close[0] >= S_Line1)||(Open[0] > S_Line1 && Close[0] <= S_Line1)))
         {ticket = OrderSend(Symbol(),OP_SELL,LotSize, Bid, 3, 0, 0, "Coach Line1Sell",MagicNumber,0,Red);
         line1trades = 1;
         line1ticket = ticket;
         }
      }
   }
}

#6
Mar 10, 2009 11:42am Mar 10, 2009 11:42am

Zen_Leow
Joined Jun 2008 | Status: Programming for a better future. | 652 Posts

Is that the full code? Where's the start function?

Programming for a better future.

#7
Edited 11:40pm Mar 10, 2009 12:15pm | Edited 11:40pm

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

Ok, this is the full code

It is very close and I am sure within ten minutes you will be able to provide best practices advice and help me solve the last handful of things

* I have two errors that are the same because it is not recognizing the ticket variable to close the order
* do I need a continuous loop in the start section since it is just checking two functions?
* where should I add error handling?
* what happens if MetaTrader is restarted? what do I need to do for it know what trades are open and at what lines?

*I will come up what I will do with the tradeable function (i.e., don't trade on Fridays, but manage trades still open on Friday... and to not trade if not enough funds)
*I will add in hidden tp and sl

Attached File(s)

Coach StdDev.mq4 10 KB | 277 downloads

#8
Last Post: Mar 11, 2009 12:34pm Mar 11, 2009 12:34pm

coach3131
| Joined Feb 2009 | Status: Trader | 122 Posts

I think I fixed the ticket problem.... can someone please check that and provide input on the other remaining things?

it should be less than 10 minutes for someone with experience to notate the necessary changes.... this one is compiling with no errors so it should be a lot easier to deal with now

Attached File(s)

Coach StdDev.mq4 10 KB | 322 downloads

Platform Tech
/
Syntax Help Needed
Reply to Thread

0 traders viewing now

Options

Similar Threads

Syntax Help Needed