Symbols Check Function | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

case code function- can someone check this over? thank you 1 reply

Any built in function to check for symbol suffix 1 reply

stop loss function and edit time function for Breakout EA 1 reply

Possible to add more currency pairs/symbols? 5 replies

Attachments: Symbols Check Function
Exit Attachments

Symbols Check Function

  • #1
  • First Post: Mar 8, 2009 12:01am Mar 8, 2009 12:01am
I found this function in another thread.... How can I transfer this to a library for it work? When I put it in one and put it inside of a start function, it gives me errors... also, is there a way to do it without using a Global variables?

Global Variables
Inserted Code
string Symbols[];
int SymbolCount;

Inserted Code
//+------------------------------------------------------------------+
//| Creates the array of pair symbols to check                       |
//+------------------------------------------------------------------+   
string CreateSymbolList()
  {
   string allsyms;
   string Currencies[] = {"AED", "AUD", "BHD", "BRL", "CAD", "CHF", "CNY", "CYP", "CZK", "DKK", "DZD", "EEK", "EGP", "EUR", "GBP", "HKD", "HRK", "HUF", "IDR", "ILS", "INR", "IQD", "IRR", "ISK", "JOD", "JPY", "KRW", "KWD", "LBP", "LTL", "LVL", "LYD", "MAD", "MXN", "MYR", "NOK", "NZD", "OMR", "PHP", "PLN", "QAR", "RON", "RUB", "SAR", "SEK", "SGD", "SKK", "SYP", "THB", "TND", "TRY", "TWD", "USD", "VEB", "XAG", "XAU", "YER", "ZAR"};
   int CurrencyCount = ArrayRange(Currencies, 0);
   int Loop, SubLoop;
   string TempSymbol;
   for(Loop = 0; Loop < CurrencyCount; Loop++)
       for(SubLoop = 0; SubLoop < CurrencyCount; SubLoop++)
         {
           TempSymbol = Currencies[Loop] + Currencies[SubLoop];
           if(MarketInfo(TempSymbol, MODE_BID) > 0)
             {
               ArrayResize(Symbols, SymbolCount + 1);
               Symbols[SymbolCount] = TempSymbol;
               allsyms = allsyms + TempSymbol +"n";
               SymbolCount++;
             }
             
           TempSymbol = Currencies[Loop] + Currencies[SubLoop] +"m";
           if(MarketInfo(TempSymbol, MODE_BID) > 0)
             {
               ArrayResize(Symbols, SymbolCount + 1);
               Symbols[SymbolCount] = TempSymbol;
               allsyms = allsyms + TempSymbol +"n";
               SymbolCount++;
             }
         }
   return(allsyms);
  }
  • #2
  • Mar 8, 2009 12:56am Mar 8, 2009 12:56am
if you want help debugging an error, you should at least state what the error is.

when you place the codes in a library, did you import that library to your EA or indicator to use it?
Programming for a better future.
  • #3
  • Mar 8, 2009 1:03am Mar 8, 2009 1:03am
I would like to connect that with an array like this

string Timeframe[] = {PERIOD_M1, PERIOD_M15, PERIOD_M30, PERIOD_H1, PERIOD_H4}

Thus, I can check all these timeframes for all symbols.... I need for it to store some data in a complex array... one being when it hit a line on the chart (dynamic moving, but have indicator for it).... and also clocking that time between when hitting that line and another line... time being in minutes

I am wanting it to determine the best currency/timeframe combinations based on some ratios from the storage data
  • #4
  • Mar 8, 2009 1:05am Mar 8, 2009 1:05am
no,

I just bracketed it with the init start () { function} to compile and test it... without that, it says that it needs the start function
  • #5
  • Mar 8, 2009 3:37am Mar 8, 2009 3:37am
why not just manually populate the array with symbols your broker offers? I mean really, are there more than 10-12 you want to look at anyway??
  • #6
  • Edited 7:27am Mar 8, 2009 7:14am | Edited 7:27am
Because I would like to learn how to make each element dynamic that I can think of so when I move on to EA #2, #3, #4, etc. that they are built dynamic and can be used by anyone as is.... figured it would be good practice not to leave things manual that can otherwise not be

diversification is another element of money/risk management... since this is already a written function I found, thought it would be good to incorporate into a library... if I learn how to put this into a library, then it teaches the basic concept of moving all functions into a library and thus eliminating the big chunks of code to make it easier to see and read what is going on in the EA

I have done that with VBA coding.... I call the functions in the base code so it has very few lines... each piece of code is segmented and named so I know what it is doing easily and go back and fix errors just in that area.... I greatly appreciate the help in trying to get me up to speed with this... sorry if this is a big deal... thought it was something small that could be altered in that code for use in a library
Attached File(s)
File Type: mq4 SymbolsList.mq4   2 KB | 200 downloads
  • #7
  • Mar 9, 2009 5:29pm Mar 9, 2009 5:29pm
Would it be possible for someone with experience creating a library to be able to tell me why this wasn't able to be compiled as a library so I can learn for the future? Thanks so much! I really like the help you guys are giving and I hope to be able to help others when I get a better grasp of the code and best practices for forex
  • #8
  • Mar 9, 2009 7:09pm Mar 9, 2009 7:09pm
because the code has not been identified as a library in the preprocessor directives.

Near the top there are a few listed that start with #property, add

#property library

there is a ton of information in the help files that can answer about 99% of your questions.
  • #9
  • Last Post: Mar 9, 2009 7:28pm Mar 9, 2009 7:28pm
thanks.... some of the stuff in the help files is greek so they do no good when I want something in layman's terms or that is not defined there... I can understand the greek after understanding the English first because I can matchup concepts to it... sorry that I ask a million questions, but it is very difficult to code my first EA correctly without being able to question an experienced programmer in this environment... Metatrader is new to me, and this programming language is new to me...
0 traders viewing now