Coding Problem: Open[1] > EMA12

I am having some difficulty in programing a line in my EA. I'm looking to have one of the opening conditions be that the open of the previous bar be greater than the 12 EMA. I'm doing this to try and not open trades in a sideways trending market.

Here is the actual code line:

if((Close[2] >= Close[1]) && (Open[1] >= Open[0]) && (Open[1] > ema12) && (ema12 > ema24))upcandle = true;

The ema12>ema24 code works just fine, but the Open[1] > ema12 does not work. In back testing there are several occasions where a trade is opened below the ema12.

Suggestions???

Thanks!

Open[1] is the open price of the previous bar...

It's possible for the current bar to have gone below the 12ema

Also, what is the shift for the EMA12 variable? Is it 0 or 1?

show us the whole code

Ronald - I tried adding a shift to the EMA, but only ended up with an error result from it "unexpected [ ".

I have attached an image showing how the system is supposed to work in the first trade displayed. The second trade should never have occurred because the open of the trigger bar [1] is below the 12 ema line.

And Oksana, as per your request:

//+------------------------------------------------------------------+
//| Safe Pip EA.mq4 |
//| Skeebo |
//| |
//+------------------------------------------------------------------+
#property copyright "Skeebo"
#property link ""

extern double Lots = 0.1;
extern double StopLoss = 15;

extern double TakeProfit = 15;
extern double MaxTotalOrders = 1;
extern double MaxOmegaIBOrders= 1;
extern bool MakeTrades = True;
extern bool NoisyAlerts = True;
extern int TrailingStop = 10;
extern int BreakEven = 6;
extern int maxLots=1;

//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
static int order_num = -1;
int init()
{
//----

order_num = -1;
//----
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----

return(0);
}



//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
//----
int cnt, ticket, total;

double ema12, ema24;

//---- Move to break even Set



//---- Ema lines defined

ema12=iMA(NULL,0,12,0,MODE_EMA,PRICE_CLOSE,0);
ema24=iMA(NULL,0,24,0,MODE_EMA,PRICE_CLOSE,0);




//---- Check to see if there is a signal candle

bool upcandle = false;
bool downcandle = false;

if((Close[2] >= Close[1]) && (Open[1] >= Open[0]) && (Open[1] > ema12) && (ema12 > ema24))upcandle = true;
if((Close[1] < Open[0])&& (High[1] < ema12)) downcandle = true;




// check for buy or sell signal
bool buy = false;
bool sell = false;

// If the asking price in the current bar is greater than 2 pips than the second previous candle and the 12ema
// is over the 24 ema then it is a buy signal
if((Ask == High[2] + 3*Point) && (ema12 > ema24)) buy = true;
// If the bidding price in the current bar is less than 2 pips than the second previous candle and the 12ema
// is below the 24 ema then it is a buy signal
if(((Low[2] == Bid) > 2*Point) && (ema24 > ema12)) sell = true;


if(upcandle)

ObjectCreate("upcandle"+Time[1],OBJ_ARROW,0,Time[1],Low[1]-2*Point);

total=OrdersTotal();

if(total<1)

if(buy)

{

ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,0,Ask-StopLoss*Point,Ask+TakeProfit*Point, "SafePip", 12345,0, Green);

ObjectCreate("buyl"+Time[1],OBJ_RECTANGLE,0,Time[0] - (Time[0]-Time[1])*0.5,Low[0]-2*Point, Time[0] + (Time[0]-Time[1])*0.5, Low[0]-2.5*Point);
if(NoisyAlerts) PlaySound("alert.wav");

if(ticket>0)

{

if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))

Print("BUY order opened:",OrderOpenPrice());

}

else Print("Error opening BUY order:",GetLastError());

return(0);

if (BreakEven>0)
{
if(Bid-OrderOpenPrice()>Point*BreakEven)
{
if(OrderStopLoss()<OrderOpenPrice())
{
OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+Point*1,OrderTakeProfit(),0,Gray);
}
}
}
/* update trailing stop */
if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>Point*(TrailingStop))
{
if(OrderStopLoss()<Bid-Point*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Gray);
return(0);
}
}
}
}



}



return(0);




//+------------------------------------------------------------------+

It is a work in progress, and there are things that I'm already slating to change. I know there is no coding for a close condition, right now I'm just using the TP or SL levels.

The problem is most likely from the fact that you are calculating the EMA on the current candle and using the open of the previous candle to determine entry point. Change your ema settings to look at the previous candle as well:

ema12=iMA(NULL,0,12,0,MODE_EMA,PRICE_CLOSE,1);
ema24=iMA(NULL,0,24,0,MODE_EMA,PRICE_CLOSE,1);