Working through midnight? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Fibos Midnight 2 midnight 3 replies

Midnight to midnight Floor pivots 4 replies

2 trades everyday entered at midnight GMT 8 replies

Midnight Retrace Journal 5 replies

How to open trade at midnight? 4 replies

Working through midnight?

  • #1
  • First Post: Feb 5, 2009 7:01pm Feb 5, 2009 7:01pm
I'm trying to add a few new functions for Generic Breakout Version 5.

1) Getting the EA to work through midnight.

Currently, if I set the start time to 20 and the end time to 1, the EA freaks out. How do I make it so that I can use the above times?
  • #2
  • Feb 5, 2009 7:14pm Feb 5, 2009 7:14pm
Start reading at post #9

http://www.forexfactory.com/showthread.php?t=148743
  • #3
  • Feb 5, 2009 8:35pm Feb 5, 2009 8:35pm
I've just written now a function to do it.
(have not tested it, but I think it will work)

What you have to is just to throw StartHour & EndHour to the function.
Read the comment included in the code.

PHP Code
//+------------------------------------------------------------------+
//| IsTimeOK
//+------------------------------------------------------------------+
bool IsTimeOK(int StartHour, int EndHour)
{
   bool TimeOK = false;

   if(StartHour < EndHour) // example) StartHour = 3, EndHour = 20;
   {
      if(Hour() >= StarHour && Hour() < EndHour) TimeOK = true; // return true when Hour() is 3,4,5....18,19
   }

   if(StartHour > EndHour) // example) StartHour = 20, EndHour = 3;
   {
      if(Hour() >= EndHour && Hour() >= StartHour) TimeOK = true; // return true when Hour() is 20,21,22,23
      if(Hour() < EndHour) TimeOK = true; // return true when Hour() is 0,1,2
   }

   return(TimeOK);
}
  • #4
  • Feb 5, 2009 9:07pm Feb 5, 2009 9:07pm
Dont think this will work. what happens when starthour=20 and endhour=4? - Hour() will report 22-24 then 0-4. how are you crossing the 24 hour time?

Quoting lohikeitto
I've just written now a function to do it.
(have not tested it, but I think it will work)

What you have to is just to throw StartHour & EndHour to the function.
Read the comment included in the code.

[php]
//+------------------------------------------------------------------+
//| IsTimeOK
//+------------------------------------------------------------------+
bool IsTimeOK(int StartHour, int EndHour)
{...
  • #5
  • Feb 5, 2009 9:22pm Feb 5, 2009 9:22pm
I'm pretty sure you'd have to factor in the day of the week in the math if you plan to cross the 24 hour barrier. Perhaps take the day of the week and multiply it by 24. Then just specify a start time, convert to this frame, and specify a length of time to trade.
  • #6
  • Feb 5, 2009 10:05pm Feb 5, 2009 10:05pm
Ok, How about this?
As I tested a bit, seems to work correctly.

PHP Code
//+------------------------------------------------------------------+
//| IsTimeOK
//+------------------------------------------------------------------+
bool IsTimeOK(int StartHour, int EndHour)
{
   bool TimeOK = false;

   if(StartHour < EndHour) // example) StartHour = 3, EndHour = 20;
   {
      if(Hour() >= StartHour && Hour() < EndHour) TimeOK = true; // return true when Hour() is 3,4,5....18,19
   }

   if(StartHour > EndHour) // example) StartHour = 20, EndHour = 3;
   {
      int HOUR = Hour() % 24;
      if(HOUR >= EndHour && HOUR >= StartHour) TimeOK = true; // return true when Hour() is 20,21,22,23
      if(HOUR < EndHour) TimeOK = true; // return true when Hour() is 0,1,2
   }

   return(TimeOK);
}
  • #7
  • Feb 5, 2009 10:11pm Feb 5, 2009 10:11pm
Yeh, that's true. You could just do (hour >= 20 OR hour <= 6) if you want to code in the hours.
  • #8
  • Feb 5, 2009 10:24pm Feb 5, 2009 10:24pm
yep. 3 to 20 will work (the demo). try to cross the 24 hour line. try 20 to 7.

Quoting lohikeitto
Ok, How about this?
As I tested a bit, seems to work correctly.

[php]
//+------------------------------------------------------------------+
//| IsTimeOK
//+------------------------------------------------------------------+
bool IsTimeOK(int StartHour, int EndHour)
{...
  • #9
  • Last Post: Feb 6, 2009 12:08am Feb 6, 2009 12:08am
Quoting Rabid
Yeh, that's true. You could just do (hour >= 20 OR hour <= 6) if you want to code in the hours.
You are right Rabid,

I get all together and shorten the code.

PHP Code
//+------------------------------------------------------------------+
//| IsTimeOK
//+------------------------------------------------------------------+
bool IsTimeOK(int StartHour, int EndHour)
{
   int HOUR = Hour() % 24;
   
   // example) StartHour = 3, EndHour = 20; // return true when Hour() is 3,4,5....18,19
   if(StartHour < EndHour && HOUR >= StartHour && HOUR < EndHour) return(true); 

   // example) StartHour = 20, EndHour = 3; // return true when Hour() is 0,1,2 or 20,21,22,23
   if( StartHour > EndHour && (HOUR >= StartHour || HOUR < EndHour) ) return(true); 

   return(false);
}
0 traders viewing now