help with 5 digit broker recode | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

4 Digit & 5 Digit Brokers 11 replies

Adjusting an EA from 4 digit to 5 digit broker 56 replies

migrating from 4-digit to 5-digit broker. help! 0 replies

5 Digit price in 4 digit broker backtest 0 replies

Detecting 4 digit vs 5 digit broker 2 replies

Attachments: help with 5 digit broker recode
Exit Attachments

help with 5 digit broker recode

  • #1
  • First Post: Edited Jan 27, 2009 8:14pm Jan 23, 2009 3:55pm | Edited Jan 27, 2009 8:14pm
anybody want to try and recode so it works on 4 or 5 digit brokers? like a true/false option of some sort looks like it may have potential and would like to throw some ideas around so it can scalp 2-5 pips at a time, time of day, no trade Friday etc etc? any programmers welcome to take a look at it some guy tested it on a one minute chart and this is what he got.
  • #2
  • Jan 23, 2009 5:09pm Jan 23, 2009 5:09pm
I don't know if it will be of use in your particular case, but here is a code I found that finally solved that digit problem for several of the indicators I use, that are based on "Point" value. It has to be included inside the initialization part of the code.

Inserted Code
[b]int init()
{ 
[/b]//Checking for unconventional Point digits number
   if (Point == 0.00001) Poin = 0.0001; //5 digits
   else if (Point == 0.001) Poin = 0.01; //3 digits
   else Poin = Point; //Normal
   return(0);
[b]}[/b]
It means that you also have to declare a variable named "Poin" (or whatever you wish to use in its place) and rename "Point" to "Poin" wherever it appears in the code:

Inserted Code
[b]double[/b] Poin;
This way the indicator or EA will work with any broker independently of its digits.

Hope it will help.
  • #3
  • Jan 23, 2009 5:23pm Jan 23, 2009 5:23pm
You should also look in the property Digits
This will help you in normalizing and in other functions
  • #4
  • Jan 23, 2009 6:18pm Jan 23, 2009 6:18pm
easy. - 100% Auto

double xecn=1;
if(Digits==3||Digits==5){xecn=10;}

multiply all TP and SL references by xecn.

(TakeProfit*xecn)*Point
  • #5
  • Jan 23, 2009 11:18pm Jan 23, 2009 11:18pm
if ever you use MarketInfo to get the spread from the broker, remember to divide by the pip factor (xecn according to Fulltime247) as well.

that's cos for fractional broker's servers, 2.5 pips spread actually returns 25.

regards,
Zen
Programming for a better future.
  • #6
  • Edited 10:42pm Jan 26, 2009 3:23pm | Edited 10:42pm
ok, believe I got that one. but now whenever i try to change the default start and stop time, it won't back test any suggestions on how i can use a different format for start and stop times and a no trade Friday option? how do I get that one? not a coder so this is all new to me!
  • #7
  • Jan 27, 2009 3:01am Jan 27, 2009 3:01am
Inserted Code
extern FridayTrading==false;

tradeok=1; //Check local time on your computer
if(FridayTrading==false && TimeDayOfWeek(TimeLocal())==6){tradeok=0;}


if (tradeok==1 && ... && ...)
  • #8
  • Edited 8:15pm Jan 27, 2009 3:06am | Edited 8:15pm
cool man! will add it but now down to the time filter problem. why won't trade from say start time 22 and stop time 6 when i back test? it's cool when i use the defualt start 6 and stop 24 deos this has something to do with the way the time filter is set up
  • #9
  • Jan 27, 2009 3:44am Jan 27, 2009 3:44am
It doesnt trade because 24hr time doesnt wrap around. cant go 22 to 6. only 22 to 24 then 0 to 6.
  • #10
  • Jan 27, 2009 3:49am Jan 27, 2009 3:49am
you're are right! then how do people do it? i mean if trades from 21:00(09:00pm) to 04:00am how would that be coded i guess would be the question?? i've seen EA's that do it. tried to copy it but no luck of course
  • #11
  • Jan 27, 2009 4:12am Jan 27, 2009 4:12am
and all of that goes in the entry settings or part in the entry setting and the rest in the int area? thanks for all the help! learned a lil bit!
  • #12
  • Jan 27, 2009 4:23am Jan 27, 2009 4:23am
look at code - both Fri and time.
  • #13
  • Jan 27, 2009 4:35am Jan 27, 2009 4:35am
ahh got it! alright that'll do it
  • #14
  • Edited 4:48am Jan 27, 2009 4:38am | Edited 4:48am
Inserted Code
//Put at top with other externs
extern STARTHour=21;  //9pm - Using your local computer time
extern WORKHours=7; //till 4 am
extern FridayTrading==false;

//add to list of variables after the externs
double timestop;

//add after first few lines of code near top - (before //variables in start() section seems ok)
if(TimeHour(TimeLocal())>=STARTHour&&TimeCurrent()<timestop){timestop=TimeCurrent()+(WORKHours*(60*60));}


//with the other tradeok checks
tradeok=1;
if(TimeCurrent()>=timestop||timestop==0){tradeok=0;}
if(FridayTrading==false && TimeDayOfWeek(TimeLocal())==6){tradeok=0;}

if (tradeok==1 && ... && ...)

kool now. forgot the = on the hour check. it also needs a couple lines to NOT start trading on the first night before the hour. I'll add em tmmrw. after that it will shut off / turn on normally

FIXED: its good 2 go.
  • #15
  • Jan 27, 2009 8:19pm Jan 27, 2009 8:19pm
ok, will use. i wonder what was happening! thanks again!
  • #16
  • Jan 29, 2009 4:23pm Jan 29, 2009 4:23pm
Inserted Code
 
//Put at top with other externs
extern STARTHour=21;  //9pm - Using your local computer time
extern WORKHours=7; //till 4 am
extern FridayTrading==false;

//add to list of variables after the externs
double timestop;

//add after first few lines of code near top - (before //variables in start() section seems ok)
if(TimeHour(TimeLocal())>=STARTHour&&TimeCurrent()<timestop){timestop=TimeCurrent()+(WORKHours*(60*60));}


//with the other tradeok checks
tradeok=1;
if(TimeCurrent()>=timestop||timestop==0){tradeok=0;}
if(FridayTrading==false && TimeDayOfWeek(TimeLocal())==5){tradeok=0;}

if (tradeok==1 && ... && ...)

DEBUGGED!! - oops 0=Sunday / Friday=5 - Had it set to 6 for no SAT Trading/
  • #17
  • Jan 29, 2009 4:30pm Jan 29, 2009 4:30pm
ahh, thanks again!
  • #18
  • Jun 10, 2009 7:25am Jun 10, 2009 7:25am
Quoting Zen_Leow
if ever you use MarketInfo to get the spread from the broker, remember to divide by the pip factor (xecn according to Fulltime247) as well.

that's cos for fractional broker's servers, 2.5 pips spread actually returns 25.

regards,
Zen
order execution style will now be switched to 'market'
Now my EA does not work . Can anyone help in getting working again with this new feed .?Can somone update the settings in my EA to accommodate this change. But i do no know how ..
Please help Thank you
[color=#22229c][email protected][/color]
  • #19
  • Jun 10, 2009 7:26am Jun 10, 2009 7:26am
Quoting Fulltime247
easy. - 100% Auto

double xecn=1;
if(Digits==3||Digits==5){xecn=10;}

multiply all TP and SL references by xecn.

(TakeProfit*xecn)*Point
order execution style will now be switched to 'market'
Now my EA does not work . Can anyone help in getting working again with this new feed .?Can somone update the settings in my EA to accommodate this change. But i do no know how ..
Please help Thank you
[color=#22229c][email protected][/color]
  • #20
  • Last Post: Jan 12, 2012 6:41am Jan 12, 2012 6:41am
I've done all recomended code but I still got a problem in live running. I always get error 130. This EA is running well in backtesting as well as in 4 digits environment. It is also only display 4 digits at the logs.
It would be appreciated if anyone could help me on this mater. The EA is attached.
Attached File(s)
File Type: mq4 Running-GBPUSD-02.mq4   19 KB | 299 downloads
0 traders viewing now