Dunce Needs An Order Placement Script :-)

Hi to all you clever coders,

I have to admit that I know nothing about coding or scripts on MT4 and I am sure what I would like is very simple to those with the necessary knowledge.

All I want is to be able to place a trade with one click without having to manually calculate S/L, T/P etc. ... can't be too hard !

I am trading on the 1minute T/F and would like to be able to (in a simple click) enter a trade which will AUTOMATICALLY do the following :

1. Close all Current Open Trades
2. Then place the following (at current Market Price):
3. Place Order 1 with 15 pip S/L and a +10 T/P
4. Place Order 2 with 15 pip S/L and once it hits +10 pips move the S/L to breakeven

I want to close Order 2 manually (unless S/L hit).

I would think two scripts would be needed (1 for Buy and 1 for Sell) with adjustable lot sizes and S/L and T/P settings option.

If anyone fancies helping me then it would be greatly appreciated, - please either post or PM me if you can help.

Thanks

Willowgal

.......

Help !! I am sure someone can help me ??

Thanks

OK Miss Willow: These have code to try to accomodate the "m" suffix on IBFXs mini-account (not very fancy, but it might work). I think it works ok. It does not have code to handle the "new improved" 5 digits, so that may cause a problem. Edit the code and set your tp and sl for whatever you want. Run it twice to get the 2 orders filled. I do not have a script to set the trailing sl but maybe someone else here can provide that. Ken.
ps: Look on forex-tsd for that other script.
Also, you can set a hotkey to run these.
ps2: These might be hard coded for euro, if so it is easy to change them to whatever chart it is running on.

Thanks Kenz,

I have modified the SL/TP/Lot size values for my needs and also the hard coded currency pair to "EURJPY" as that is what I am trading at the moment.

I moved the files into scripts, compiled with no errors but I cannot get them to trade by attaching to chart or gradding on.

I assume I must have a setting wrong in MT4 ?
In Option I have the following boxes clicked:

1. Enable Expert Advisors
2. Allow Live Trading
3. Allow DLL imports
4. Allow external experts imports

Neither the Buy or Sell scripts do anything when I try them.

ANyone got any wisdom ?

Thanks

Willowgal

Is there an error message in the Experts tab? What broker are you using? - some do not allow the sl tp to be entered with the main order - BroCo is one of them.
Also, are the prices correct in the print line? If they are zero, then the get market info is not working.
ps: If you have 5 digits (or 3 for yen), add an extra 0 to the tp sl and slippage.

Make sure you've "allow live trading" box ticked in the Tools -> Options -> Expert Advisor (tab)

scripts don't prompt you for this settings like EA does so it always takes the default settings used in that tab. make sure you have it tick else all order placement or deletion via scripts won't work.

regards,
Zen

Thanks Ken ... that shows I don't know much about running scripts as I was not aware that a log goes into the Experts tab.

I am getting an error on OrderSend(131), invalid trade volume.

I had lots set to 0.01 ... will try with a bigger lot size as that may be it ?

I tried it with a different lot size and this time I got a different error - Invalid stops.

I am testing on a Demo a/s with FX Pro and Alpari.

The code is below so if anyone can help then I would be very grateful. I have also printed the error I got when I ran it this time.

Thanks again,

Willowgal

Code:
//+------------------------------------------------------------------+
//| based on zBuyMkt.mq4
//+------------------------------------------------------------------+
#property copyright "z"
#property link "z"
#include <stdlib.mqh>
string sScriptName = "zBuyEURJPY";
int iTakeProfit = 15;
int iStopLoss = 15;
int iSlippage = 3;
double dLots = 0.1;
int iTicket = 0;
int iError = 0;
double dSL = 0;
double dTP = 0;
string sLineOut = "x";
bool bWriteLogFile = false;
string sFileName = "TradeLogTradeLog.csv";
int iFileHandle = 0;
bool bRtn = false;
string sSymbol = "x";
int iLenSymbol = 0;
string sDoThisSymbol = "EURJPY";
double dBidXY = 0;
double dAskXY = 0;
double dPoint = 0;
int iDigits = 0;

//double bid =MarketInfo("EURUSD",MODE_BID);
//double ask =MarketInfo("EURUSD",MODE_ASK);
//double point =MarketInfo("EURUSD",MODE_POINT);
//int digits=MarketInfo("EURUSD",MODE_DIGITS);
//int spread=MarketInfo("EURUSD",MODE_SPREAD);

int start() {
sSymbol = Symbol(); //see what chart is open - dont care as long as it is a valid chart
iLenSymbol = StringLen(sSymbol);
if(iLenSymbol < 6 || iLenSymbol > 7) {
sLineOut = "Error: Chart symbol is not valid (ie could be a tick chart): " + sSymbol;
fctLogAction(sLineOut);
return(-1);
}
if(iLenSymbol == 6) {
sSymbol = sDoThisSymbol;
} else {
sSymbol = sDoThisSymbol + "m";
}
dBidXY = MarketInfo(sSymbol,MODE_BID);
dAskXY = MarketInfo(sSymbol,MODE_ASK);
iDigits = MarketInfo(sSymbol,MODE_DIGITS);
dPoint = MarketInfo(sSymbol,MODE_POINT);
dSL = dBidXY - iStopLoss * dPoint;
dTP = dAskXY + iTakeProfit * dPoint;
sLineOut = "Sending Buy order for symbol," + sSymbol + ", lots," + DoubleToStr(dLots,2) + ", ask," + DoubleToStr(dAskXY,iDigits) + ", sl," + DoubleToStr(dSL,iDigits) + ", tp," + DoubleToStr(dTP,iDigits);
fctLogAction(sLineOut);
//Print("info: ", sSymbol, ", ", DoubleToStr(dBidXY,iDigits), ", ", DoubleToStr(dAskXY,iDigits), ", " , iDigits, ", " ,DoubleToStr(dPoint,5));
iTicket = OrderSend(sSymbol,OP_BUY,dLots,dAskXY,iSlippage,dSL,dTP,"HotKeyBuy",0,0,CLR_NONE );
if(iTicket > 0) {
sLineOut = "Buy order filled for symbol," + sSymbol + ", ticket," + iTicket + ", current ask, " + DoubleToStr(dAskXY,iDigits);
fctLogAction(sLineOut);
return(0);
}
iError=GetLastError();
if(iError == 132) {
sLineOut = "Error on OrderSend - MARKET IS CLOSED.";
fctLogAction(sLineOut);
return(-1);
}
if(iError == 134) {
sLineOut = "Error on OrderSend - NOT ENOUGH MONEY.";
fctLogAction(sLineOut);
return(-1);
}
sLineOut = "Error on OrderSend(" + iError + "), " + ErrorDescription(iError);
fctLogAction(sLineOut);
return(0);
}

void fctLogAction(string psLineOut){
Print(psLineOut);
if(bWriteLogFile == false) return;
iFileHandle = FileOpen(sFileName, FILE_READ|FILE_WRITE|FILE_CSV, ";");
bRtn = FileSeek(iFileHandle, 0, SEEK_END);
if(bRtn == false) {
iError=GetLastError();
Print("Error of file open/seek, ", iError , ErrorDescription(iError));
return;
}
FileWrite(iFileHandle, TimeToStr(CurTime(), TIME_DATE|TIME_SECONDS), sScriptName, psLineOut);
FileClose(iFileHandle);
return;
}

Sorry to butt in, but maybe this will help?

http://www.forexfactory.com/showthread.php?t=9553

Please butt in all you like if you can help me

Thanks dod - looks interesting but I think I will need to read the thread first - do you use this yourself ?

The new decimalization is going to "wreak Havoc" on lots of code!!!

Change:
int iTakeProfit = 15; // this means 1.5 pips on the "new" scheme - not valid
int iStopLoss = 15; // gives an error of "invalid stops"
int iSlippage = 3;
To:
int iTakeProfit = 150; //implied 15.0 pips on FxPro
int iStopLoss = 150; // don't know about Alpari
int iSlippage = 30;

There is a better way to handle this, but for a quick fix this should work.

I haven't figured it out yet; but when I was looking around for something similar to what you're after, I was pointed in the direction of Manage Take Profit, which seemed to fit the bill.

If I ever get it operational, I'll report back.

Thanks to dod's link earlier I have to confirm that "Manage Take Profit" (by the way v 2.4 is the last official version by author) does everything I want.

Make sure you edit the code and any setting about SL/TP etc. need to be multiplied by 10 (ie. S/L of 10 needs to be 100 on the inputs)since the 6 digit prices arrived.

So far (testing on demo a/c) I have found this expert to be the "dogs doooodahs"

I'll be demo trading with it before I go live with it but this expert seems to answer all my questions.

Kenz987 ... thanks for your great help my friend

Happy pippin'

Willowgal

I'm glad it fits the bill. Your enthusiasm has enthused me to take a fresh look.