Is my work good?

Ive been working all last night based on what has been told to me by: fry2010, LongToBeFree, luxinterior, GCash, FOREXflash, thatwasme and Ronald Raygun...thank you very much

can someone please mark my work lol ( like teacher please see if I did good!!!!)

the indicator is attached with the reference in side
NOTE: I learn fast! But there are at least 11 deffenate mistakes I think.

+------------------------------------------------------------------------------------------+
COGpoint_v2
+------------------------------------------------------------------------------------------+
Reference Dictionary
---------------------------------------------------------------------------------------------

lable.......quick ref..................definition
----------------------------------------------------------------------------------------------
P...........(PERIOD)..................Is the period number of bars used to calculate the next bar of the
................................... ........indicator.
T..........(TOTAL)....................Is the Total number of bars this idcator shows on the chart.
S...........(SHIFT)....................Is the number of bars which the indicator is shifted left.
X...........(PREDICTION)............Is a horizontal line of prediction which changes RBGour red/green.
G...........(Green)?????????????? Is the Green buffer 1 Indicator line. or it is the old indicator?
R...........(RED)???????????????? Is the Red buffer 2 indicator line. or it is the old signal line?
B3..........????????????????????? buffer 3
B4..........????????????????????? buffer 4
Z...........(RESET)...................Stops using the current period/stops the counting of the current bar.
...........................................so the pogram can jump to the next bar/period.
C...........(COUNT)..................Counts the bars to make the last period, it starts on a cycle loop.
Opt........(OPTIMIZE)..............Returns bars already counted for optimization.
S1.........(SUM 1)...................Is the sum to calculate indicator.
S2.........(SUM 2)...................Is the sum to calculate indicator.
A...........(ANSWER)................Answer to the sum
N...........(NEW)??????????????? Is an indicator calculaton which indicates G (buffer1) and R (buffer2)
P2..........(PERIOD)???????????? double
LINE_G....????????????????????? Is the single line when it is green.
LINE_R....????????????????????? Is the single line when it is red.
L.......... ?????????????????????
DD........................................Is for dot number D1, it puts it 2 bars back from the current bar.
D0..........(DOT 0)....................Is the dot which sits on the current bar (right).
D1..........(DOT 1)....................Is the dot which is further away from the current bar (left).
H...........(HORIZONTAL LINE).....Ready made horizontal line.
D...........(DOT).......................Ready made dot.
NAME......(NAME REF)...............Looks for object string name (replace 'name' with the name of the object).
POS0.....................................Refers to the position of dot 0.
POS1.....................................Refers to the position of dot 0.
TIME0....................................Refers to the time of dot 0.
TIME1....................................Refers to the time of dot 1.
RGB.......................................Refers to the Colour of the horizontal line.
WINDOW................................Refers to the window of the indicator.
MH..........(MAKE H)..................Makes a horizontal line using two coordinates.
CODE.......(FONT).....................Refers to the arrow code (wingdings font)
TIME........????????????????????? Refers to the time of a dot.
POS.........????????????????????? Refers to the center of a dot.
MD..........(MAKE D)..................Makes a dot using one coordinate.
Attached Fileshttp://www.forexfactory.com/images/attach/mq4.gifCOGPOINTV2 reference.mq4 (18.5 KB, 1 views)

It works.

hey,

to be honest, its very hard for me to read it since variables A,B,C,S,Z do not have much of a meaning to me. i know i could check back with ur explanation, but rite now im way too tired for that... i can see if i have some time this friday(my off day) to give it a deeper look, if you want...

first impression although is nice... indi goes up, price goes up, indi goes down price follows... but i havent been looking at the code at all... yet...

how did you get that indicator? who has written it? if its your work, then why do you have comments like " <--- Why does it say only for Red????" or "<--- WHAT IS THIS??? there are two of them, another is near the end"
thats a bit confusing for me...

maybe you could give a basic concept of what the indicator should do, what its underlying concept is based on?! coz for me its kinda hard to try to guess it just out of the code... just something like a short explanation f.e. if there are 3 consecutive bear candles i want indi to turn red... when there 3 consecutive bull candles i want indi to turn green... that would be something like a concept(a simple one, just as an example)

regarding the 11 errors... i dont know what you mean by that... file can be compiled, so there are no errors in it, at least no syntax errors, no missing brackets, no missing arguments... there might be logical errors in it, but i didnt check for that.

if youre looking for marks from a teacher, im afraid im not the rite guy. im pretty new to mql4 myself, not even a year. but what i can tell is, youre very ambitious, willing to learn and i think this is most important attribute in learning a how to code, or basically learning anything.

...friday

Thank you for your compliments, I look up to you and others who have helped me!
To answer your question; I liked the original 'Center of gravity' (not the one wich re-paints) so much that I designed my own version (the old one had blue indicator line with red signal line). At the time I did not think I could understand programming, so I gave my design to a german programmer who made it for me (very nice of him). I have lost touch with him now, but I am confident that I can now learn!

My indicator looks like this:
http://i31.photobucket.com/albums/c3...COGPOINTV2.jpg
Thank you.

PS: The things that I think are my mistakes are in the reference not the code. they are high-lighted as possable mistakes with ??????????

The code is good I have compiled it. I beleve that once I know that my reference is correct then I can begin to program as I will mostly understand the logic, mabey lol Because everything that seams complicated is only many simple things!

bamben,

G ??? is the green buffer
R is the red.
B3 is the 3rd buffer, which is either value plus the period
b4 is the 4th buffer, which is either value minus the period
N yes
P2 yes
line_g an array
line_r an array
L is your count. It is equal to 0, not 1.
time yes
pos yes
P2 what is this??? it is the period. There is another because it is an external function, so it has to be defined again. Look at the header of the second instance.
only red may be if red !=empty than so will green.
G l+s, remember it is 0 not 1.
L++ completes the loop.


Those were what I found. Interesting idea. What settings did you use on that M1 chart, and how do you normaly read this?

I use this to guess the size of waves (as you know waves all ways change size) I start with a small period like 20 to look for a wave then when i see the wave i find the waves bigger brother by increasing the periods 40 then 35, 50, 55, 52 oh! found it! and so on. it is good to have more than one like a lower and higher, if i am trading mabey 1m and 15m but it depends where is the best view! thank you for you help brother!

it seems codobro already solved the mystery what the different variables mean/do.

Thank you for your guidence Codobro I have got much further now because of what you have said to me! see here, I have put your changes to the reference: http://www.forexfactory.com/showthread.php?t=146330

You're welcome, I'm glad I could be of help