Learing by arranging and rewritting code

Q) what would be a good method of arranging the code in your indicator i have attached the one that i am working on. as you can see i have tryed to give self explaitory names to every thing but, it now seams to cofuse the rest of the code.

i was thinkin of calling all these things A,B,C,D,E1,E2 ect...
and then making the definitions at the top like a refence list or dictionary.

is this a good idear or have you a better one?
Attached Fileshttp://www.forexfactory.com/images/attach/mq4.gifCOGpoint1 newcode.mq4 (12.8 KB, 2 views)

A dictioary at to top like:

//A) is this
//B) does this
//C)is this

ect...

but should i consider the order that things happen?

i am trying to make clear all of the different things that go on.

what else must i consider?

The considerations would be different depending on what you want to write. Are you sure you want to focus on indicators? IMO, its better (easier) to start off learning EAs than indicators

i have indicator i must make and other indicators i must change! for my statagey has long been only in my mind.

is that your code?
If its not your code and your just starting out in mql4 then I wudnt try to understand whats going on with this, unless ur gna spend a good time going through it and tryin to understand it.
Use good old pen and paper its easier to take notes that way.
Start from top and write down what each variable, buffer etc does. Maybe draw arrows going from different part of the programme to understand what is doing what.

If this is your code then i dont see how you would have problem with it if u managed to do it in the first place.
Try shorter names with less capitalisation changes.

Gd Luck.

U say you have a strategy that has been long in your mind, write it down on pen and paper. Its what i do nearly everyday, whatever it is if I have any good idea not nesseccarily to do with forex, i write it down on paper. I have paper everywhere its crazy.

Also if your trying to use other indicators in an EA remember there is a function called:

iCustom(). Look this up because instead of re-writting somone elses code u can just import it into ur indicator or EA. It is somtimes a lot easier to start from a fresh blank page.

the first part is not mine it is an indicator ready made.

the second part is my idear, i had a german guy program to my specifications.

i am trying to find out what it does now buy translating it.

can i change the order of things?

i wudnt change the order of things unless ur confident that u can do it.
First of before u even touch it, keep a back up copy somwhere and dont edit it.
Next with the copy version u have, u cud try chopping and changing.
A gd thing to do if u want to find the value of somthing is to use :

Print("Here is a value I want to find out", value);
Then look in your trading journal.

Ive been working all last night based on what has been told to me by: fry2010, LongToBeFree, luxinterior, GCash, FOREXflash, thatwasme and Ronald Raygun...thank you very much

can someone please mark my work lol ( like teacher please see if I did good!!!!)

the indicator is attached with the reference in side
NOTE: I learn fast! But there are at least 11 deffenate mistakes I think.

+------------------------------------------------------------------------------------------+
COGpoint_v2
+------------------------------------------------------------------------------------------+
Reference Dictionary
---------------------------------------------------------------------------------------------

lable.......quick ref..................definition
----------------------------------------------------------------------------------------------
P...........(PERIOD)..................Is the period number of bars used to calculate the next bar of the
...........................................indicator.
T..........(TOTAL)....................Is the Total number of bars this idcator shows on the chart.
S...........(SHIFT)....................Is the number of bars which the indicator is shifted left.
X...........(PREDICTION)............Is a horizontal line of prediction which changes RBGour red/green.
G...........(Green)?????????????? Is the Green buffer 1 Indicator line. or it is the old indicator?
R...........(RED)???????????????? Is the Red buffer 2 indicator line. or it is the old signal line?
B3..........????????????????????? buffer 3
B4..........????????????????????? buffer 4
Z...........(RESET)...................Stops using the current period/stops the counting of the current bar.
...........................................so the pogram can jump to the next bar/period.
C...........(COUNT)..................Counts the bars to make the last period, it starts on a cycle loop.
Opt........(OPTIMIZE)..............Returns bars already counted for optimization.
S1.........(SUM 1)...................Is the sum to calculate indicator.
S2.........(SUM 2)...................Is the sum to calculate indicator.
A...........(ANSWER)................Answer to the sum
N...........(NEW)??????????????? Is an indicator calculaton which indicates G (buffer1) and R (buffer2)
P2..........(PERIOD)???????????? double
LINE_G....????????????????????? Is the single line when it is green.
LINE_R....????????????????????? Is the single line when it is red.
L.......... ?????????????????????
DD........................................Is for dot number D1, it puts it 2 bars back from the current bar.
D0..........(DOT 0)....................Is the dot which sits on the current bar (right).
D1..........(DOT 1)....................Is the dot which is further away from the current bar (left).
H...........(HORIZONTAL LINE).....Ready made horizontal line.
D...........(DOT).......................Ready made dot.
NAME......(NAME REF)...............Looks for object string name (replace 'name' with the name of the object).
POS0.....................................Refers to the position of dot 0.
POS1.....................................Refers to the position of dot 0.
TIME0....................................Refers to the time of dot 0.
TIME1....................................Refers to the time of dot 1.
RGB.......................................Refers to the Colour of the horizontal line.
WINDOW................................Refers to the window of the indicator.
MH..........(MAKE H)..................Makes a horizontal line using two coordinates.
CODE.......(FONT).....................Refers to the arrow code (wingdings font)
TIME........????????????????????? Refers to the time of a dot.
POS.........????????????????????? Refers to the center of a dot.
MD..........(MAKE D)..................Makes a dot using one coordinate.