Problem with EA Close Command

Greetings,

Anyone heard of a problem with the Close command within MT4?

I'm running a few versions of an otherwise reliable EA and they simply do not close reliably. Programming help has come from a FF friend (thanks Hayseed) who also forwarded me an article that speaks to this.

http://www.facebook.com/topic.php?ui...717&topic=6398

Can anyone suggest a way around this? The EA is currently closing about 67% of the time that it should in various forward tests. Unfortunately, that 33% non-closed can eat your lunch.

I'm guessing this is beyond increasing the slippage, huh?

Correct RR. That was one of the early "fixes" we tried ... didn't work.

I'm still running forward tests on this and it continues to "hit & miss" when the conditions call for a close.

all you gotta do is add a truefalse flag

lets say were ready to close all
be sure and also use it as a filter for opening trades, you dont wanna open trades while your closing


just set a switch to true, that says close all
the ea will convert into a pure order closing machine until all is closed, then set it false

heres example, at the top put this

bool close=false;


no where your close order is, lets say its like this, close_all();

replace that with this, close=true;

then add this line right after, if (close)close_all();

also where the ordersend rules are, ad the !close

if (!close&&indy1>indy2)

in the close all function ad this
if (OrdersTotal()==0)close=false;

that example will work fine if your only trading 1 pair, if your trading more than 1 pair, youl need some code to count only the trades you wanna close

i also use this same teqnique for opening trades

Thanks for the tip TC ... I'll see if I can program it in. I'll post my success (or not) back here if you don't mind keeping an eye on this.

PP ...

Well, another reminder that I should read the entire response before I jump.

I was preparing to ask if there was a way to "force" a close when I saw TC's reply. As I then attempted his programming suggestions I managed to add the bool close=false; and got lost after that.

I've copied the close code below and I've also attached the ea to this reply.

Note on the EA ... I've set it up so that it is specific to a particular pair. While the ea is "identical" to others, they all have a separate name and magic number. Was the only way I could figure to run it on multiple pairs simultaneously.

Again, the objective here is to have it close a trade every time the conditions call for it ... not just when it wants to.

Thanks for your help.

PP




//+-----------------------------------------------------------+
// check for CLOSE long position possibility ... and CLOSE |
//+-----------------------------------------------------------+

if((ADXC<ADXthreshold || ADXDIPC-ADXDIMC<DIthreshold) && CountLongs(MagicNumber) > 0)
//xxxxxxif(ADXP > ADXC && ADXDIPP > ADXP && ADXDIPC < ADXC)
{
OrderClose(OrderTicket(), OrderLots(), Bid, 3, Violet); Print("adx close buy");// close position
return(0); // exit
}

//+-----------------------------------------------------------+
// check for CLOSE short position possibility ... and CLOSE |
//+-----------------------------------------------------------+
if((ADXC<ADXthreshold || ADXDIMC-ADXDIPC<DIthreshold) && CountShorts(MagicNumber) > 0)
//xxxxxxxxx if(ADXP > ADXC && ADXDIMP > ADXP && ADXDIMC < ADXC)
{
OrderClose(OrderTicket(), OrderLots(), Ask, 3, Violet); Print("adx close sell"); // close position
return(0); // exit
}
return(0);
}

Still seeking an answer to this one. Thanks to TrendChaser for his suggestion but I'm simply not able to make it work. Have tried adding the pieces to the EA but I'm still putting the wrong code in the wrong place. Figure I must have "fat" fingers. (lack of coding knowledge).

Would greatly appreciate some programming help, if available. Preferably to code TC's suggestions into the attached ea (assuming they work) or ... ?

Code & commentary much appreciated.

PP

Here is the function I use to close orders.... It handles errors and tries 5 times ( you can change attempts to whatever you would like) to get the job done.