icustom() problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Unknown problem with iCustom() function 1 reply

Have a problem referencing iCustom 3 replies

Problem with iCustom and T_S_R Signal Line 1 reply

iCustom for EAs? 5 replies

need help using ICustom 3 replies

Attachments: icustom() problem
Exit Attachments

icustom() problem

  • #1
  • First Post: Jan 9, 2009 2:32pm Jan 9, 2009 2:32pm
Hello

I would like to add the attached indicator into the very basic EA i built.
I have used the icustom() function before with laguerre ACS1 & ACS2, but i can't get this one to work.... the indicator (which i did not create) has alot of variables i would classify as "useless" but nevertheless they must be added to the coding in order to get it to work.


i have attached my EA (WHICH IS NO WHERE NEAR COMPLETE -- DO NOT TEST), as well as the indicator.


I appreciate any help in solving this problem.
Attached File(s)
File Type: mq4 EURGBP TEST.mq4   9 KB | 400 downloads
File Type: mq4 OverLayChart-MA.mq4   11 KB | 374 downloads
  • #2
  • Jan 9, 2009 3:51pm Jan 9, 2009 3:51pm
Instead of :
Inserted Code
double Var2 = iCustom(NULL, 0, "OverLayChart-MA", "GBPUSD", none, none, none, false, false, true, blue, 2, close, 0, Current + 0);

try:
Inserted Code
double Var2 = iCustom(NULL,Period(),"OverLayChart-MA","GBPUSD",0,0);
  • #3
  • Jan 9, 2009 4:04pm Jan 9, 2009 4:04pm
btw I havnt tested so u may have to play around with some of the inner values you pass to it, but avoid the use of 'none' unless you are going to set that as a variable. Hope it helps a little anyway
  • #4
  • Jan 9, 2009 4:57pm Jan 9, 2009 4:57pm
Why not just change all the external variables that the iCustom has to just variables, not external. then recompile it and save it as a slightly different name and call that version of the iCustom without all the hub ub parameters.
  • #5
  • Jan 9, 2009 8:35pm Jan 9, 2009 8:35pm
your codes can't even compile. reason as follows

none, blue and close are all undefined variables. Meaning you've not declared the type (double, int, bool, etc) of these variables anywhere in your code at all.

thatwasme was right to point out the use of external variables. instead of hardcoding it to your codes, that way your EA can change its behaviour without having to recompile. Since you have the codes for the indicator, that makes it all the more easy. copy and paste the extern variables from the indicator source code straight onto the extern variable list of your EA, that way you can preserve the order as well within your iCustom.

Inserted Code
extern int MagicNumber = 102;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 0.1;
extern int Slippage = 2;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 10;
extern bool UseTrailingStop = True;
extern int TrailingStop = 5;

//Indicator Parameters
extern string OLCMA_SubSymbol = "GBPUSD";
extern color OLCMA_BullBarColor = Black;
extern color OLCMA_BearBarColor = Black;
extern color OLCMA_GridColor = Black;
extern bool OLCMA_Mirroring = false;

extern bool OLCMA_ShowCandles = true;
extern bool OLCMA_ShowMA = true;

extern color OLCMA_MA_color = CornflowerBlue;
extern int OLCMA_MA_line_height = 2;
extern string OLCMA_MA_price = "Close";

Another thing I like to use which I hope you can pick up asap is the use of functions instead of dumping all code logic within the start function. If you learn to do that well, your codes will be a lot more readable.

Inserted Code
double GetOverLayChartMA_Value(int index)
{
   return ( iCustom(NULL, 0, "OverLayChart-MA", OLCMA_SubSymbol, OLCMA_BullBarColor, OLCMA_BearBarColor, OLCMA_GridColor, OLCMA_Mirroring, OLCMA_ShowCandles, OLCMA_ShowMA, OLCMA_MA_color, OLCMA_MA_line_height, OLCMA_MA_price, 0, index) );
}

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() {
...
...
...

double Var2 = GetOverLayChartMA_Value(Current);

...
...
}

I've attached the amended code file for your reference.

regards,
Zen

p.s., I keep seeing you do this kinda calculation "Current+0". What's the point in this may I ask? why would you want it to add nothing? why not just put "Current"?
Attached File(s)
File Type: mq4 EURGBP TEST.mq4   10 KB | 356 downloads
Programming for a better future.
  • #6
  • Last Post: Jan 10, 2009 12:17am Jan 10, 2009 12:17am
i really appreciate all the feedback.

i never thought of using:
//Indicator Parameters
extern string OLCMA_SubSymbol = "GBPUSD";
extern color OLCMA_BullBarColor = Black;
extern color OLCMA_BearBarColor = Black;
extern color OLCMA_GridColor = Black;
extern bool OLCMA_Mirroring = false;

extern bool OLCMA_ShowCandles = true;
extern bool OLCMA_ShowMA = true;

extern color OLCMA_MA_color = CornflowerBlue;
extern int OLCMA_MA_line_height = 2;
extern string OLCMA_MA_price = "Close";

because i wasn't exactly sure how the Indy worked. I have never created an Indy before, only amatuer EA's... which leads me into my next explaination:



"p.s., I keep seeing you do this kinda calculation "Current+0". What's the point in this may I ask? why would you want it to add nothing? why not just put "Current"?"


I have no idea, lol, its just something i leave in the template because i used to use current + 2 for the other EA you helped me on (which is working fine but i posted something about it i hope you have time to read... that EA really holds some true potential in my opinion if the parameters are fine tuned)
0 traders viewing now