Help with a Custom Indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help with MT4 custom indicator 3 replies

Need help importing custom indicator to EA 0 replies

help with custom indicator 9 replies

Need Help with custom indicator 1 reply

Need help Custom Indicator (MetaTrader4) 4 replies

Attachments: Help with a Custom Indicator
Exit Attachments

Help with a Custom Indicator

  • #1
  • First Post: Mar 13, 2007 5:41am Mar 13, 2007 5:41am
Good morning,
I need assistance with a custom indicator (see attached RubberBand.mq4). The specifics of the indicator are as follows:

1) Histogram showing the current Close Price minus the Close price of X # of bars in the past (x is designated as an ext variable that can be changed)
2) line bar (in the same indicator window) showing the current Low minus the Low of X # of bars in the past (this x should be the same as the x of the histogram)

That is basically it -- pretty simple. Though i can't make it calculate historically and each time i change the chart time frame it resets and the histogram and the line return to flat line. I think my error has something to do with an array, but I am only a beginner when it comes to coding EA's and indicators. Thank you for your help.
Attached Image
Attached File(s)
File Type: mq4 Rubber Band.mq4   2 KB | 764 downloads
{Spam Removed}
  • #2
  • Mar 14, 2007 10:04am Mar 14, 2007 10:04am
Try the attached version. I moved the statements that set up closeshift and lowshift into the respective "for" loops and changed them so they would pick up the relevant values at i + barshift (i.e. barshift periods prior to the bar referred to by the current value of i). I also changed each loop to respectively use Close[] and Low[] of the bar referred to the current value of i. How would you trade it's signals?
Attached File(s)
File Type: mq4 Rubber%20Band[1]gs.mq4   2 KB | 842 downloads
  • #3
  • Mar 15, 2007 5:23am Mar 15, 2007 5:23am
Quoting Spindrift
Try the attached version. I moved the statements that set up closeshift and lowshift into the respective "for" loops and changed them so they would pick up the relevant values at i + barshift (i.e. barshift periods prior to the bar referred to by the current value of i). I also changed each loop to respectively use Close[] and Low[] of the bar referred to the current value of i. How would you trade it's signals?
Spindrift,
Hey thanks...don't have time to test the indicator right now but I appreciate your efforts. I will test it tonight after work.

As for trade signals, basically I would use this along with Bollinger Bands. Basically if the price goes above the upper bollinger band i would look at the rubber band indicator to confirm. if the histogram (close price) breaks above the line (low price) then i look for price to go down. similarly, if the price goes below the lower bollinger band then i would look for the rubber band histogram to break below the line. i look for signals on a M30, H1, H4 chart, usually eurusd, usdchf, or gbpusd.

Obviously SL's would be appropriate but i haven't tested what levels the SL should be for each timeframe. Eventually I want to develop, or have developed, an EA to run this system. Just playing around with the idea. thanks.
{Spam Removed}
  • #4
  • Edited 10:13pm Mar 15, 2007 9:03pm | Edited 10:13pm
Quoting Spindrift
Try the attached version. I moved the statements that set up closeshift and lowshift into the respective "for" loops and changed them so they would pick up the relevant values at i + barshift (i.e. barshift periods prior to the bar referred to by the current value of i). I also changed each loop to respectively use Close[] and Low[] of the bar referred to the current value of i. How would you trade it's signals?
Hi Spindrift
I'm also looking for some help to make a small change to an indicator and I was hoping that you would be willing to take a look at it.
I require the REPAINT function to be removed so that I can do some backtesting... can you make this change for me? To repay your kindness I would be happy to send the backtest results to you.



Thanks & Regards
Glenn
AKA Cosmo II
Attached File(s)
File Type: mq4 super_signals_v2_alarm.mq4   3 KB | 769 downloads
  • #5
  • Mar 16, 2007 2:02am Mar 16, 2007 2:02am
[quote=stacy;244761]Spindrift,
Hey thanks...don't have time to test the indicator right now but I appreciate your efforts. I will test it tonight after work.

Spindrift,
Thank you for fixing this indicator. You nailed it. It works perfectly now. You are a MQL4 master.

s
{Spam Removed}
  • #6
  • Mar 16, 2007 4:33am Mar 16, 2007 4:33am
Quoting Cosmo II
Hi Spindrift
I'm also looking for some help to make a small change to an indicator and I was hoping that you would be willing to take a look at it.
I require the REPAINT function to be removed so that I can do some backtesting... can you make this change for me? To repay your kindness I would be happy to send the backtest results to you.



Thanks & Regards
Glenn
AKA Cosmo II
Hi Glenn, not sure what you mean. Can you tell me what you want it to stop doing? Cheers, Greg
  • #7
  • Mar 16, 2007 5:02am Mar 16, 2007 5:02am
Quoting Spindrift
Hi Glenn, not sure what you mean. Can you tell me what you want it to stop doing? Cheers, Greg
Hi Greg,

The Super Signal Indicator shows the most recent High / Low for a know period of time these are shown as UP / DOWN ARROWS.

The indicator removes the arrows as the price moves up or down until finally it get it right. Looking at the results after the event it looks as if the indicator is always correct because all of the false signals have been removed, what I would like to see is all arrows to remain on the chart whether correct or not.

I would greatly appreciate your help.

Regards,
Glenn
  • #8
  • Mar 16, 2007 5:29am Mar 16, 2007 5:29am
Hmmm... since there seem to be some coding geniuses in here I will ask another question that seems in line with the original topic of the post.

I am by no means a coder, but I have been able to assemble an indicator through the copy and paste method to recognize and mark a couple of the candle patterns I would like to be alerted about when they form on the day chart.

Right now, the indicator alerts and marks the chart. I was wondering if anyone had a reference on making this indicator send an email alert. Email is already set up through MT4 and my server, I just need to get it to send the alert instead of popping a box up on the screen.

The overall goal on this indicator would be to let it sit there running on a seperate computer and send email alerts to my inbox or possibly phone from there when a doji forms on any day chart.
The basis of a democratic state is liberty. ~ Aristotle
  • #9
  • Mar 16, 2007 6:13am Mar 16, 2007 6:13am
[quote=stacy;245743]
Quoting stacy
Spindrift,
Hey thanks...don't have time to test the indicator right now but I appreciate your efforts. I will test it tonight after work.

Spindrift,
Thank you for fixing this indicator. You nailed it. It works perfectly now. You are a MQL4 master.

s
Glad it worked ok. Cheers, Greg
  • #10
  • Mar 16, 2007 6:37am Mar 16, 2007 6:37am
Quoting Cosmo II
Hi Greg,

The Super Signal Indicator shows the most recent High / Low for a know period of time these are shown as UP / DOWN ARROWS.

The indicator removes the arrows as the price moves up or down until finally it get it right. Looking at the results after the event it looks as if the indicator is always correct because all of the false signals have been removed, what I would like to see is all arrows to remain on the chart whether correct or not.

I would greatly appreciate your help.

Regards,
Glenn
Hi Glenn

The indicator appeared to have a minor bug in that it was not setting a valid symbol for two of its lines (these were appearing as small crosses). I've changed it to show a different type of down/up arrow in magenta and orangeRed respectively.

The indicator works by looping through all the bars and setting arrows when certain conditions are fulfilled; I think it's something like:
Orange down arrow/ yellow up arrow where current bar is highest/lowest in a range of bars "dist1" bars around the current bar.
Magenta down arrow/orangeRed up arrow where current bar is highest/lowest in a range of bars "dist2" bars around the current bar.

Orange/yellow are marked 10 pips above/below the high/low
Magenta/orangeRed are marked 4 pips above/below the high/low

It only sets an arrow if a condition is fulfilled.

What I've done is to take out the test to see whether the current bar should be marked. This makes it mark each bar (as above) with the highest/lowest in the range around that bar. Hope this helps!

Cheers,Greg
Attached File(s)
File Type: mq4 super_signals_v2_alarm.mq4   3 KB | 619 downloads
  • #11
  • Mar 16, 2007 6:41am Mar 16, 2007 6:41am
Quoting Vensik
Hmmm... since there seem to be some coding geniuses in here I will ask another question that seems in line with the original topic of the post.

I am by no means a coder, but I have been able to assemble an indicator through the copy and paste method to recognize and mark a couple of the candle patterns I would like to be alerted about when they form on the day chart.

Right now, the indicator alerts and marks the chart. I was wondering if anyone had a reference on making this indicator send an email alert. Email is already set up through MT4 and my server, I just need to get it to send the alert instead of popping a box up on the screen.

The overall goal on this indicator would be to let it sit there running on a seperate computer and send email alerts to my inbox or possibly phone from there when a doji forms on any day chart.
I've never tried it but the SendMail() function looks to be what you need. Here's the example from the online manual:
double lastclose=Close[0]; if(lastclose<my_signal) SendMail("from your expert", "Price dropped down to "+DoubleToStr(lastclose,Digits));
Cheers,
Greg
  • #12
  • Mar 16, 2007 7:14am Mar 16, 2007 7:14am
Quoting Spindrift
Hi Glenn

The indicator appeared to have a minor bug in that it was not setting a valid symbol for two of its lines (these were appearing as small crosses). I've changed it to show a different type of down/up arrow in magenta and orangeRed respectively.

The indicator works by looping through all the bars and setting arrows when certain conditions are fulfilled; I think it's something like:
Orange down arrow/ yellow up arrow where current bar is highest/lowest in a range of bars "dist1" bars around the current bar.
Magenta down arrow/orangeRed up arrow where current bar is highest/lowest in a range of bars "dist2" bars around the current bar.

Orange/yellow are marked 10 pips above/below the high/low
Magenta/orangeRed are marked 4 pips above/below the high/low

It only sets an arrow if a condition is fulfilled.

What I've done is to take out the test to see whether the current bar should be marked. This makes it mark each bar (as above) with the highest/lowest in the range around that bar. Hope this helps!

Cheers,Greg

Hi Greg,

Thanks sincerly for all your help, hope I can devise a method from this I'll let you know the results ASAP

Best Regards,

Glenn
  • #13
  • Mar 16, 2007 7:32am Mar 16, 2007 7:32am
Thanks, I will mess with it some more after trading today. Coding is a whole different world.
The basis of a democratic state is liberty. ~ Aristotle
  • #14
  • Mar 16, 2007 7:42am Mar 16, 2007 7:42am
Quoting Spindrift
Hi Glenn

The indicator appeared to have a minor bug in that it was not setting a valid symbol for two of its lines (these were appearing as small crosses). I've changed it to show a different type of down/up arrow in magenta and orangeRed respectively.

The indicator works by looping through all the bars and setting arrows when certain conditions are fulfilled; I think it's something like:
Orange down arrow/ yellow up arrow where current bar is highest/lowest in a range of bars "dist1" bars around the current bar.
Magenta down arrow/orangeRed up arrow where current bar is highest/lowest in a range of bars "dist2" bars around the current bar.

Orange/yellow are marked 10 pips above/below the high/low
Magenta/orangeRed are marked 4 pips above/below the high/low

It only sets an arrow if a condition is fulfilled.

What I've done is to take out the test to see whether the current bar should be marked. This makes it mark each bar (as above) with the highest/lowest in the range around that bar. Hope this helps!

Cheers,Greg
Hey Greg,

Something not quite right with this indicator, there are arrows right across the chart top and bottom......... take a look at the original and you'll see what I mean.

Glenn
  • #15
  • Mar 16, 2007 9:50am Mar 16, 2007 9:50am
Quoting Cosmo II
Hey Greg,

Something not quite right with this indicator, there are arrows right across the chart top and bottom......... take a look at the original and you'll see what I mean.

Glenn
I thought that's what you wanted! The version I gave shows you the value of the 4 indicator buffers for every bar.

I've now attached a slightly corrected version of the original. As far as I know, there's no REPAINT function in MQL4. The arrows only appear where the program puts them, which is when the bar being looked at happens to be the highest/lowest in the range being examined. Not sure there's much else I can do to help you backtest it.

Cheers,
Greg
Attached File(s)
File Type: mq4 super_signals_v2_alarm.mq4   3 KB | 733 downloads
  • #16
  • Mar 16, 2007 1:30pm Mar 16, 2007 1:30pm
Quoting Spindrift
I thought that's what you wanted! The version I gave shows you the value of the 4 indicator buffers for every bar.

I've now attached a slightly corrected version of the original. As far as I know, there's no REPAINT function in MQL4. The arrows only appear where the program puts them, which is when the bar being looked at happens to be the highest/lowest in the range being examined. Not sure there's much else I can do to help you backtest it.

Cheers,
Greg
.....I was thinking about this and I guess what you want is some way to see what the arrows would have been like when each bar was the most recent one. Is that right? Due to the way MT indicators work, I don't think there's really any way to achieve exactly that. The version I've attached has been amended to check only bars that are in the past at any given point.

Cheers,
Greg
Attached File(s)
File Type: mq4 super_signals_v2_alarm.mq4   3 KB | 585 downloads
  • #17
  • Mar 17, 2007 12:55am Mar 17, 2007 12:55am
Quoting Spindrift
I thought that's what you wanted! The version I gave shows you the value of the 4 indicator buffers for every bar.

I've now attached a slightly corrected version of the original. As far as I know, there's no REPAINT function in MQL4. The arrows only appear where the program puts them, which is when the bar being looked at happens to be the highest/lowest in the range being examined. Not sure there's much else I can do to help you backtest it.

Cheers,
Greg
Hi Greg,

My apologies, you are quite correct, I can see now that the first amended indicator is the way it was originally intended to be displayed on the chart with the multiple arrows and as you so correctly stated ’it had a bug in it’ which you have now ingeniously fixed, now I know why I could never get it to work correctly.

I will spend some time back testing this version and give you details on its performance.
Once again I can’t thank you enough for your help.

Best Regards,

Glenn
  • #18
  • Last Post: Edited 2:27am Apr 4, 2007 1:57am | Edited 2:27am
Quoting Vensik
Hmmm... since there seem to be some coding geniuses in here I will ask another question that seems in line with the original topic of the post.

I am by no means a coder, but I have been able to assemble an indicator through the copy and paste method to recognize and mark a couple of the candle patterns I would like to be alerted about when they form on the day chart.

Right now, the indicator alerts and marks the chart. I was wondering if anyone had a reference on making this indicator send an email alert. Email is already set up through MT4 and my server, I just need to get it to send the alert instead of popping a box up on the screen.

The overall goal on this indicator would be to let it sit there running on a seperate computer and send email alerts to my inbox or possibly phone from there when a doji forms on any day chart.

Here is a great candlestick indicator.. feel free to contact me if you need me to help you set it up using your email and phone for alerts. Works on your demo account too....lol
Attached File(s)
File Type: mq4 Candlestick Identification_MT4_In.mq4   3 KB | 923 downloads
0 traders viewing now