Close Pending Orders When last order was profitable

hey jw.... odds are the quickest way to find the trouble would be to rewrite the ea from ground up......

it looks like your ea was built using one of those zero code ea building sites like sufx core..... that method is good for starters but the quicker you can move to true code writing the better.... only then will you be able to have true flexibility......

i'll try to look at yours later and see whats up.....h

h,

I did develop a basic template from Sufx.core but other than the most basic elements of the coding i have edited the EA myself.... I'm going to keep looking at it. i didn't think it would be this difficult to have an EA automatically close orders once a trade was closed with profit.

im uploading this just to show how i implemented my EA into the "code reference file". it has some coding errors but i'm tired.... look at them later

Happy new year to all.

hey jw.... that's lookin good..... as you move from the zero code style to pure code writing the code will become fluid and easy to read..... of course that takes some time.....

just took a very brief look at your latest..... here are a few suggestions..... will look deeper if time permits..... you are doing an excellent job.....h

h,

i appreciate your support and your help. I have finished the coding elements and have added another level to the trading. Some of the coding isn't as "user-friendly" as i would like, but it's working.


There are however 2 things I'm having a problem implementing:

1. I can't get my trailing stop code to work properly any more... I want a trailing stop of 4 to take place on the first order. this is a pretty important aspect of the EA

I'm using this code:

//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
continue;


2. I can't get my EA to wait 2 minutes before looking for another signal.

I use this code:

extern double interval=2; // minutes between trades
bool trade_allowed=true;
double minutes = 0;




double interval2 = interval*60;
if (TimeCurrent()<minutes) trade_allowed=false;
if (TimeCurrent()>minutes) trade_allowed=true;

&& trade_allowed



maybe sleep()? i've never toyed around with it but i'm going to try to now.

hey jw..... added a checktime clause to account for wait time....

2 new inputs..... delayentry, which just turns on or off the wait time...... and delay, in minutes, which sets the amount of time to wait, in minutes.....

used patricks trailing stop but added the magicnumber condition......

unless your using someone that guarentees spreads, 4 pips is kinda tight..... i monitor minimum, maximum and current spreads all day.... they vary unbeliveably widely during the day and can be a killer with tight stops...... h

I dunno what it is about that trailing stop code, but it stops out orders while they are still at a loss.


the trailing stop should obviously only take place once the trade is breakeven or higher.


Also i don't see anything in that code that would limit the trailing stop solely to the .01 lot trade.


I'm gonna look for another trailing stop code.

Ok i managed to fix the trailing stop code to make the trailing stop only work for level 1 trading (.01 lots)

I used if(OrderLots() < Lotslvl2){ in the coding.




But I've run across another problem:

SOMETIMES, and not every time, but sometimes the EA will delete pending orders even though the trade before it closed with a loss. I've attached a picture showing twice this occurred.

Its bizarre because the EA will correctly close pending orders if the trade before it is profitable, and it will sometimes open the additional pending order like it is supposed to, but obviously prematurely closing pending orders when it is not supposed to is an issue.





EDIT: Actually looking into this further, i believe that the EA closed all pending orders at 14:08, which means it closed out pending orders from two separate signals at the same time...

which means that the DELAY feature isnt working, or my interval setting isnt working.


looking into it tomorrow.

I encounter before with pending order close due to not enough money.
Look at journal tab to see what happening.

I'm still down with minor food poisoning... had too much to eat (not knowing what I was eating) during the festive season. But that also means I'm on medical leave and can now work on your case. I'll get back to u as soon as I'm done.

hey check out this attachment. its a 90% complete EA i've fathomed together using your coding & hayseeds coding.

it does the majority of everything i'd like this EA to do, with the exception of being user-friendly (aka not needing to manually change coding to get the parameters i want)


a feature that would accept a requote only if the parameters for a trade still existed WOULD BE EXTREMELY HELPFUL.... for example,


if we got an instant buy signal at 1.4250, but a requote at 1.4240, we'd obviously want to accept that requote.

but a requote at 1.4255 would not be in our favor and all pending trades should close since the .01 lot trade did not open

I didn't have time to look at what you have in that code u just posted.

Here's my attempt at trying to create an EA based on your rules. I made some amendments to codes responsible for the closing of pending trades. Haven't had a chance to test it yet.

regards,
Zen

Zen,

the coding looks amazing, i havent had time to go over it yet but i will later tonight. i noticed that SL & TP's are a bit off but i can fix that myself.

I am also going to be adding a 4th level of trades to this coding.



Thank you so much. I will let you know how it works, so far i have banked 390 pips using my two seperate EA's... although sometimes they do some funny things so i need to monitor them.

also, i wanted to let you know i am in the process of developing a forum devoted solely to this trading strategy. i believe i will be done with it sometime soon... since this strategy uses no indicators, i hope that sooner or later i will be able to get more people using it to optimize the parameters. i will send u the fourm link in a PM once it is complete.

Zen,

I've edited the coding a little bit to make it more user friendly, unfortunately I've noticed that neither my version nor your version executes any Sell orders.


I'm starting to look into it, but i dont see anything that is wrong so far.


EDIT: I FOUND IT.

RefreshRates();
if (!ShouldBuy()) // skip out if updated rates no longer fit rules. Line 267. Needed to be ShouldSell())



EDIT: OK. I got everything working correctly, with the exception of three additions I'd like to work on with you whenever you have time. send me a PM when you think you can work on it.... I'm looking into other EA's that have these types of inputs now to see if anyone else has done something like this.

- Trailing stop of 4 needs to be added to Level 1 Orders... not all retracements are going to hit a TP of 10, but if we can lock in a single pip that is better than a straight loss.
- EA needs to wait 2 minutes before looking for the same type of order (I THINK, im testing now to see if this makes a difference)
- A way to enter large news announcements and have the EA stop looking for signals during that time period would be beneficial in order to make this EA nearly "Set & Forget"
Example:

Todays USD Unemployment announcement at 8:15 EST caused a 100+ swing in price. this EA is only set to handle 75 pip swings in 4 levels. It would be fantastic if there was the ability to input up to 5 different times where the EA should sleep 5 minutes before and 20 minutes after these annoucements.

e.g.

input = 14:15 (My Metatraders time for this announcement) = EA stops looking for signals from 14:10 to 14:35 because it is just way too volatile & unpredictable after large news annoucements.

[i mean we all should have known unemployment #'s would be bad and to buy EURUSD, but obviously the EA doesn't know that]

ok so after testing the EA, with proiftable results i might add (due to the addition of a 4th level) [i've even added a 5th level to another edition of the EA and it has yet to have any loss]

i have concluded the following is absolutely needed:

1. a Trailing stop of 4 included on level 1 lots. this will help avoid other levels being triggered, and will lock in/breakeven profits.

i have this code but it doesn't work:

//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;



i have enetered all the parameters wher ei believe they should go, as i have made this code work before in other EA's, but i cant get it to work in your version.







2. the EA must not look for identical signals within 2 minutes of each other. I have attached a picture that shows the problem with the current EA. It executed a second buy order after the retraction has already taken place.... which is dangerous.

i know there is SLEEP(), never tried it, but i have coding for this wait i can't get to work either:



extern double interval=2; // minutes between trades
bool trade_allowed=true;
double minutes = 0;

double interval2 = interval*60;
if (TimeCurrent()<minutes) trade_allowed=false;
if (TimeCurrent()>minutes) trade_allowed=true;

&& trade_allowed

minutes=TimeCurrent()+interval2;




i've gotten this code to work in various EA's as well, but not in the current one... it must be a problem with our different "templates"