Beginners coding advice needed please

Hi all,

I would like to plot a line which has two variables. The first is the time, and the second is a price at that time. I have all the price and time data historical and future.

So for example, 19/12/08 the price is 1.4539, 20/12/08 the price is 1.4547, 21/12/08 the price is 1.4659.

I would like to plot a line that intersects the price at a specific date as with the example I have shown. I have all the prices for each date already mapped out.

Can anybody give me an idea what basic syntax i need to achieve this? The date and price data will have about three years of price and time. Will I need to create an array to place all this data into?

Thanks in advance for any replies, Ive been busting my balls for months calculating price and time data and now as a newbie coder have to learn the syntax of metatrader in order to get up and running.

Peace.

ObjectCreate() Function.

bool ObjectCreate( string name, int type, int window, datetime time1, double price1)


In your case:

ObjectCreate(Time[0], OBJ_HLINE, 0, [Put time of line], [Put Price of line]);

Thanks for your reply, however Im afraid I basically havnt got a clue how to code or what else I need to do here....

I know this is a simple task for a coder and I would be very appreciative if anybody could fill in the gaps to get this indicator to display the line.



#property copyright "Lines"
#property link ""

#property indicator_chart_window
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();

ObjectCreate(Time[0], OBJ_HLINE, 0, D'17/12/08', 0.9424);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'18/12/08', 0.9431);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'19/12/08', 0.9442);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'20/12/08', 0.9457);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'21/12/08', 0.9464);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'22/12/08', 0.9471);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'23/12/08', 0.9482);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'24/12/08', 0.9494);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'25/12/08', 0.9501);
ObjectCreate(Time[0], OBJ_HLINE, 0, D'26/12/08', 0.9504);

return(0);
}
//+------------------------------------------------------------------+

replace with:

ObjectCreate("1", OBJ_HLINE, 0, 0, 0.9424);
ObjectCreate("2", OBJ_HLINE, 0, 0, 0.9431);
ObjectCreate("3", OBJ_HLINE, 0, 0, 0.9442);
ObjectCreate("4", OBJ_HLINE, 0, 0, 0.9457);
ObjectCreate("5", OBJ_HLINE, 0, 0, 0.9464);
ObjectCreate("6", OBJ_HLINE, 0, 0, 0.9471);
ObjectCreate("7", OBJ_HLINE, 0, 0, 0.9482);
ObjectCreate("8", OBJ_HLINE, 0, 0, 0.9494);
ObjectCreate("9", OBJ_HLINE, 0, 0, 0.9501);
ObjectCreate("10", OBJ_HLINE, 0, 0, 0.9504);

the problem with using OBJ_HLINE is that it will draw the horizontal line across the whole of the chart. so if you have 800 over dates of prices, that will mean 800 lines on chart at one go. Is that really what you want?

or do you want a single line that goes through all those points, kinda like joining the dots except the line should stay level throughout that day and only change level upon the next day with a different price value, and so on...

please draw a simple pic of what you want.

is it something like my image attachment?

This is an indicator I did a few days ago to plot out the daily and weekly open price, it works no matter which timeframe you're on as long as its less than daily TF.

perhaps you can use it as reference.

I've thought of a better way to get your date and price inputs into the indicator. you can have them in a file and get the code to read the data from the file. that way in future you just have to change the data file and you won't have to recompile the indicator again as the values aren't hard-coded.

Let me know if you need help with that. I can only reply after Christmas though.

regards,
Zen

Thanks again for the assistance it really is appreciated.

Ive uploaded a picture which displays the type of line I would like to have on the chart. This line is not based upon my data it merely shows the type of line I intend to use. Some of the lines will have a different angle.

Basically, the date and price can be considered as dots and the line connects the dots.

If the data can be placed in a file that metatrader can read, that would be absolutely perfect, and in that case Id be prepaired to explain what the data is and how it will be used regarding price analysis.

Sounds like your missing your definitions for how MT is going to view the data...

Add this at the beginning of the code

//---- indicator settings
#property indicator_chart_window
#property indicator_buffers 1

#property indicator_width1 1

//---- buffers
double ExtMapBuffer1[];


In your init area, put this

//---- drawing settings
SetIndexStyle(0,DRAW_LINE);
SetIndexBuffer(0,ExtMapBuffer1);

The final piece is here - this goes into the Start area
ExtMapBuffer1[index] = your indicator here.


I'd recommend opening a few of the indicators to get a better grasp of the under workings of MT.

Hope this helps

There is only 1 price per day, but there are 12 different lines per day, each line has its unique price which remains the same throughout the whole day. Some of the lines change very slowly and are nearly horizontal for weeks at a time, some of the will change much faster, nealy every day.

For example one line may be the 1.4500 on a starting date and remains the same for several days before the price changes to 1.4501. Wheras another line maybe 1.3809 on the starting date and will be 1.3950 in the same duration of time. So the second line will ofcourse have a steeper angle.

The indicator posted by Zen is closer to what I am attempting to create however the line needs to be straight, like a simple moving average.... my data is useless unless I can achieve a straight line between each data point on each day.

Im also looking at other indicators as suggested by almo as I really do have to get to grips with this language at some point.

Thanks for the support everybody.

Here are some actual calculations from my price and time data for the end of 2008. This data is the first primary line of the 12 lines that are applicable to that primary line. One of 9 primary lines ! (The 9 primary lines and 11 harmonic lines will be on separate indicators, primary line 1 with its 11 harmonics, then primary line 2 with its 11 harmonics etc) If I can get one line sorted I can do the remainder.

Wed 24/12/08 1.3680 Thu 25/12/08 1.3695, Fri 26/12/08 1.3710, Sat 27/12/08 1.3725, Sun 28/12/08 1.3739, Mon 29/12/08 1.3754, Tue 30/12/08 1.3768, Wed 31/12/08 1.3781.

I'm not sure if drawing trend line Objects is the way to go... since you have 12 lines per day. 3 years of data. approximately 250 trading day per year.
and each trend line object only takes in 2 points (the start and end)...
that means once all your data is drawn, it'll result in

((3 x 250) - 1) x 12 = 8988

8988 number of objects on screen! I'm not sure if MT4 can handle that...

indicator buffer lines are probably best, and you can place the "dots" in the respective slots within the buffer arrays first, then fill in the middle using some simple arithmetic equations.

but one thing you have to know. As far as I can tell, both the above options don't allow you to plot future data. meaning the current bar is on 25th December. you won't be able to plot a value for the lines throughout the 25th day until 26th comes about with a "dot" for the plotting to occur. That implies you'll only be able to plot historical data. I can't tell how that would help in your trading.

preemptive plotting might be possible (as in plot the middle values even before the destination has appeared) but it'll bring about a whole series of problems because the number of candles within each trading day may be different depending on brokers and also further complexified by holidays during weekdays when trading is closed...

regards,
Zen

Thanks for your repies Zen, I really do appreciate that.

I feel that as excellent as metatrader is, it may fall short in terms of its flexibility in terms of being able to offer the capacity to code the particular details that Im considering. I will pursue this via learning the language until confirmed or otherwise.

If I am unable to utilise metatrader to serve my purpose, I will learn a language and build my own program! Meanwhile I still have all the price and time data, and am able to use this to assist trading decisions albeit without as much ease as I would prefer.

Good trading to you.

Faremi: Send me a personal email or PM. Ken.

Zen and others replying to this request: Does anyone have Faremi's email? If so, would you please send him a request to notify me..?? Thanks, Ken.
ps: I've already done this in ninja.

Ken, I don't have his personal contacts. Why don't you join in the spirit of sharing and post that piece of code here so all can benefit? if you're looking to sell it then... good luck.

regards,
Zen

I have nothing for sale. "All can benefit"? Not likely. The code is in C-sharp .Net ver 2 for Ninja Trader, but could be modified for MT. It just reads a text file based on a key of date,time,symbol and plots the data as an indicator value. It has to be modified for each application, but not much. Here is the code - it will read in up to 9 values. Ken.

Hi all,

I'm new here on the forum but have lurked in the past on the various trading strategy topics. Really new to coding but really want to learn it to automate things. I can't tell you how tired I am of drawing lines.

I would like to create a tool that would look at a specific number of bars (ie 300, 500, 700) back from the current and consider the highs and lows of each. From there I would like the program to sift through the info looking for the single horizontal line which would connect the greatest number of these highs and/or lows... then the second greatest number... then third.

Also, I would like to do this again, BUT with a line NOT horizontal.

Lastly, I hope to create code that will compare the intersections of these lines AND their coincidence with Fib retraces and extensions and print out the price levels in varying colors in accordance with the particular type of line. Levels and specific points where these diagonal lines intersect the other types of lines I would like to have marked with some small arrow which would vary in color depending on the type of horizontal line it is intersecting (SAR or Fib OR a level where there are both).

I have some other ideas I would like code as well, but I think just this might be the end of me if I don't get some help!

Thanks for all of your posts. I feel like I'm starting to pick things up.

Kind Regards,
Jason