Close Pending Orders When last order was profitable

Quoting LongToBeFree

Disliked

This is not difficult.

1 - When you open your orders, store the order numbers (ints) into an array

2 - When each tick changes, check to see if it matches the stop loss of your first active order

3 - if it does, then run through the array and close out all orders

Thats it, thats all there is to it

Ignored

Quoting Zen_Leow

Disliked

Alright, assuming the previous codes were correct. And assuming the higher level pending orders won't execute until lower one is closed out....

Ignored

Quoting Jwentro

Disliked

Also, with regard to looking at magic numbers, wouldn't this be an issue:

All trades for a particular signal are opened at the same time, so they are all labeled as BUY#1XXXXXXXX when opened. so if level 1 closed at SL, and level 2 hit its TP, then level 3 would see one BUY#1XXXXXXXXXXX that is negative and one BUY#1XXXXXXXXXX that is positive... both of which opened at the same time.

Ignored

Quoting Jwentro

Disliked

level 1 was profitable, so technically levels 2 & 3 should have closed since they aren't needed to make profit. but because they have the same comment at level 1, they don't close.

Ignored

Quoting Jwentro

Disliked

in an attempt to not be completely hopeless when it comes to programming, i thought about this on my way home from work, and what if we changed the magic numbers and times by adding lots sizes to the comments as well

then we would have

BUY(#12296356800.01)
BUY(#12296356800.03)
BUY(#12296356800.15)

Would this work? i tried implementing it myself but its giving me ) and , errors when compiling that won't work.

Ignored

Quoting Zen_Leow

Disliked

first of all, I'm not using magic number for the grouping. your magic number usage stays the same. I'm using Time[0] in the comments. secondly, I've coded the logic to disregard the loss and just care about looking for a win or breakeven to delete currently pending trades. So for your example, Level1 will be ignored. and level3 will close because level2 was a win.



is this a result of testing cos it defers from your example? I've not tested the codes by the way. if that's the case, have you seen the journal tab? are there any error messages?...

Ignored

bool PreviousTradeInProfit(string comment)
{
   int histotal = OrdersHistoryTotal()-1;
   if (histotal >= 0)
   {
      for(int cnt=histotal;cnt>=0;cnt--)
      {
         if(OrderSelect(cnt,SELECT_BY_POS,MODE_HISTORY))
         {
            if(OrderSymbol()==Symbol() && OrderMagicNumber() == MagicNumber && (StringFind(OrderComment(),comment,0) >= 0))
            {
               if (OrderClosePrice() >= 0)
               {
                  return (true);
               }
            }
         }
      }
   }
   return (false);
}

Quoting hayseed

Disliked

hey zen.... here is a quick example of my prefered method.....

open a weekly chart, needs current weekly data, then run a visual backtest on the hour timeframe.....h

Ignored

Quoting hayseed

Disliked

hey jw...... i didn't look at your code so not sure what it is supposed to do or what was the root cause of the error..... here are the proper parts combined.... .....h

Ignored