Pending Order Problem

Hello Everyone,

I am just geting started in EA Programming, and can't seem to figure out what my problem is... (mostly because my EA complies error free)


I have a set list of parameters, which you can take a look at if you'd like, but my problem is, when the EA signals a BUY or SELL, i want it to open a BUYLIMIT or SELLLIMIT 0.0015 pips away from where the first order was opened.


You can see my attempt in the code below, but it has thus far been incorrect.

Please feel free to edit the code as much as needed.

I thank all in advance for any help.

//+------------------------------------------------------------------+
//| Peak Trader V1.3 |
//| System developed by JWentro |
//| |
//| In no event will author be liable for any damages whatsoever. |
//| Use at your own risk. |
//| |
//+------------------- DO NOT REMOVE THIS HEADER --------------------+
#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4
#property copyright "Peak Trader V1.0"
#property link "http://www.forexfactory.com"
extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lotslvl1 = 0.1;
extern double Lotslvl2 = 0.3;
extern double Lotslvl3 = 0.3;
extern int Slippage = 1;
extern bool UseStopLoss = True;
extern int StopLoss = 15;
extern bool UseTakeProfit = True;
extern int TakeProfit = 10;
extern int TakeProfitlvl2 = 6;
extern int TakeProfitlvl3 = 3;
extern bool UseTrailingStop = True;
extern int TrailingStop = 4;
extern double interval=2; // minutes between trades
bool trade_allowed=true;
double minutes = 0;
int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init() {
BarCount = Bars;
if (EachTickMode) Current = 0; else Current = 1;
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit() {
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;
double interval2 = interval*60;
if (TimeCurrent()<minutes) trade_allowed=false;
if (TimeCurrent()>minutes) trade_allowed=true;

if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;
//+------------------------------------------------------------------+
//| Variable Begin |
//+------------------------------------------------------------------+
double Var1 = iClose(NULL, 0, Current + 2);
double Var2 = iClose(NULL, 0, Current + 0);
double Var3 = iLow(NULL, 0, Current + 0);
double Var4 = iHigh(NULL, 0, Current + 0);
double Buy1_1 = Var1 - Var2 ;
double Buy1_2 = 0.0015;
double Buy2_1 = Var2 + 0.0002;
double Buy2_2 = Ask;
double Buy3_1 = Var2 ;
double Buy3_2 = Var4 ;
double Sell1_1 = Var2 - Var1 ;
double Sell1_2 = 0.0015;
double Sell2_1 = Var2 - 0.0002;
double Sell2_2 = Bid;
double Sell3_1 = Var2 ;
double Sell3_2 = Var3 ;


//+------------------------------------------------------------------+
//| Variable End |
//+------------------------------------------------------------------+
//Check position
bool IsTrade = False;
for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close
//+------------------------------------------------------------------+
//| Signal Begin(Exit Buy) |
//+------------------------------------------------------------------+

//+------------------------------------------------------------------+
//| Signal End(Exit Buy) |
//+------------------------------------------------------------------+
if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close
//+------------------------------------------------------------------+
//| Signal Begin(Exit Sell) |
//+------------------------------------------------------------------+

//+------------------------------------------------------------------+
//| Signal End(Exit Sell) |
//+------------------------------------------------------------------+
if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}
//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+
if (Buy1_1 > Buy1_2 && Buy2_1 >= Buy2_2 && Buy3_1 != Buy3_2 && trade_allowed) Order = SIGNAL_BUY;
if (Sell1_1 > Sell1_2 && Sell2_1 <= Sell2_2 && Sell3_1 != Sell3_2 && trade_allowed) Order = SIGNAL_SELL;

//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+
//Buy

/////Activate Level 1\\\\\
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lotslvl1)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_BUY, Lotslvl1, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
minutes=TimeCurrent()+interval2;
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;

/////Activate Pending Orders\\\\\
/////Activate Level 2\\\\\

if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lotslvl2)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Ask-0.0015 - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask-0.0015 + TakeProfitlvl2 * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_BUYLIMIT, Lotslvl2, Ask-0.0015, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask-0.0015, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
}
return(0);
}
}
//Sell
/////Activate Level 1\\\\\
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lotslvl1)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_SELL, Lotslvl1, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, Red);
minutes=TimeCurrent()+interval2;
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;

/////Activate Pending Orders\\\\\
/////Activate Level 2\\\\\


if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lotslvl1)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;
Ticket = OrderSend(Symbol(), OP_SELLLIMIT, Lotslvl2, Bid+0.0015, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, Red);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid+0.0015, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}
}
if (!EachTickMode) BarCount = Bars;
return(0);
}
}
}
//+------------------------------------------------------------------+

Maybe because you are using usdjpy, which is 3 digits, not 4, like you wanted.

this EA is only used in EURUSD. it makes the first level of trades, but doesnt not make "level 2" trades which are 15 pips above/below the first trade.

Maybe the MT4 platform you are using has a limitation as to the distance in pips from the actual price to place a pending order? So if the trades are meant to be opened together (market and pending) and price has moved somehow, it would give an error. Have you checked the journal or experts tab (in terminal view) to see if there is any error when executing?

Yeah i immediately went to the journal/experts tabs to see if any error was showing but unfortunately nothing is.


I'd love to work with someone on this for more advanced coding I'm not able to do yet. I've been trading this semi-manually (entering in the pending orders myself) and it has proved to be 7% profitable the first week of live demo testing.

How would your sets of orders looked like!????

Please see the attached picture that shows the set up. this trade made a profit in "level 1" so the Buy Limits were not needed, but this is how it was set up manually after the EA automatically executed the first trade.


I know you've used "grids" before in your 100% Win EA, and while this isn't a grid per se, it does follow similar properties.

So, you want to execute 2 more POs for buy or sell every time???

yes that is definitely what i want.



My next step would be to make those pending trades automatically close if any trade before it closed with a profit I've vaguely started to look into this, but if you know how to do it I would be very appreciative.

maybe it has something to do with my original template? magic numbers?


something must be restricting me from opening multiple trades through this coding if no one sees any problem with my set up of pening orders.

There's nothing wrong with your pending order codes but there is something wrong with your if statement prior to it.


because you set TickCheck = True right after you opened your first order, it cause the coming if statement to always return false cos it's expecting TickCheck to be false. so... your pending order code isn't wrong. Its just that it was never executed in the first place. hence, no journal errors.

classic case of good old logic error.

hope this helps. good luck. =)

regards,
Zen

I totaly recoded the ea and this is my try....but now I have a problem!
It is only executing sells!????

lol, that is peculiar, i will try to look through the coding myself and maybe we can find the solution.... I do like your coding template much more than mine but obviously only selling is a problem.



Also want to thank Zen_Leow for his input. I have not tried that solution yet (very busy for some reason??) but once i do i will let you know the results