EA Entry Issues / Too many or too few | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Scripts for Limit entry, Stop entry, Market entry 47 replies

How many strategies are u using and how many pairs do u trade? 0 replies

How many parameters are too many? 0 replies

What would you prefer - many or few trades !!! 23 replies

How many pairs is considered too many? 8 replies

Attachments: EA Entry Issues / Too many or too few
Exit Attachments

EA Entry Issues / Too many or too few

  • #1
  • First Post: Edited 4:42pm Dec 4, 2008 2:21pm | Edited 4:42pm
Trying to test an EA on multiple pairs simultaneously, within the same demo account. Unfortunately, the EA only opens 1 pair/trade at a time ... on the entire platform. Have set it up with separate Magic #'s for each pair to no avail.

I believe I've isolated the issue but have not yet figured out how to solve this. I've noticed by increasing the total<1 to a larger number then trades can open on all appropriate pairs ... but this includes multiple trades per pair.

Can anyone please suggest how to rework this so as to allow only 1 position per pair ... but multiple positions per account? Would be greatly appreciated.


Current code & placement in EA is below

int start()

total = OrdersTotal();
if(total < 1)
{
// no opened orders identified
  • #2
  • Dec 4, 2008 3:11pm Dec 4, 2008 3:11pm
Why not just use several one-pair EAs?
  • #3
  • Dec 4, 2008 3:51pm Dec 4, 2008 3:51pm
Hi RR...

Well, I did that this morning and it doesn't work.

Working from the original I've created multiple (almost identical) EA's. Have given them each separate names, separate Magic #'s, attached them individually, and was hoping for the best ... no good.

Current test should have 6 separate pairs trading ... only one is active. I've even closed it manually and had a trade open on a separate pair ...one of the other 5.

Have I overlooked something in separating them or do you think there's a way to override the total command's coverage of the entire account?
  • #4
  • Dec 4, 2008 5:13pm Dec 4, 2008 5:13pm
hey pip...... it's a little more involved than that.... and without knowing more about what your attempting it's hard to point you in the right direction....

basically, a single ea placed on a single pair should be able to , //----> trade any or all pairs on any or all timeframes with each pair and timeframe combination having it's on unique settings.... it should be able to open , close, modify or delete all orders independetly....

the 2 pictures inclosed are 2 ea's that trade simultainously 3 time frames on all pairs from 1 chart......

the aha ea takes things a step further as seen in the chart.....

//--------------

here are a few common mistakes with multi pairs,

be sure to use the function marketinfo,

Inserted Code
 
void SendmonthusdBuyOrders()
{ 
   OrderSend("GBPUSDm",OP_BUY,  Lots, MarketInfo("GBPUSDm",MODE_ASK), Slippage, MarketInfo("GBPUSDm",MODE_ASK)-(Stoploss*MarketInfo("GBPUSDm",MODE_POINT)),MarketInfo("GBPUSDm",MODE_ASK)+(ProfitTarget*MarketInfo("GBPUSDm",MODE_POINT)),"month usd buy",MagicNumber, 0, CLR_NONE);
   OrderSend("NZDUSDm",OP_BUY,  Lots, MarketInfo("NZDUSDm",MODE_ASK), Slippage, MarketInfo("NZDUSDm",MODE_ASK)-(Stoploss*MarketInfo("NZDUSDm",MODE_POINT)),MarketInfo("NZDUSDm",MODE_ASK)+(ProfitTarget*MarketInfo("NZDUSDm",MODE_POINT)),"month usd buy",MagicNumber, 0, CLR_NONE);
   OrderSend("EURUSDm",OP_BUY,  Lots, MarketInfo("EURUSDm",MODE_ASK), Slippage, MarketInfo("EURUSDm",MODE_ASK)-(Stoploss*MarketInfo("EURUSDm",MODE_POINT)),MarketInfo("EURUSDm",MODE_ASK)+(ProfitTarget*MarketInfo("EURUSDm",MODE_POINT)),"month usd buy",MagicNumber, 0, CLR_NONE);
   OrderSend("AUDUSDm",OP_BUY,  Lots, MarketInfo("AUDUSDm",MODE_ASK), Slippage, MarketInfo("AUDUSDm",MODE_ASK)-(Stoploss*MarketInfo("AUDUSDm",MODE_POINT)),MarketInfo("AUDUSDm",MODE_ASK)+(ProfitTarget*MarketInfo("AUDUSDm",MODE_POINT)),"month usd buy",MagicNumber, 0, CLR_NONE);


and when counting, make sure your counting the right thing..... rather than counting all orders you might really be wanting to count orders by maginumber.....h

Inserted Code
 
int OrderCount(int MagicNumber)
{
totalorders=0;
Attached Image(s) (click to enlarge)
Click to Enlarge Name: aha.gif Size: 25 KB
Click to Enlarge Name: lone wolf magnum.gif Size: 69 KB
to trade and code, keep both simple... no call to impress....h
  • #5
  • Dec 4, 2008 5:29pm Dec 4, 2008 5:29pm
Hi Hayseed,

Thanks for kickin' in here. With my level of programming expertise I like the first look of your suggestion below, but am not completely certain how to apply it.

Quoting hayseed


Inserted Code
 
int OrderCount(int MagicNumber)
{
totalorders=0;
Also, the use of MarketInfo is a new one for me. Took a quick glance at the MetaEditor definition of it and I can see why you recommend it. I'll try to dig into that later this evening.

Do you think the "MarketInfo" would work in the code I originally posted? Something like the edit below? Would sure be simple.



int start()

total = OrdersTotal() MarketInfo();
if(total < 1)
{
// no opened orders identified
  • #6
  • Dec 4, 2008 6:01pm Dec 4, 2008 6:01pm
hey pip..... no, marketinfo() is not used when counting orders....

again, without knowing more about what your attempting my comments will be vague....

there can be many reasons for counting orders..... if your goal is to just count all orders to determine total open orders , your code in the first post might be ok.....

but if your trying to place orders on 5 different pairs, you'll need to count the orders and filter them by symbol or magicnumber....

as example, once the count code verifys no open eurusd order exists it will allow one to be placed...... h
to trade and code, keep both simple... no call to impress....h
  • #7
  • Dec 4, 2008 7:15pm Dec 4, 2008 7:15pm
Hayseed,

Thanks for the commentary on MarketInfo.

To be more specific, I'm working with an ADX based EA and I would like to apply it to more than 1 pair at a time. It tests fine for a single pair (any pair) but is problematic when attached to more than 1 pair.

As regards the total, it is set up to classify "total" as an "int" then provides the code ... :
----------------------------------------------
int cnt, ticket, total;
...
total = OrdersTotal();
if(total < 1)
{
// no opened orders identified
----------------------------------------------
I've learned that if I increase the total to greater than 1, then additional trades will open ... unfortunately, it also opens duplicates in qualifying pairs.

What I'm seeking is a control to allow it to open one trade, and only 1 trade, in more than one pair at a time. This means it may have 10 or more positions open, but only 1 per pair.

Hope this helps clarify the challenge. Any specific pieces of code would also be appreciated. I'm still doing a lot of learning by copying.

Pip Parade
  • #8
  • Dec 4, 2008 7:19pm Dec 4, 2008 7:19pm
Ok, here's how I make sure a specific order is meant for an EA:

Inserted Code
 bool IsTrade = False;

   for (int i = 0; i < Total; i ++) {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if(OrderType() <= OP_SELL &&  OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber) {
         IsTrade = True;

I check three things:

  1. Order Type: Make sure it's a market order
  2. Order Symbol: Make sure the symbol of the order is the same as on the EA
  3. Order MagicNumber: Make sure it's the right magic number.

  • #9
  • Dec 4, 2008 7:47pm Dec 4, 2008 7:47pm
Thanks RR ...

I'll spend some time tonight trying to work through this ... hope to post success tomorrow.

Until then, PP

(p.s. to others ... still open to suggestions :nerd:blush:
  • #10
  • Dec 5, 2008 12:48pm Dec 5, 2008 12:48pm
Hi guys,

Sorry to be so dense but I'm still wrestling with this. Spent a couple of hours last night trying to solve this, unsuccessfully.

If you don't mind looking at it, I've attached the EA for review.

Simply put, I'm looking for a way to use this EA on more than one pair at a time. Once I get past that I'll work some of the other issues in the EA.

Thnx ...

Pip Parade
Attached File(s)
File Type: mq4 ADX-5533.mq4   6 KB | 459 downloads
File Type: ex4 ADX-5533.ex4   5 KB | 460 downloads
  • #11
  • Dec 6, 2008 4:35pm Dec 6, 2008 4:35pm
hey pip...... that was what we needed, the code..... it's only takes a few minutes to write a compltete ea but you'll spend hours trying to fix one that you can't see.....

you can now place it own all pairs and it should reconigize only trades asscoiated with the particular chart....

everyone eventually develops their own style and method of writing ea's..... once you get the basic framework down pat, the rest seems to fall in place.... h
Attached File(s)
File Type: mq4 ADX-55.mq4   9 KB | 529 downloads
to trade and code, keep both simple... no call to impress....h
  • #12
  • Dec 7, 2008 12:44am Dec 7, 2008 12:44am
Yeozers Hayseed, Thank you very much. Clearly more here than simply adding a line or 2 of code.

Can't wait to test this ... and I clearly have a lot to do to complete the overall flow.

Watch for updates. I'll let you know how it goes.

p.s. appreciate your other comments as well. I began exploring this code "stuff" a year ago. I know more now than I did then ... but certainly have a long way to go. Appreciate you helping me take the next step.

Pip Parade ...
  • #13
  • Last Post: Dec 9, 2008 2:52pm Dec 9, 2008 2:52pm
Hayseed,

Attached is the revised EA from the PM recently sent.

Appreciate your input.

PP
Attached File(s)
File Type: mq4 ADX-55-b.mq4   10 KB | 467 downloads
File Type: ex4 ADX-55-b.ex4   9 KB | 418 downloads
0 traders viewing now