Close all my trades

Hi,

I would like to close all orders that are > 0 so I have a CloseAll() function where I close all trades > 0.

For the moment I have a small problem.
The value of ASK and BID are not changing in my loop in my function.

How can I have the current Ask or Bid ?


OrderClose(OrderTicket(),OrderLots(),Ask,3,Yellow);
or
OrderClose(OrderTicket(),OrderLots(),Bid,3,Yellow);

do not give me it

Any help or advice will be nice

1. RefreshRates()
2. OrderClose()

result=false;
while(!result)
{
RefreshRates()
OrderClose(OrderTicket(),OrderLots( ),Ask,3,Yellow);
}

result=false;
while(!result)
{
RefreshRates()
OrderClose(OrderTicket(),OrderLots( ),Bid,3,Yellow);
}

Thanks will test it

hmm... I'm not sure about these codes. wouldn't that put you in an infinite loop? and a semi colon is missing from the call to RefreshRates().

I'm only guessing here but you should probably try


that way when the result becomes true, it will exit the while loop.
Maybe you can try adding in a 500 miliseconds sleep within the while loops so that your cpu usage doesn't spike.

This works fine.

void CloseOrders()
{
if(IsConnected() && IsTradeAllowed() && !IsTradeContextBusy())
{
int total=OrdersTotal();
for(int i=total-1; i>=0; i--)
{
if(OrderSelect(i, SELECT_BY_POS))
{
bool result=false;
while(!result)
{
RefreshRates();
if(OrderType()==OP_BUY)
{
result=OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(),MODE_BID),Slippage,CLR_NONE);
}
if(OrderType()==OP_SELL)
{
result=OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(),MODE_ASK),Slippage,CLR_NONE);
}
}
}
}
}
}

Why won't you guys just use the OrderClosePrice() function?
Why MODE_BID and MODE_ASK? That's just extra coding, am I right?
I always use OrderClosePrice(), and everything is working fine all the time.
What's the point of you guys using RefreshRates()? It barely made any calculations, and it'll work without RefreshRates().
Please someone prove me wrong.

each to their own.

It may sound childish but I just refuse to use that function merely because I don't like how its named. =)

I would like to have an EA which closes all current opened positions if an indicated profit is reached. For example, there are 5 working positions inside MT4 platform, if the current profit of those positions is 100$, then it closes all of them.

Does anybody have already done EA? If yes, please attach!