Order Placing

#1
First Post: Edited Dec 1, 2008 12:22am Nov 30, 2008 1:14am | Edited Dec 1, 2008 12:22am

deedeed
| Joined Apr 2007 | Status: Trader | 120 Posts

Hi Guys,

1. Can a magic number be a 10 digit number. Basically I would like to use Time[0] as the magic number cos its unique.

2. If there are no orders in this history with a particular Magic Number which is Time[0], then I would like to place a buy or a sell order. I am not able to write a code for retrieving OrdersHistoryTotal() and checking if there was a previous order with a particular Magic Number. Please help me solve this.

Cheers
Brijesh

#2
Dec 1, 2008 12:23am Dec 1, 2008 12:23am

deedeed
| Joined Apr 2007 | Status: Trader | 120 Posts

MQL Gurus,

Please take a look at my problem and help me solve this...

#3
Dec 1, 2008 8:59am Dec 1, 2008 8:59am

Zen_Leow
Joined Jun 2008 | Status: Programming for a better future. | 652 Posts

1. Yes Magic number can be 10 digits. but the value must be no bigger than 2147483647 as that is the maximum an integer can go in MQL.

2. I don't quite understand what you're trying to do with this... the purpose of magic numbers is to allow an EA to identify the trades that it opened. there can be multiple EAs running on the same client terminal so EA uses magic numbers to know which are the trades it should manage. Magic numbers should be unique between running EAs, not between the trades. As such, the magic number should be fixed (good practise). I believe if there's something you want to achieve, there are other variables to play with.

If I were to venture a guess, I'd say you're trying to allow only one order opening per candle and you wish to use the Time[0] to tell you if there's a trade already opened for this candle. You're off to a good start but chosen a wrong path. You don't have to set the Time[0] into your trade as a magic number to compare with. Every order has a timestamp already written in. What you should do is to compare Time[0] with the OrderOpenTime().

If that's what you're looking for, I've already written a function to do that so you don't have to reinvent the wheel. and yes, it checks order history as well. =)

Inserted Code

bool DecideToOpenTrade()
{
   int total = OrdersTotal();
   if (total > 0)
   {
      for(int cnt=0;cnt<total;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            if(OrderSymbol()==Symbol() && OrderMagicNumber() == EA_MAGIC_NUM)
            {
               return (false);
            }
         }
      }
   }
   // in case trades has already opened and closed within the candle
   int histotal = OrdersHistoryTotal();
   if (histotal > 0)
   {
      for(cnt=0;cnt<histotal;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS,MODE_HISTORY))
         {
            if(OrderSymbol()==Symbol() && OrderMagicNumber() == EA_MAGIC_NUM)
            {
               if (Time[0] <= OrderOpenTime()) // don't open a new position if we're still on the same candle
               {
                  return (false);
               }
            }
         }
      }
   }
   return (true);
}
 
int start()
{
   if (DecideToOpenTrade())
   {
      //... trade opening codes
   }
}

* note that EA_MAGIC_NUM is a number I fixed at the beginning of the EA not shown here.

hope this helps.

regards,
Zen

Programming for a better future.

#4
Last Post: Dec 1, 2008 11:21am Dec 1, 2008 11:21am

deedeed
| Joined Apr 2007 | Status: Trader | 120 Posts

Thanks Zen for helping me with the code.

Yes I was looking for one trade per bar. And thanks once again for the guidance.

Cheers
Brijesh

0 traders viewing now

Options

Similar Threads

Order Placing