How to Close MagicNumbers | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

what are chriminalisENC & magicnumbers? 1 reply

Need help for Hedge EA with 2 MagicNumbers 1 reply

Need help!! Close order on this bar close 5 replies

Seeking Correct Open/Close - It's Close but ... 0 replies

Are MagicNumbers stored in history? 2 replies

Attachments: How to Close MagicNumbers
Exit Attachments

How to Close MagicNumbers

  • #1
  • First Post: Nov 25, 2008 3:16pm Nov 25, 2008 3:16pm
Can someone confirm if this is correct.

I want to close specific pairs that are assigned different magic numbers

int totalordersQm = OrdersTotal();
for(int iQm=totalordersQm-1;iQm>=0;iQm--)
{
OrderSelect(iQm, SELECT_BY_POS,MODE_TRADES);
{
if((OrderMagicNumber()==1111 && OrderMagicNumber()==222 && OrderMagicNumber()==3333) || (OrderMagicNumber()==111 && OrderMagicNumber()==2222 && OrderMagicNumber()==333)){
if ((GP)>0){
if ( AccountProfit()>0){
PlaySound("ArbClose.wav");
if (OrderType() == OP_BUY )
OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );

if (OrderType() == OP_SELL )
OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );

}
}
}
}
}
  • #2
  • Nov 25, 2008 3:48pm Nov 25, 2008 3:48pm
OrderMagicNumber cannot be assigned to more than one number at a time .

So your statements with the && will always be false.

PHP Code
void CloseTrades(int type )
   {
      int totalorders = OrdersTotal();
      
      for(int n=totalorders-1;n>=0;n--)
         {
            OrderSelect(n, SELECT_BY_POS);
            //bool result = false;
            if ( OrderMagicNumber()== Magic ) 
               {
                  //Close opened long positions
                  if ( OrderType() == type && type == OP_BUY )OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, White );
                  //Close opened short positions
                  if ( OrderType() == type && type == OP_SELL )OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, White );
                  //Close pending orders
                  //if ( OrderType() > 1 )result=  OrderDelete( OrderTicket() );
               }
         }
       
      return;
   }
This is function from the indicator I posted in another forum, I think it should help you see what I am talking about.
Attached File(s)
File Type: mq4 FXSniperT3CCIEA_v1.1.mq4   4 KB | 347 downloads
  • #3
  • Nov 26, 2008 1:52pm Nov 26, 2008 1:52pm
There is only 1 majic number can be assign to 1 ticket number
If everyone believes it, it will work.
  • #4
  • Last Post: Nov 26, 2008 1:57pm Nov 26, 2008 1:57pm
So you need to have an array to store all the tickets with different majic number.

So using a for loop to query thru all tickets, and insert them into array by their ticket number.

After the loop finishes, you should have an array with different ticket numbers, then you can close those tickets.
If everyone believes it, it will work.
0 traders viewing now