Attachments: Script for closing all the active positions

Script for closing all the active positions

#1
First Post: Nov 24, 2008 8:32am Nov 24, 2008 8:32am

m0j1
| Joined Oct 2007 | Status: Trader | 36 Posts

hi , I've written a script to close all the active positions and it works , but only on one symbol . for example if you have EURUSD and GBPUSD positions and you run this script on EURUSD window , it closes only EURUSD positions .
is there a way to do this for every position I have?
the code is as follow:
//-----------------------------------------
//+------------------------------------------------------------------+
//| CloseAll.mq4 |
//| m0j1 |
//| |
//+------------------------------------------------------------------+
#property copyright "m0j1"
#property link ""
#property show_confirm
//+------------------------------------------------------------------+
//| script program start function |
//+------------------------------------------------------------------+
int i,total,err;
int start()
{
//----
total = OrdersTotal();
while(total>0){
total=OrdersTotal();
if(OrderSelect(0,SELECT_BY_POS,MODE_TRADES)){
if(OrderType()==OP_BUY){
OrderClose(OrderTicket(),OrderLots(),Bid,10,Blue);
err=GetLastError();
while(err==129){
RefreshRates();
//Sleep(100);
OrderClose(OrderTicket(),OrderLots(),Bid,10,Blue);
err=GetLastError();
}
Print("Buy Error: ",err);
//Print("Order Buy closed at :",Bid," Order Number: ",OrdersTotal());
}
if(OrderType()==OP_SELL){
OrderClose(OrderTicket(),OrderLots(),Ask,10,Red);
err=GetLastError();
while(err==129){
RefreshRates();
//Sleep(100);
OrderClose(OrderTicket(),OrderLots(),Ask,10,Blue);
err=GetLastError();
}
Print("Sell Error: ",err);
//Print("Order Sell closed at:",Bid," Order Number: ",OrdersTotal());
}
}
else{
Print("ERROR SELECTING");
}
}
//----
return(0);
}
//+------------------------------------------------------------------+

#2
Nov 24, 2008 8:44am Nov 24, 2008 8:44am

kins
| Membership Revoked | Joined Apr 2008 | 12 Posts

pls i like you to help me to code this words to EA . when open price comes out it will enter a buy and sell order instantly the same time and with tp and sl . Another one when open price comes out and goes up to about 30 or 50 pips it will enter buy other .but if the open price goes down to about 30 or 50pips it will enter other.pls put breakeven and tp,sl, to all pls. reply as soon as possible
************

#3
Nov 24, 2008 9:06am Nov 24, 2008 9:06am

LongToBeFree
| Membership Revoked | Joined Oct 2008 | 613 Posts

Quoting kins

Disliked

pls i like you to help me to code this words to EA . when open price comes out it will enter a buy and sell order instantly the same time and with tp and sl . Another one when open price comes out and goes up to about 30 or 50 pips it will enter buy other .but if the open price goes down to about 30 or 50pips it will enter other.pls put breakeven and tp,sl, to all pls. reply as soon as possible
************

Ignored

Sure, no problem. Have nothing better to do . . . I will have this for you in 20 minutes.

#4
Nov 24, 2008 9:11am Nov 24, 2008 9:11am

LongToBeFree
| Membership Revoked | Joined Oct 2008 | 613 Posts

There's nothing in your code that even uses the order symbol. Are you SURE that it's only closing out the ones for the current chart? Are you sure it's not something else like it's only closing out long positions? Closing only based on symbols makes no sense.

Quoting m0j1

Disliked

hi , I've written a script to close all the active positions and it works , but only on one symbol . for example if you have EURUSD and GBPUSD positions and you run this script on EURUSD window , it closes only EURUSD positions .
is there a way to do this for every position I have?
the code is as follow:
//-----------------------------------------
//+------------------------------------------------------------------+
//| CloseAll.mq4 |
//| m0j1 |
//| |
//+------------------------------------------------------------------+
#property copyright...

Ignored

#5
Nov 24, 2008 9:48am Nov 24, 2008 9:48am

m0j1
| Joined Oct 2007 | Status: Trader | 36 Posts

yes I'm sure . it's only able to do the code on the symbol you attach the script . is this a normal thing that when you attach a script on a window it only performs the code on that specific symbol?

#6
Nov 24, 2008 10:52am Nov 24, 2008 10:52am

Zen_Leow
Joined Jun 2008 | Status: Programming for a better future. | 652 Posts

your problem is because of using Bid and Ask. these variables are subjective to the chart its attached to. This is as good as saying "please close my USDCHF trade using EURUSD Bid or Ask" if I'm not wrong your script did attempt to close those other trades but ended up in error cos the price you wanna close at is too far off.

what you should do is make use of the MarketInfo function. use that instead of just merely bid and ask. that should solve your problem. I've attached my version of "Close all trades" script for your reference.

Inserted Code

//+------------------------------------------------------------------+
//|                                          close_all_positions.mq4 |
//|                                                         Zen Leow |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Zen Leow"
#property link      ""
#property show_confirm
#include <stdlib.mqh>
//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
int start()
{
//----
   int total = OrdersTotal()-1;
   int positionType;
   if (total > 0)
   {
      for(int cnt=total;cnt>=0;cnt--)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            positionType = OrderType();
            if (positionType == OP_BUY)
            {
               if (!OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(),MODE_BID),3))
               {
                  OrderError();
               }
            }
            if (positionType == OP_SELL)
            {
               if (!OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(),MODE_ASK),3))
               {
                  OrderError();
               }
            }
            if (positionType != OP_SELL && positionType != OP_BUY) // pending orders
            {
               if (!OrderDelete(OrderTicket()))
               {
                  OrderError();
               }
            }
         }
      }
   }
//----
   return(0);
}
void OrderError() {
  int iError=GetLastError();
  Print("Order:",OrderTicket()," GetLastError()=",iError," ",ErrorDescription(iError));
}
//+------------------------------------------------------------------+

pm me if you need help. good luck

regards,
Zen

p.s.; just to answer your latest query, with correct use of MarketInfo() function, you can literally send a buy, sell, close or delete command to any currency pair from any chart.

Programming for a better future.

#7
Nov 24, 2008 11:40am Nov 24, 2008 11:40am

mnhidayat_bfc
| Joined Jun 2006 | Status: Trader | 7 Posts

Wish will be usefull for us..

=======================
www.mnurhidayatollah.co.cc

Attached File(s)

Close all open positions.ex4 2 KB | 582 downloads

#8
Nov 24, 2008 4:21pm Nov 24, 2008 4:21pm

m0j1
| Joined Oct 2007 | Status: Trader | 36 Posts

yeah you're right zen leow . that was the problem . writing this code was a good educational experience for me , thanks eveyone .

#9
Last Post: Apr 15, 2010 10:10am Apr 15, 2010 10:10am

ecronic
| Joined Apr 2010 | Status: Trader | 1 Post

Quoting Zen_Leow

Disliked

your problem is because of using Bid and Ask. these variables are subjective to the chart its attached to. This is as good as saying "please close my USDCHF trade using EURUSD Bid or Ask" if I'm not wrong your script did attempt to close those other trades but ended up in error cos the price you wanna close at is too far off.

what you should do is make use of the MarketInfo function. use that instead of just merely bid and ask. that should solve your problem. I've attached my version of "Close all trades" script for your reference.

[code]
//+------------------------------------------------------------------+
//|...

Ignored

Hi Zen,

First of all, thanks for the script above. I have used it for quite some of my trades now and it has really helped.

But since I've been using it I've put some thinking into it and have also modified your script to work to my benefit. Basically I wanted this script to close only specific symbols that I would be given a selection of. Like load an array of symbols in the beginning and then put in a true or false value to tell the script which symbols to close.

I have attached the modified script but at the moment it only closes AUDUSD symbol. If you could help me in making it give an option as to how to close multiple symbols in a set of symbols predefined within the script.

Please bare with me as I know the basics of scripting only and still not familiar as to how to fully use the functions in mql scripting.

My Script:

Inserted Code

//+------------------------------------------------------------------+
//|                                          close_all_positions.mq4 |
//|                                                         Zen Leow |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Zen Leow"
#property link      ""
#property show_confirm
#include <stdlib.mqh>
extern double AUDUSD;
string Symbols = "AUDUSD";
//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+

int start()
{
//----
   int total = OrdersTotal()-1;
   int positionType;
   if (total > 0)
   {
      for(int cnt=total;cnt>=0;cnt--)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            positionType = OrderType();
            if (positionType == OP_BUY)
            {
               if (!OrderClose(OrderTicket(),OrderLots(),MarketInfo(Symbols,MODE_BID),3))
               {
                  OrderError();
               }
            }
            if (positionType == OP_SELL)
            {
               if (!OrderClose(OrderTicket(),OrderLots(),MarketInfo(Symbols,MODE_ASK),3))
               {
                  OrderError();
               }
            }
            if (positionType != OP_SELL && positionType != OP_BUY) // pending orders
            {
               if (!OrderDelete(OrderTicket()))
               {
                  OrderError();
               }
            }
         }
      }
   }
//----
   return(0);
}
void OrderError() {
  int iError=GetLastError();
  Print("Order:",OrderTicket()," GetLastError()=",iError," ",ErrorDescription(iError));
}
//+------------------------------------------------------------------+

Thanks & regards
Ecronic

Platform Tech
/
Script for closing all the active positions
Reply to Thread

0 traders viewing now

Options

Similar Threads

Script for closing all the active positions